Remove event listeners before component unmounts#1982
Closed
Arooba-git wants to merge 1 commit into
Closed
Conversation
The event listeners added in ResizablePanels and StepForm are never removed once added. Even after the component unmounts, the event handlers remain bound to the events. This would lead to accumulation of such listeners each time component is mounted, leading to memory leak.
Member
|
Closing as we're gonna rewrite the UI part at some point |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! 👋
The event listeners added in ResizablePanels and StepForm are never removed once added. Even after the component unmounts, the event handlers remain bound to the events. This would lead to an accumulation of such listeners each time a component is mounted, leading to a memory leak. This PR fixes this issue:)