Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch will remove TownyWorlds saving a list of towns. #3799

Merged
merged 5 commits into from Mar 25, 2020
Merged

Conversation

@LlmDl
Copy link
Member

LlmDl commented Mar 19, 2020

Description:

Towns have changed from town.getWorld() to town.getHomeblockWorld(),
with getWorld() becoming deprecated and returning getHomeblockWorld().

Some instances of town.getWorld() are now correctly using
townblock.getWorld() or something similar when it is called for.

Stop getHomeblockWorld() from returning null when towns have claimed 0
townblocks.

Towny.setWorldFlags() from startup sequence is gone.

SQL now drops old towns columns and saves/loads worlds without towns
like flatfile.


New Nodes/Commands/ConfigOptions:


Relevant Towny Issue ticket:


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.

Towns have changed from town.getWorld() to town.getHomeblockWorld(),
with getWorld() becoming deprecated and returning getHomeblockWorld().

Some instances of town.getWorld() are now correctly using
townblock.getWorld() or something similar when it is called for.

Stop getHomeblockWorld() from returning null when towns have claimed 0
townblocks.

Towny.setWorldFlags() from startup sequence is gone.

SQL now drops old towns columns and saves/loads worlds without towns
like flatfile.
@LlmDl LlmDl requested review from suneettipirneni and silverwolfg11 Mar 19, 2020
Copy link
Contributor

suneettipirneni left a comment

Looks pretty good overall just a few changes/recommendations.

faster loading of TownBlocks
@LlmDl LlmDl requested a review from suneettipirneni Mar 23, 2020
Copy link
Contributor

suneettipirneni left a comment

Looks good

@LlmDl LlmDl force-pushed the database/worlds_update branch from 53e71b0 to 3760c36 Mar 23, 2020
CombatUtil#preventPVP.
@LlmDl LlmDl merged commit 29947ad into master Mar 25, 2020
2 checks passed
2 checks passed
build
Details
build
Details
@LlmDl LlmDl deleted the database/worlds_update branch Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.