Add Cloudflare R2 support#2319
Conversation
6931355 to
ba58536
Compare
ba58536 to
f7112b0
Compare
ashishsonamm
left a comment
There was a problem hiding this comment.
@ashishsonamm made 1 comment.
Reviewable status: 0 of 1 LGTMs obtained, and 0 of 8 files reviewed.
|
Hey @ashishsonamm thanks for coming through and opening a PR. We'd love to support you in landing your first PR here. A couple initial thoughts:
Really awesome work!!! |
I looked at the The fix would be to rework R2Store so it builds its own aws S3 client with the endpoint and creds, and passes it to I'll make this change and will also add the documentation |
f7112b0 to
d744655
Compare
d744655 to
1d6afc5
Compare
|
Pushed the change for R2Store to build its own S3 client without touching any of the existing S3 store code. |
Nice, liking this. If it's meant to be "S3 with another endpoint/region config" then this is the right way to go with this. |
1d6afc5 to
f7cc5af
Compare
Description
Adds Cloudflare R2 as a first-class CAS/AC backend by generalizing
S3StoreIntroduced 3 new optional fields in
ExperimentalAwsSpecIf all the above three fields are unset,
S3Store::newbehaves exactly as beforeFixes #2293
Type of change
How Has This Been Tested?
Checklist
bazel test //...passes locallygit amendsee some docsThis change is