Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safeURL to social icons links #106

Merged
merged 1 commit into from Oct 27, 2019
Merged

Add safeURL to social icons links #106

merged 1 commit into from Oct 27, 2019

Conversation

@Nico264
Copy link
Contributor

Nico264 commented Oct 20, 2019

The social icon links are generated from developer-controlled config.toml file. They can be considered safe.
This enables using various URI schemes such as tel:, sip:, geo: or whatever:.

Copy link
Owner

Track3 left a comment

This is useful, just one minor suggestion, it's better using {{.url | safeURL}} instead of {{safeURL .url}} here, just because this pipe like format is used in almost anywhere across the theme. Both is correct and works, just to improve code consistency please change this and I'll merge, thanks!

The social icon links are generated from developer-controlled config.toml file. They can be considered safe.
This enables using various URI schemes such as `tel:`, `sip:`, `geo:` or `whatever:`.
@Nico264 Nico264 force-pushed the Nico264:patch-1 branch from ec9c4e4 to c6af673 Oct 27, 2019
@Nico264

This comment has been minimized.

Copy link
Contributor Author

Nico264 commented Oct 27, 2019

OK, done! I'm quite new to Hugo and didn't know both syntax were correct.
(I you knew the time it took me to figure out why my tel: link didn't work as expected…)

@Track3
Track3 approved these changes Oct 27, 2019
@Track3 Track3 merged commit f647c23 into Track3:master Oct 27, 2019
5 checks passed
5 checks passed
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
deploy/netlify Deploy preview ready!
Details
@Nico264 Nico264 deleted the Nico264:patch-1 branch Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.