[rename] rename, w/ deprecate#6
Conversation
Summary of ChangesHello @asaiacai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request rebrands the MLOps framework's Python client library by renaming its core package from 'mlop' to 'pluto'. This change involves updating all internal references, documentation, and configuration settings to reflect the new name. A key aspect of this transition is the implementation of a backward compatibility layer, ensuring that existing codebases using 'import mlop' will continue to function, albeit with deprecation warnings, facilitating a smooth migration for users. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request undertakes a comprehensive renaming of the project from mlop to pluto. The changes are extensive, covering code, documentation, tests, and configuration files. The implementation correctly introduces backward compatibility shims for the old mlop package, ensuring a smooth transition for existing users. The use of deprecation warnings is a good practice. My review focuses on the completeness and consistency of this renaming effort. I've found a few minor inconsistencies that should be addressed to finalize the refactoring.
- Update Colab notebook links from mlop-ai/mlop to Trainy-ai/pluto - Rename _MLOP_COMMIT_SHA to _PLUTO_COMMIT_SHA in pluto/__init__.py - Fix log message to reference PLUTO_PROJECT instead of MLOP_PROJECT 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Fix F821: rename _MLOP_COMMIT_SHA to _PLUTO_COMMIT_SHA in pluto/__init__.py - Fix E402: add noqa comments to mlop shim imports (intentional after warnings) - Fix E501: wrap long lines in pluto/compat/neptune.py and tests/test_env_vars.py 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Update test assertions to use _pluto_run instead of _mlop_run after the attribute was renamed during the mlop->pluto rebranding. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Using @main can cause instability due to untested changes. Pin to a stable release version. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The Poetry action cache was restoring virtualenvs without dev dependencies installed (mypy, pytest). Poetry would skip installation thinking deps were already present, causing "Command not found" errors. Fix: Clear .venv before poetry install to force fresh installation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The workflow was referencing `secrets.PLUTO_API_TOKEN` which doesn't exist in the repo. Changed to use `secrets.MLOP_API_TOKEN` which is the actual secret name configured in GitHub. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Change mlop-ai/server link to docs.trainy.ai/pluto - Fix documentation URL to docs.trainy.ai/pluto - Comment out colab tutorial links 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Users can now configure authentication and project via environment variables instead of only through the Python SDK or CLI: - PLUTO_API_TOKEN: Sets the API token (alternative to `pluto login`) - PLUTO_PROJECT: Sets the default project (alternative to `init(project=...)`) Both support deprecated MLOP_* fallbacks with warnings. Precedence order: function params > env vars > keyring > defaults 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Tested (run the relevant ones):
bash format.sh