diff --git a/.github/workflows/buildwindowsimage.yml b/.github/workflows/buildwindowsimage.yml index 7340815..e0d5c5c 100644 --- a/.github/workflows/buildwindowsimage.yml +++ b/.github/workflows/buildwindowsimage.yml @@ -22,12 +22,12 @@ jobs: - name: Publish Images to Docker Hub - Pre Release if: ${{ github.event.release.prerelease == true }} run: | - docker build . --file MessagingService/Dockerfilewindows --tag stuartferguson/messagingservicewindows:dev --build-arg NUGET_TOKEN=${{ secrets.PRIVATEFEED_APIKEY }} + docker build . --file MessagingService/Dockerfilewindows --tag stuartferguson/messagingservicewindows:dev docker login --username=${{ secrets.DOCKER_USERNAME }} --password=${{ secrets.DOCKER_PASSWORD }} docker push stuartferguson/messagingservicewindows:dev - name: Publish Images to Docker Hub - Formal Release if: ${{ github.event.release.prerelease == false }} run: | - docker build . --file MessagingService/Dockerfilewindows --tag stuartferguson/messagingservicewindows:latest --build-arg NUGET_TOKEN=${{ secrets.PRIVATEFEED_APIKEY }} + docker build . --file MessagingService/Dockerfilewindows --tag stuartferguson/messagingservicewindows:latest docker login --username=${{ secrets.DOCKER_USERNAME }} --password=${{ secrets.DOCKER_PASSWORD }} docker push stuartferguson/messagingservicewindows:latest diff --git a/.github/workflows/createrelease.yml b/.github/workflows/createrelease.yml index 237a2f4..d649722 100644 --- a/.github/workflows/createrelease.yml +++ b/.github/workflows/createrelease.yml @@ -20,8 +20,6 @@ jobs: run: echo ::set-output name=VERSION::${GITHUB_REF/refs\/tags\//} - name: Restore Nuget Packages - env: - GITHUBTOKEN: ${{ secrets.PRIVATEFEED_APIKEY }} run: dotnet restore MessagingService.sln --source ${{ secrets.PUBLICFEEDURL }} --source ${{ secrets.PRIVATEFEED_URL }} - name: Build Code @@ -37,14 +35,14 @@ jobs: - name: Publish Images to Docker Hub - Pre Release if: ${{ github.event.release.prerelease == true }} run: | - docker build . --file MessagingService/Dockerfile --tag stuartferguson/messagingservice:dev --build-arg NUGET_TOKEN=${{ secrets.PRIVATEFEED_APIKEY }} + docker build . --file MessagingService/Dockerfile --tag stuartferguson/messagingservice:dev docker login --username=${{ secrets.DOCKER_USERNAME }} --password=${{ secrets.DOCKER_PASSWORD }} docker push stuartferguson/messagingservice:dev - name: Publish Images to Docker Hub - Formal Release if: ${{ github.event.release.prerelease == false }} run: | - docker build . --file MessagingService/Dockerfile --tag stuartferguson/messagingservice:latest --build-arg NUGET_TOKEN=${{ secrets.PRIVATEFEED_APIKEY }} + docker build . --file MessagingService/Dockerfile --tag stuartferguson/messagingservice:latest docker login --username=${{ secrets.DOCKER_USERNAME }} --password=${{ secrets.DOCKER_PASSWORD }} docker push stuartferguson/messagingservice:latest diff --git a/.github/workflows/nightlybuild.yml b/.github/workflows/nightlybuild.yml index 3f2ea0b..7a159f0 100644 --- a/.github/workflows/nightlybuild.yml +++ b/.github/workflows/nightlybuild.yml @@ -46,8 +46,6 @@ jobs: run: echo "action_url=$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID" >> $GITHUB_ENV - name: Restore Nuget Packages - env: - GITHUBTOKEN: ${{ secrets.PRIVATEFEED_APIKEY }} run: dotnet restore MessagingService.sln --source ${{ secrets.PUBLICFEEDURL }} --source ${{ secrets.PRIVATEFEED_URL }} - name: Build Code @@ -70,7 +68,7 @@ jobs: files: ./lcov1.info,./lcov2.info,./lcov3.info,./lcov4.info - name: Build Docker Image - run: docker build . --file MessagingService/Dockerfile --tag messagingservice:latest --build-arg NUGET_TOKEN=${{ secrets.PRIVATEFEED_APIKEY }} + run: docker build . --file MessagingService/Dockerfile --tag messagingservice:latest - name: Run Integration Tests run: dotnet test "MessagingService.IntegrationTests\MessagingService.IntegrationTests.csproj" diff --git a/.github/workflows/pullrequest.yml b/.github/workflows/pullrequest.yml index 1b044c2..aa4676f 100644 --- a/.github/workflows/pullrequest.yml +++ b/.github/workflows/pullrequest.yml @@ -17,8 +17,6 @@ jobs: - uses: actions/checkout@v2.3.4 - name: Restore Nuget Packages - env: - GITHUBTOKEN: ${{ secrets.PRIVATEFEED_APIKEY }} run: dotnet restore MessagingService.sln --source ${{ secrets.PUBLICFEEDURL }} --source ${{ secrets.PRIVATEFEED_URL }} - name: Build Code diff --git a/.github/workflows/pushtomaster.yml b/.github/workflows/pushtomaster.yml index 2c6a077..dd3111b 100644 --- a/.github/workflows/pushtomaster.yml +++ b/.github/workflows/pushtomaster.yml @@ -20,8 +20,6 @@ jobs: fetch-depth: 0 - name: Restore Nuget Packages - env: - GITHUBTOKEN: ${{ secrets.PRIVATEFEED_APIKEY }} run: dotnet restore MessagingService.sln --source ${{ secrets.PUBLICFEEDURL }} --source ${{ secrets.PRIVATEFEED_URL }} - name: Build Code @@ -53,7 +51,7 @@ jobs: - name: Publish Images to Docker Hub run: | - docker build . --file MessagingService/Dockerfile --tag stuartferguson/messagingservice:master --build-arg NUGET_TOKEN=${{ secrets.PRIVATEFEED_APIKEY }} + docker build . --file MessagingService/Dockerfile --tag stuartferguson/messagingservice:master docker login --username=${{ secrets.DOCKER_USERNAME }} --password=${{ secrets.DOCKER_PASSWORD }} docker push stuartferguson/messagingservice:master @@ -71,6 +69,6 @@ jobs: - name: Publish Windows Images to Docker Hub run: | - docker build . --file MessagingService/Dockerfilewindows --tag stuartferguson/messagingservicewindows:master --build-arg NUGET_TOKEN=${{ secrets.PRIVATEFEED_APIKEY }} + docker build . --file MessagingService/Dockerfilewindows --tag stuartferguson/messagingservicewindows:master docker login --username=${{ secrets.DOCKER_USERNAME }} --password=${{ secrets.DOCKER_PASSWORD }} docker push stuartferguson/messagingservicewindows:master diff --git a/.github/workflows/sonarcloud.yml b/.github/workflows/sonarcloud.yml index 40191bf..80eedfc 100644 --- a/.github/workflows/sonarcloud.yml +++ b/.github/workflows/sonarcloud.yml @@ -43,7 +43,6 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} - GITHUBTOKEN: ${{ secrets.PRIVATEFEED_APIKEY }} shell: powershell run: | .\.sonar\scanner\dotnet-sonarscanner begin /k:"TransactionProcessing_Messaging" /o:"transactionprocessing" /d:sonar.login="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" diff --git a/MessagingService/Dockerfile b/MessagingService/Dockerfile index c94839b..31538fd 100644 --- a/MessagingService/Dockerfile +++ b/MessagingService/Dockerfile @@ -10,9 +10,6 @@ ARG NUGET_TOKEN WORKDIR /src COPY ["MessagingService/NuGet.Config", "."] -# Replace the placeholders in the NuGet.config file with the GitHub Secret -RUN sed -i "s|NUGET_TOKEN|${NUGET_TOKEN}|g" NuGet.Config - COPY ["MessagingService/MessagingService.csproj", "MessagingService/"] COPY ["MessagingService.BusinessLogic/MessagingService.BusinessLogic.csproj", "MessagingService.BusinessLogic/"] COPY ["MessagingService.EmailMessageAggregate/MessagingService.EmailMessageAggregate.csproj", "MessagingService.EmailMessageAggregate/"] diff --git a/MessagingService/Dockerfilewindows b/MessagingService/Dockerfilewindows index e02c326..e454d1c 100644 --- a/MessagingService/Dockerfilewindows +++ b/MessagingService/Dockerfilewindows @@ -7,9 +7,6 @@ ARG NUGET_TOKEN WORKDIR /src COPY ["MessagingService/NuGet.Config", "."] -# Replace the placeholders in the NuGet.config file with the GitHub Secret -RUN powershell -Command "(Get-Content NuGet.Config) -replace 'NUGET_TOKEN', '${env:NUGET_TOKEN}' | Set-Content NuGet.Config" - COPY ["MessagingService/MessagingService.csproj", "MessagingService/"] COPY ["MessagingService.BusinessLogic/MessagingService.BusinessLogic.csproj", "MessagingService.BusinessLogic/"] COPY ["MessagingService.EmailMessageAggregate/MessagingService.EmailMessageAggregate.csproj", "MessagingService.EmailMessageAggregate/"] diff --git a/MessagingService/NuGet.Config b/MessagingService/NuGet.Config index 7eec447..3086e20 100644 --- a/MessagingService/NuGet.Config +++ b/MessagingService/NuGet.Config @@ -1,14 +1,14 @@  - + - - - - + + + + diff --git a/NuGet.Config b/NuGet.Config index 23979ac..3086e20 100644 --- a/NuGet.Config +++ b/NuGet.Config @@ -1,14 +1,14 @@  - + - - - - + + + +