From 30fff4313687d23e2dba2bf4babf35d57c707650 Mon Sep 17 00:00:00 2001
From: Stuart Ferguson <stuart_ferguson1@btinternet.com>
Date: Wed, 23 Oct 2024 09:59:54 +0100
Subject: [PATCH 1/2] need to add back in the original HandleResponse method :|

---
 ClientProxyBase/ClientProxyBase.cs | 36 +++++++++++++++++++++++++++++-
 1 file changed, 35 insertions(+), 1 deletion(-)

diff --git a/ClientProxyBase/ClientProxyBase.cs b/ClientProxyBase/ClientProxyBase.cs
index e3d4f4ad..1fc42f87 100644
--- a/ClientProxyBase/ClientProxyBase.cs
+++ b/ClientProxyBase/ClientProxyBase.cs
@@ -36,6 +36,40 @@ protected ClientProxyBase(HttpClient httpClient)
 
         #region Methods
 
+        protected virtual async Task<String> HandleResponse(HttpResponseMessage responseMessage,
+                                                            CancellationToken cancellationToken)
+        {
+            String result = String.Empty;
+
+            // Read the content from the response
+            String content = await responseMessage.Content.ReadAsStringAsync();
+
+            // Check the response code
+            if (!responseMessage.IsSuccessStatusCode)
+            {
+                // throw a specific  exception to inherited class
+                switch (responseMessage.StatusCode)
+                {
+                    case HttpStatusCode.BadRequest:
+                        throw new InvalidOperationException(content);
+                    case HttpStatusCode.Unauthorized:
+                    case HttpStatusCode.Forbidden:
+                        throw new UnauthorizedAccessException(content);
+                    case HttpStatusCode.NotFound:
+                        throw new KeyNotFoundException(content);
+                    case HttpStatusCode.InternalServerError:
+                        throw new Exception("An internal error has occurred");
+                    default:
+                        throw new Exception($"An internal error has occurred ({responseMessage.StatusCode})");
+                }
+            }
+
+            // Set the result
+            result = content;
+
+            return result;
+        }
+
         /// <summary>
         /// Handles the response.
         /// </summary>
@@ -53,7 +87,7 @@ protected ClientProxyBase(HttpClient httpClient)
         /// <exception cref="Exception">An internal error has occurred
         /// or
         /// An internal error has occurred</exception>
-        protected virtual async Task<Result<String>> HandleResponse(HttpResponseMessage responseMessage,
+        protected virtual async Task<Result<String>> HandleResponseX(HttpResponseMessage responseMessage,
                                                             CancellationToken cancellationToken)
         {
             String result = String.Empty;

From 8686487643fc8860bfe2b958c1e4c533f5a1ace5 Mon Sep 17 00:00:00 2001
From: Stuart Ferguson <stuart_ferguson1@btinternet.com>
Date: Wed, 23 Oct 2024 16:01:15 +0100
Subject: [PATCH 2/2] :| fix tests

---
 Shared.Tests/ClientProxyBaseTests.cs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Shared.Tests/ClientProxyBaseTests.cs b/Shared.Tests/ClientProxyBaseTests.cs
index 44eda45e..4a554b26 100644
--- a/Shared.Tests/ClientProxyBaseTests.cs
+++ b/Shared.Tests/ClientProxyBaseTests.cs
@@ -132,7 +132,7 @@ public TestClient(HttpClient httpClient) : base(httpClient){
         }
 
         public async Task<Result<String>> Test(HttpResponseMessage responseMessage, CancellationToken cancellationToken){
-            return await this.HandleResponse(responseMessage, cancellationToken);
+            return await this.HandleResponseX(responseMessage, cancellationToken);
         }
     }
 }