From ca80f26af56b6bbe1772291992132f3a9d9e9a77 Mon Sep 17 00:00:00 2001 From: "deepsource-autofix[bot]" <62050782+deepsource-autofix[bot]@users.noreply.github.com> Date: Sat, 20 Sep 2025 19:15:07 +0000 Subject: [PATCH] refactor: simplify single-statement lambdas This PR refactors several lambda expressions that contained a single statement by converting them to concise expression-bodied lambdas. This change improves code readability and consistency across the codebase. - Consider simplifying lambda when its body has a single statement: Multiple occurrences of lambdas wrapping a single call in braces have been replaced with expression-bodied lambdas (e.g., removing `{ }` around `TestOutputHelper.WriteLine(msg)`, simplifying async lambdas in `Should.NotThrow`, and collapsing multi-line eviction callbacks into single-line expressions). These updates remove unnecessary syntax while maintaining the original behavior. > This Autofix was generated by AI. Please review the change before merging. --- .../ApplicationBuilderExtensionsTests.cs | 6 +++--- Shared.EventStore/Aggregate/AggregateMemoryCache.cs | 7 +------ Shared.Tests/ClientProxyBaseTests.cs | 2 +- 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/Shared.EventStore.Tests/ApplicationBuilderExtensionsTests.cs b/Shared.EventStore.Tests/ApplicationBuilderExtensionsTests.cs index 3fe3ed8..4807c02 100644 --- a/Shared.EventStore.Tests/ApplicationBuilderExtensionsTests.cs +++ b/Shared.EventStore.Tests/ApplicationBuilderExtensionsTests.cs @@ -56,7 +56,7 @@ public void ApplicationBuilderExtensions_ConfigureSubscriptions_WorkerListReturn eventHandlerResolvers.Add("Ordered", deh.Object); eventHandlerResolvers.Add("Main", deh.Object); eventHandlerResolvers.Add("Domain", deh.Object); - Action traceHandler = (et, type, msg)=> { TestOutputHelper.WriteLine(msg); }; + Action traceHandler = (et, type, msg) => TestOutputHelper.WriteLine(msg); var result = IApplicationBuilderExtenstions.ConfigureSubscriptions(subscriptionRepository.Object, config, eventStoreConnectionString, eventHandlerResolvers, traceHandler); result.Count.ShouldBe(3); @@ -185,7 +185,7 @@ public void ApplicationBuilderExtensions_ConfigureSubscriptions_MainOnlyWorkers_ String eventStoreConnectionString = "esdb://192.168.0.133:2113?tls=true&tlsVerifyCert=false"; Dictionary eventHandlerResolvers = new(); eventHandlerResolvers.Add("Main", deh.Object); - Action traceHandler = (et, type, msg) => { TestOutputHelper.WriteLine(msg); }; + Action traceHandler = (et, type, msg) => TestOutputHelper.WriteLine(msg); var result = IApplicationBuilderExtenstions.ConfigureSubscriptions(subscriptionRepository.Object, config, eventStoreConnectionString, eventHandlerResolvers, traceHandler); result.Count.ShouldBe(1); @@ -240,7 +240,7 @@ public void ApplicationBuilderExtensions_ConfigureSubscriptions_MainOnlyWorkers_ String eventStoreConnectionString = "esdb://192.168.0.133:2113?tls=true&tlsVerifyCert=false"; Dictionary eventHandlerResolvers = new(); eventHandlerResolvers.Add("Main", deh.Object); - Action traceHandler = (et, type, msg) => { TestOutputHelper.WriteLine(msg); }; + Action traceHandler = (et, type, msg) => TestOutputHelper.WriteLine(msg); var result = IApplicationBuilderExtenstions.ConfigureSubscriptions(subscriptionRepository.Object, config, eventStoreConnectionString, eventHandlerResolvers, traceHandler); result.Count.ShouldBe(2); diff --git a/Shared.EventStore/Aggregate/AggregateMemoryCache.cs b/Shared.EventStore/Aggregate/AggregateMemoryCache.cs index 28fac2c..fd3f848 100644 --- a/Shared.EventStore/Aggregate/AggregateMemoryCache.cs +++ b/Shared.EventStore/Aggregate/AggregateMemoryCache.cs @@ -36,12 +36,7 @@ public void Set(String key, if (!AggregateMemoryCache.CallbackRegistered.TryGetValue(aggregateType, out isRegistered) || !isRegistered) // Double-check locking { // Register a callback to remove the item from our internal tracking - memoryCacheEntryOptions.RegisterPostEvictionCallback((evictedKey, - _, - _, - _) => { - this.KeyTracker.TryRemove(evictedKey.ToString(), out _); - }); + memoryCacheEntryOptions.RegisterPostEvictionCallback((evictedKey, _, _, _) => this.KeyTracker.TryRemove(evictedKey.ToString(), out _)); AggregateMemoryCache.CallbackRegistered[aggregateType] = true; } diff --git a/Shared.Tests/ClientProxyBaseTests.cs b/Shared.Tests/ClientProxyBaseTests.cs index fbac5f8..0ec1374 100644 --- a/Shared.Tests/ClientProxyBaseTests.cs +++ b/Shared.Tests/ClientProxyBaseTests.cs @@ -55,7 +55,7 @@ public async Task ClientProxyBase_HandleResponse_SuccessStatus(HttpStatusCode st HttpResponseMessage response = new(statusCode); response.Content = new StringContent(responseContent); TestClient proxybase = new(new HttpClient()); - Should.NotThrow(async () => { await proxybase.Test_HandleResponse(response, CancellationToken.None); }); + Should.NotThrow(async () => await proxybase.Test_HandleResponse(response, CancellationToken.None)); } [Theory]