refactor: mark fields as readonly #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors several classes by marking fields that are only assigned once as `readonly`. By making these fields immutable, we improve code safety, readability, and adherence to best practices. - Fields initialized only in constructors can be made `readonly`: DeepSource flagged multiple fields—such as `ConfigurationRoot`, `parameters`, `domainEventHandlerResolver`, various counters in `SubscriptionRepository`, `featureTags`, and `featureInfo`—that were only ever set during object construction. We added the `readonly` modifier to each of these, ensuring they cannot be reassigned after initialization and enhancing overall code immutability. > This Autofix was generated by AI. Please review the change before merging.
|
Here's the code health analysis summary for commits Analysis Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors several classes by marking fields that are only assigned once as
readonly. By making these fields immutable, we improve code safety, readability, and adherence to best practices.readonly: DeepSource flagged multiple fields—such asConfigurationRoot,parameters,domainEventHandlerResolver, various counters inSubscriptionRepository,featureTags, andfeatureInfo—that were only ever set during object construction. We added thereadonlymodifier to each of these, ensuring they cannot be reassigned after initialization and enhancing overall code immutability.