Skip to content

Stage 1 of the refactor #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2023
Merged

Stage 1 of the refactor #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ef48c0
Stage 1 of the refactor
StuartFerguson Oct 19, 2023
ae5216b
projection changes
StuartFerguson Oct 22, 2023
a5842af
Fix sonar cloud issue
StuartFerguson Oct 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
159 changes: 50 additions & 109 deletions ...onProcessor.BusinessLogic.Tests/DomainEventHandlers/TransactionDomainEventHandlerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
{
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using BusinessLogic.Manager;
Expand Down Expand Up @@ -69,58 +70,27 @@ public TransactionDomainEventHandlerTests()
this.SettlementAggregateRepository.Object);
}

[Fact]
public async Task TransactionDomainEventHandler_Handle_TransactionHasBeenCompletedEvent_SuccessfulSale_MerchantWithImmediateSettlement_EventIsHandled()
[Theory]
[InlineData(SettlementSchedule.Immediate)]
[InlineData(SettlementSchedule.Weekly)]
[InlineData(SettlementSchedule.Monthly)]
public async Task TransactionDomainEventHandler_Handle_TransactionHasBeenCompletedEvent_SuccessfulSale_EventIsHandled(SettlementSchedule settlementSchedule)
{
TransactionAggregate transactionAggregate = TestData.GetCompletedAuthorisedSaleTransactionAggregate();
this.TransactionAggregateRepository.Setup(t => t.GetLatestVersion(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(TestData.GetCompletedAuthorisedSaleTransactionAggregate);

this.SettlementAggregateRepository.Setup(s => s.GetLatestVersion(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(TestData.GetEmptySettlementAggregate);
.ReturnsAsync(transactionAggregate);

this.FeeCalculationManager.Setup(f => f.CalculateFees(It.IsAny<List<TransactionFeeToCalculate>>(), It.IsAny<Decimal>(), It.IsAny<DateTime>())).Returns(new List<CalculatedFee>
{
TestData.CalculatedFeeMerchantFee(),
TestData.CalculatedFeeServiceProviderFee
TestData.CalculatedFeeMerchantFee(TestData.TransactionFeeId),
TestData.CalculatedFeeServiceProviderFee(TestData.TransactionFeeId2)
});

this.EstateClient.Setup(e => e.GetMerchant(It.IsAny<String>(), It.IsAny<Guid>(), It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(new MerchantResponse
{
SettlementSchedule = SettlementSchedule.Immediate,
});
this.EstateClient.Setup(e => e.GetTransactionFeesForProduct(It.IsAny<String>(),
It.IsAny<Guid>(),
It.IsAny<Guid>(),
It.IsAny<Guid>(),
It.IsAny<Guid>(),
It.IsAny<CancellationToken>())).ReturnsAsync(TestData.ContractProductTransactionFees);

this.SecurityServiceClient.Setup(s => s.GetToken(It.IsAny<String>(), It.IsAny<String>(), It.IsAny<CancellationToken>())).ReturnsAsync(TestData.TokenResponse);

await this.TransactionDomainEventHandler.Handle(TestData.TransactionHasBeenCompletedEvent, CancellationToken.None);
}

[Fact]
public async Task TransactionDomainEventHandler_Handle_TransactionHasBeenCompletedEvent_SuccessfulSale_MerchantWithWeeklySettlement_EventIsHandled()
{
this.TransactionAggregateRepository.Setup(t => t.GetLatestVersion(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(TestData.GetCompletedAuthorisedSaleTransactionAggregate);
SettlementAggregate pendingSettlementAggregate = new SettlementAggregate();
this.SettlementAggregateRepository.Setup(p => p.GetLatestVersion(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(pendingSettlementAggregate);

this.FeeCalculationManager.Setup(f => f.CalculateFees(It.IsAny<List<TransactionFeeToCalculate>>(), It.IsAny<Decimal>(), It.IsAny<DateTime>())).Returns(new List<CalculatedFee>
{
TestData.CalculatedFeeMerchantFee(),
TestData.CalculatedFeeServiceProviderFee
SettlementSchedule = settlementSchedule,
});
var merchant = new MerchantResponse
{
SettlementSchedule = SettlementSchedule.Weekly,
};
this.EstateClient.Setup(e => e.GetMerchant(It.IsAny<String>(), It.IsAny<Guid>(), It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(merchant);
this.EstateClient.Setup(e => e.GetTransactionFeesForProduct(It.IsAny<String>(),
It.IsAny<Guid>(),
It.IsAny<Guid>(),
Expand All @@ -130,75 +100,46 @@ public async Task TransactionDomainEventHandler_Handle_TransactionHasBeenComplet

this.SecurityServiceClient.Setup(s => s.GetToken(It.IsAny<String>(), It.IsAny<String>(), It.IsAny<CancellationToken>())).ReturnsAsync(TestData.TokenResponse);


await this.TransactionDomainEventHandler.Handle(TestData.TransactionHasBeenCompletedEvent, CancellationToken.None);

// TODO: way of verifying needed
//this.TransactionAggregateManager.Verify(t => t.AddFee(It.IsAny<Guid>(),
// It.IsAny<Guid>(),
// It.IsAny<CalculatedFee>(),
// It.IsAny<CancellationToken>()), Times.Once);
this.SettlementAggregateRepository.Verify(p => p.GetLatestVersion(It.IsAny<Guid>(), It.IsAny<CancellationToken>()),Times.Once);
this.SettlementAggregateRepository.Verify(p => p.SaveChanges(It.IsAny<SettlementAggregate>(), It.IsAny<CancellationToken>()), Times.Once);
pendingSettlementAggregate.GetNumberOfFeesPendingSettlement().ShouldBe(1);
pendingSettlementAggregate.GetNumberOfFeesSettled().ShouldBe(0);
}

[Fact]
public async Task TransactionDomainEventHandler_Handle_TransactionHasBeenCompletedEvent_SuccessfulSale_MerchantWithMonthlySettlement_EventIsHandled()
{
this.TransactionAggregateRepository.Setup(t => t.GetLatestVersion(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(TestData.GetCompletedAuthorisedSaleTransactionAggregate);
SettlementAggregate pendingSettlementAggregate = new SettlementAggregate();
this.SettlementAggregateRepository.Setup(p => p.GetLatestVersion(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(pendingSettlementAggregate);

this.FeeCalculationManager.Setup(f => f.CalculateFees(It.IsAny<List<TransactionFeeToCalculate>>(), It.IsAny<Decimal>(), It.IsAny<DateTime>())).Returns(new List<CalculatedFee>
{
TestData.CalculatedFeeMerchantFee(),
TestData.CalculatedFeeServiceProviderFee
});
var merchant = new MerchantResponse
{
SettlementSchedule = SettlementSchedule.Monthly,
CalculatedFee merchantFee = transactionAggregate.GetFees().SingleOrDefault(f => f.FeeId == TestData.TransactionFeeId);
merchantFee.ShouldNotBeNull();
if (settlementSchedule == SettlementSchedule.Immediate){
merchantFee.IsSettled.ShouldBeTrue();
}
else{
merchantFee.IsSettled.ShouldBeFalse();
}

var expectedSettlementDate = settlementSchedule switch{
SettlementSchedule.Monthly => transactionAggregate.TransactionDateTime.Date.AddMonths(1),
SettlementSchedule.Weekly => transactionAggregate.TransactionDateTime.Date.AddDays(7),
_ => transactionAggregate.TransactionDateTime.Date
};
this.EstateClient.Setup(e => e.GetMerchant(It.IsAny<String>(), It.IsAny<Guid>(), It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(merchant);
this.EstateClient.Setup(e => e.GetTransactionFeesForProduct(It.IsAny<String>(),
It.IsAny<Guid>(),
It.IsAny<Guid>(),
It.IsAny<Guid>(),
It.IsAny<Guid>(),
It.IsAny<CancellationToken>())).ReturnsAsync(TestData.ContractProductTransactionFees);

this.SecurityServiceClient.Setup(s => s.GetToken(It.IsAny<String>(), It.IsAny<String>(), It.IsAny<CancellationToken>())).ReturnsAsync(TestData.TokenResponse);


await this.TransactionDomainEventHandler.Handle(TestData.TransactionHasBeenCompletedEvent, CancellationToken.None);

this.SettlementAggregateRepository.Verify(p => p.GetLatestVersion(It.IsAny<Guid>(), It.IsAny<CancellationToken>()), Times.Once);
this.SettlementAggregateRepository.Verify(p => p.SaveChanges(It.IsAny<SettlementAggregate>(), It.IsAny<CancellationToken>()), Times.Once);
pendingSettlementAggregate.GetNumberOfFeesPendingSettlement().ShouldBe(1);
pendingSettlementAggregate.GetNumberOfFeesSettled().ShouldBe(0);
merchantFee.SettlementDueDate.ShouldBe(expectedSettlementDate);

CalculatedFee nonMerchantFee = transactionAggregate.GetFees().SingleOrDefault(f => f.FeeId == TestData.TransactionFeeId2);
nonMerchantFee.ShouldNotBeNull();
}

[Fact]
public async Task TransactionDomainEventHandler_Handle_TransactionHasBeenCompletedEvent_SuccessfulSale_MerchantWithNotSetSettlementSchedule_ErrorThrown()
{
TransactionAggregate transactionAggregate = TestData.GetCompletedAuthorisedSaleTransactionAggregate();
this.TransactionAggregateRepository.Setup(t => t.GetLatestVersion(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(TestData.GetCompletedAuthorisedSaleTransactionAggregate);
.ReturnsAsync(transactionAggregate);

this.FeeCalculationManager.Setup(f => f.CalculateFees(It.IsAny<List<TransactionFeeToCalculate>>(), It.IsAny<Decimal>(), It.IsAny<DateTime>())).Returns(new List<CalculatedFee>
{
TestData.CalculatedFeeMerchantFee(),
TestData.CalculatedFeeServiceProviderFee
});
{
TestData.CalculatedFeeMerchantFee(TestData.TransactionFeeId),
TestData.CalculatedFeeServiceProviderFee(TestData.TransactionFeeId2)
});

this.EstateClient.Setup(e => e.GetMerchant(It.IsAny<String>(), It.IsAny<Guid>(), It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(new MerchantResponse
{
SettlementSchedule = SettlementSchedule.NotSet,
});
{
SettlementSchedule = SettlementSchedule.NotSet,
});
this.EstateClient.Setup(e => e.GetTransactionFeesForProduct(It.IsAny<String>(),
It.IsAny<Guid>(),
It.IsAny<Guid>(),
Expand All @@ -207,7 +148,7 @@ public async Task TransactionDomainEventHandler_Handle_TransactionHasBeenComplet
It.IsAny<CancellationToken>())).ReturnsAsync(TestData.ContractProductTransactionFees);

this.SecurityServiceClient.Setup(s => s.GetToken(It.IsAny<String>(), It.IsAny<String>(), It.IsAny<CancellationToken>())).ReturnsAsync(TestData.TokenResponse);

Should.Throw<NotSupportedException>(async () =>
{
await this.TransactionDomainEventHandler.Handle(TestData.TransactionHasBeenCompletedEvent, CancellationToken.None);
Expand Down Expand Up @@ -273,19 +214,19 @@ public async Task TransactionDomainEventHandler_Handle_CustomerEmailReceiptResen
}


[Fact]
public async Task TransactionDomainEventHandler_Handle_MerchantFeeAddedToTransactionEvent_EventIsHandled()
{
this.SettlementAggregateRepository.Setup(s => s.GetLatestVersion(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(TestData.GetSettlementAggregateWithPendingMerchantFees(1));
//[Fact]
//public async Task TransactionDomainEventHandler_Handle_MerchantFeeAddedToTransactionEvent_EventIsHandled()
//{
// this.SettlementAggregateRepository.Setup(s => s.GetLatestVersion(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
// .ReturnsAsync(TestData.GetSettlementAggregateWithPendingMerchantFees(1));

await this.TransactionDomainEventHandler.Handle(TestData.MerchantFeeAddedToTransactionEvent(TestData.TransactionFeeSettlementDueDate), CancellationToken.None);
}
// await this.TransactionDomainEventHandler.Handle(TestData.SettledMerchantFeeAddedToTransactionEvent(TestData.TransactionFeeSettlementDueDate), CancellationToken.None);
//}

[Fact]
public async Task TransactionDomainEventHandler_Handle_MerchantFeeAddedToTransactionEvent_EventHasNoSettlementDueDate_EventIsHandled()
{
await this.TransactionDomainEventHandler.Handle(TestData.MerchantFeeAddedToTransactionEvent(DateTime.MinValue), CancellationToken.None);
}
//[Fact]
//public async Task TransactionDomainEventHandler_Handle_MerchantFeeAddedToTransactionEvent_EventHasNoSettlementDueDate_EventIsHandled()
//{
// await this.TransactionDomainEventHandler.Handle(TestData.SettledMerchantFeeAddedToTransactionEvent(DateTime.MinValue), CancellationToken.None);
//}
}
}
2 changes: 1 addition & 1 deletion TransactionProcessor.BusinessLogic.Tests/TransactionProcessor.BusinessLogic.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<DebugType>None</DebugType>
<DebugType>Full</DebugType>
<IsPackable>false</IsPackable>
</PropertyGroup>

Expand Down
Loading