Update packages and refactor response handling #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated package references for `TransactionProcessor.Client`, `TransactionProcessor.IntegrationTesting.Helpers`, `SecurityService.Client`, and `Shared`. - Refactored test cases in `TransactionProcessorACLApplicationServiceTests.cs` to implement a new result pattern for response handling. - Modified `TransactionProcessorACL.BusinessLogic.Services` to return results using a new `Result<T>` type, enhancing error management. - Introduced `Merchants.feature` for defining merchant-related scenarios, including roles, API scopes, and client setups. - Enhanced `ACLSteps` with new methods for retrieving merchant and contract information using the updated result pattern. - Updated `SharedSteps` to align with new token retrieval and storage methods. - Adjusted `MerchantController` and `TransactionController` to utilize new result types and improve logging. - Added records and methods in `ReqnrollExtensions` for converting data tables to expected response types in tests. - Improved overall error handling and logging for better operational insights.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransactionProcessor.Client,TransactionProcessor.IntegrationTesting.Helpers,SecurityService.Client, andShared.TransactionProcessorACLApplicationServiceTests.csto implement a new result pattern for response handling.TransactionProcessorACL.BusinessLogic.Servicesto return results using a newResult<T>type, enhancing error management.Merchants.featurefor defining merchant-related scenarios, including roles, API scopes, and client setups.ACLStepswith new methods for retrieving merchant and contract information using the updated result pattern.SharedStepsto align with new token retrieval and storage methods.MerchantControllerandTransactionControllerto utilize new result types and improve logging.ReqnrollExtensionsfor converting data tables to expected response types in tests.Closes #322