Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overall rankings show "TBD" #91

Open
Thing342 opened this issue Jul 7, 2016 · 10 comments

Comments

Projects
None yet
4 participants
@Thing342
Copy link
Contributor

commented Jul 7, 2016

The rankings on the main user page currently show "TBD" instead of an actual ranking.This may require some work over on the TravelMapping/DataProcessing front.

@Thing342 Thing342 assigned Thing342 and unassigned Thing342 Jul 7, 2016

@Thing342

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2016

FYI: doing this only from the web side results in massive queries that take awhile to process. I think we should consider some sort of rankings table in the database.

@ssoworld

This comment has been minimized.

Copy link

commented Jul 10, 2016

I should not be. I would have it done during the update since the pages should just fetch the info and that’s it.

From: Wes Jordan [mailto:notifications@github.com]
Sent: Sunday, July 10, 2016 10:02 AM
To: TravelMapping/Web Web@noreply.github.com
Subject: Re: [TravelMapping/Web] Overall rankings show "TBD" (#91)

FYI: doing this only from the web side results in massive queries that take awhile to process.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/91#issuecomment-231593466, or mute the threadhttps://github.com/notifications/unsubscribe/AGO3Uh_GQ7dtWb__sdmNfhSL-OR2UsuRks5qUQl8gaJpZM4JHiNi.

@jteresco

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2016

This kind of information should be in the DB. I'll plan to add it next time I'm in the code. What kinds of rankings will we want that would be displayed enough that it's worth computing in the site update and storing in the DB, what what might we want that won't be displayed often (I'm thinking something like rankings of travels on an individual route) that would be OK to compute even if it's a little more expensive of a query?

@jteresco jteresco self-assigned this Jul 11, 2016

@Thing342

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2016

I was thinking of doing three tables: an overall stats table, with totals for routes driven, clinched, and miles driven for each user, along with a percentage and site-wide ranking for each. Then, you could have a userStatsByRegion (or an update to clinchedMileageByRegion) and userStatsBySystem tables that would show similar stats by system and by region.

I think we should move this discussion over to DataProcessing.

@yakra

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

@yakra

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2019

Rankings implemented on /user/index2.php on lab2.

@yakra yakra self-assigned this Jul 13, 2019

@yakra

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2019

@Thing342 wrote:

FYI: doing this only from the web side results in massive queries that take awhile to process. I think we should consider some sort of rankings table in the database.

I see what you mean. The query I'm using takes 1.3s, compared with 0.16s for the next slowest I saw, with everything else < 0.1s.
Double that, for one active & one active+preview query, and ouch.

I'll leave this on lab2, and maybe even make a commit to a separate branch, but not open a pull request just yet.
Eventually I may look into extra tables that can be created during the site update process to speed up the queries.

@jteresco

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2019

I obviously haven't added the ranking info to the DB even though I mentioned I would 3 years ago now. But it definitely seems that that's the way to go with this.

@yakra

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

routes by region
routes by region + system

connected routes by system

active / active+preview
traveled / clinched

@jteresco

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

Having these in the DB would probably make some of those "top 25" list type things for #66 easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.