From 6e890c8ec73e0c4307e6e012127a3ae1b5761985 Mon Sep 17 00:00:00 2001 From: Badal Chhipa Date: Thu, 15 May 2025 16:44:52 +0530 Subject: [PATCH 1/2] WP-204 functionality migrated from slide to slides component --- src/slider/tp-slider-slide.ts | 41 ---------------------------------- src/slider/tp-slider-slides.ts | 41 ++++++++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+), 41 deletions(-) diff --git a/src/slider/tp-slider-slide.ts b/src/slider/tp-slider-slide.ts index d1bfd63..96df59b 100644 --- a/src/slider/tp-slider-slide.ts +++ b/src/slider/tp-slider-slide.ts @@ -1,46 +1,5 @@ -/** - * Internal dependencies. - */ -import { TPSliderElement } from './tp-slider'; - /** * TP Slider Slide. */ export class TPSliderSlideElement extends HTMLElement { - /** - * Constructor. - */ - constructor() { - // Initialize parent. - super(); - - // Resize observer. - if ( 'ResizeObserver' in window ) { - new ResizeObserver( this.handleHeightChange.bind( this ) ).observe( this ); - } - } - - /** - * Handle slide height change. - */ - protected handleHeightChange(): void { - // Get the parent tp-slider element. - const slider: TPSliderElement | null = this.closest( 'tp-slider' ); - - // Bail if not found. - if ( ! slider ) { - // Bail early if not found. - return; - } - - /** - * Yield to main thread to avoid observation errors. - * - * @see https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserver#observation_errors - */ - setTimeout( (): void => { - // Handle resize. - slider.handleResize(); - }, 0 ); - } } diff --git a/src/slider/tp-slider-slides.ts b/src/slider/tp-slider-slides.ts index 3f8c6d5..9f899e5 100644 --- a/src/slider/tp-slider-slides.ts +++ b/src/slider/tp-slider-slides.ts @@ -1,5 +1,46 @@ +/** + * Internal dependencies. + */ +import { TPSliderElement } from './tp-slider'; + /** * TP Slider Slides. */ export class TPSliderSlidesElement extends HTMLElement { + /** + * Constructor. + */ + constructor() { + // Initialize parent. + super(); + + // Resize observer. + if ( 'ResizeObserver' in window ) { + new ResizeObserver( this.handleHeightChange.bind( this ) ).observe( this ); + } + } + + /** + * Handle slide height change. + */ + protected handleHeightChange(): void { + // Get the parent tp-slider element. + const slider: TPSliderElement | null = this.closest( 'tp-slider' ); + + // Bail if not found. + if ( ! slider ) { + // Bail early if not found. + return; + } + + /** + * Yield to main thread to avoid observation errors. + * + * @see https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserver#observation_errors + */ + setTimeout( (): void => { + // Handle resize. + slider.handleResize(); + }, 0 ); + } } From 817d19c44f84bbf420ba59c6879c5f9b653091e0 Mon Sep 17 00:00:00 2001 From: Badal Chhipa Date: Thu, 15 May 2025 17:00:04 +0530 Subject: [PATCH 2/2] WP-204 comment updated --- src/slider/tp-slider.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/slider/tp-slider.ts b/src/slider/tp-slider.ts index 0923d4b..a5fa1ac 100644 --- a/src/slider/tp-slider.ts +++ b/src/slider/tp-slider.ts @@ -57,7 +57,7 @@ export class TPSliderElement extends HTMLElement { // Event listeners. if ( ! ( 'ResizeObserver' in window ) ) { /** - * We set the resize observer in `tp-slider-slide` + * We set the resize observer in `tp-slider-slides` * because These are just fallbacks for browsers that don't support ResizeObserver. */