Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create universal binaries for Apple Silicon #4145

Open
konsuko opened this issue Nov 7, 2022 · 7 comments
Open

Create universal binaries for Apple Silicon #4145

konsuko opened this issue Nov 7, 2022 · 7 comments
Labels
Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality. Type:Maintenance Non-functional changes that improve code quality or the build system
Milestone

Comments

@konsuko
Copy link

konsuko commented Nov 7, 2022

I stumbled upon #3966 and also thought that it would be great if TrenchBroom was compiled into a universal/Apple Silicon (ARM64) binary.

I am using TrenchBroom on my 2021 MacBook Pro (M1 Max) and currently, the build does run - however, since it's being translated through the Rosetta layer, it runs quite slowly and is not super pleasant to use.

Would be awesome! :)

@konsuko konsuko mentioned this issue Nov 7, 2022
@kduske kduske changed the title Apple Silicon (ARM64) support for TrenchBroom possible? Create universal binaries for Apple Silicon Nov 7, 2022
@kduske kduske added Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality. Type:Maintenance Non-functional changes that improve code quality or the build system labels Nov 17, 2022
@kduske
Copy link
Collaborator

kduske commented Nov 17, 2022

vcpkg does not yet support universal binaries: microsoft/vcpkg#19454

Alternatively, we can produce two separate binaries, one for x86-64 and one for arm64. I think I'll do that for now.

@kduske kduske added this to the 2022.3 milestone Nov 17, 2022
@kduske
Copy link
Collaborator

kduske commented Nov 19, 2022

Creating a separate binary for arm64 is also difficult as long as github doesn't provide arm64 runners. Cross compiling from x84 for arm64 will also be a lot of effort. We can revisit this once either vcpk supports universal binaries better or when github adds a native arm64 runner for macOS. Feel free to ping me every couple of weeks ;-)

@kduske kduske removed this from the 2022.3 milestone Dec 31, 2022
@photex
Copy link

photex commented May 8, 2023

Seems like this is now in Public Beta: github/roadmap#528

@kduske kduske added this to the 2023.2 milestone May 8, 2023
@kduske
Copy link
Collaborator

kduske commented May 8, 2023

I'll take another look. Maybe as a first step I can offer both x86 and Apple Silicon builds, and then merge them into a fat binary later.

@kduske
Copy link
Collaborator

kduske commented May 8, 2023

Unfortunately I cannot find any info on how to use these new runners.

@photex
Copy link

photex commented May 8, 2023

Well, thanks for taking a look in any case. :)

@kduske
Copy link
Collaborator

kduske commented May 8, 2023

Maybe they'll publish instructions soon. I'll keep checking back.

@kduske kduske modified the milestones: 2023.2, Next Sep 17, 2023
@kduske kduske modified the milestones: 2024.2, Next Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality. Type:Maintenance Non-functional changes that improve code quality or the build system
Projects
None yet
Development

No branches or pull requests

3 participants