Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1921: Path::extension crash when typing a path in the game engine profile dialog #1935

Merged
merged 3 commits into from Dec 30, 2017
Merged

1921: Path::extension crash when typing a path in the game engine profile dialog #1935

merged 3 commits into from Dec 30, 2017

Conversation

kduske
Copy link
Collaborator

@kduske kduske commented Dec 29, 2017

Closes #1921.

@kduske kduske self-assigned this Dec 29, 2017
@kduske kduske requested a review from ericwa December 29, 2017 13:43
ericwa
ericwa approved these changes Dec 29, 2017
View reviewed changes
Copy link
Collaborator

@ericwa ericwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test and fix for Path("\\").canMakeRelative(Path("\\")) which was crashing on Windows.

@kduske kduske merged commit a8ba59b into release/v2.0.0 Dec 30, 2017
@kduske kduske deleted the feature/1921 branch December 30, 2017 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericwa ericwa ericwa approved these changes

Assignees

@kduske kduske

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kduske @ericwa