Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken tests for non-Fortran and CMake 3.21 builds (#363) #392

Merged
merged 8 commits into from
Jul 20, 2021
Merged

Fix broken tests for non-Fortran and CMake 3.21 builds (#363) #392

merged 8 commits into from
Jul 20, 2021

Commits on Jul 20, 2021

  1. Set TriBITS_SHOW_TEST_START_END_DATE_TIME=ON (TriBITSPub#363) 

    Nice to set just for completeness.  Not really related to TriBITSPub#363 but I did this
while workoing on that.

I also moved -DDART_TESTING_TIMEOUT=60 up in the argument list because
-DCTEST_PARALLEL_LEVEL=16 these kind of go together.
    @bartlettroscoe
    bartlettroscoe committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    f72490d View commit details
    Browse the repository at this point in the history

  2. Adjust for MixedLang disable with no Fortran (TriBITSPub#363) 

    This is one of the test cases being enabled for the GitHub Actions builds for
TriBITS in TriBITSPub#363.  Just reproducing locally and fixing.
    @bartlettroscoe
    bartlettroscoe committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    d2ddbaa View commit details
    Browse the repository at this point in the history

  3. Disable a bunch of tests that fail if there is no Fortran (TriBITSPub… 

    …#363)

All of these tests fail to configure because we don't pass down the
ENABLE_Fortran configure option to the inner CMake configure and if a working
Fortran compiler does not even exist on the system, then these tests fail in
the configure of the inner project.  While I could pass down this info
somehow, a lot of these tests would fail anyway without some adjustment.

We don't need every test to run if we don't have a Fortran compiler.  We just
don't want the TriBITS test suite to have a bunch of failing tests if a user
clones the repo and tries to build and run the TriBITS test suite on a machine
with no Fortran compiler (like a Mac or a Windows machine).
    @bartlettroscoe
    bartlettroscoe committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    1f397e0 View commit details
    Browse the repository at this point in the history

  4. Make WORLD_READABLE=TRUE set same perms as GROUP_WRITABLE (TriBITSPub… 

    …#314, TriBITSPub#363)

With CMake 3.21, with umask=g-rwx,o-rwx you need explicitly set g+rX for the
group permissions to be r-X when setting
<Project>_MAKE_INSTALL_WORLD_READABLE=ON which was doing just:

  chmod -R o+rX <dir>

Now, when you ony set <Project>_MAKE_INSTALL_WORLD_READABLE=ON, you get:

  chmod -R g+rX,o+rX <dir>

For some reason, with older verisons of CMake, it was setting the default
group permission as 'r-x' when it should not have been.  I ran exactly the
same build on the same machine (crf450) with the same env except I used CMake
3.21.0 vs. 3.17.1 and I had to make this change to get the same permissions on
the base install directory.  Strange.
    @bartlettroscoe
    bartlettroscoe committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    d01b667 View commit details
    Browse the repository at this point in the history

  5. Adjust for different CMake 3.21 error output (TriBITSPub#363) 

    For CMake 3.21 it prints a "could not find requested file" instead of "could
not find load file".  The latter was obviously a typo so it is good they fixed
it but I had this checked for in a test.  Now the test passes in both cases.
    @bartlettroscoe
    bartlettroscoe committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    aae3bed View commit details
    Browse the repository at this point in the history

  6. Adjust for different number of install errors reported by CMake 3.21 (T… 

    …riBITSPub#363)

Seems CMake 3.21 reports two install failures instead of just one as older
versions of CMake reported.  I guess it depends how you count.  Either way,
the number is greater than 0 so that is what matters really.
    @bartlettroscoe
    bartlettroscoe committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    65ee4e6 View commit details
    Browse the repository at this point in the history

  7. Adjust for move of rules.ninja in CMake 3.18 (TriBITSPub#363) 

    I searched the git logs and it looks like this change was pulled in the CMake
3.18.0 release.  But I only tested this with CMake 3.17.1 and 3.21.0.
    @bartlettroscoe
    bartlettroscoe committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    36af217 View commit details
    Browse the repository at this point in the history

  8. Update min version of CMake from 2.6 to 2.17 of old Fortran name mana… 

    …ging code (TriBITSPub#363)

With CMake 3.21, this was generating a deprecated warning.  With the rest of
TriBITS requiring CMake 3.17 it seems bad to have code that has min version
going back to 2.6.  However, this might change the behaivor of this code so
that is a warning.  (Fingers crossed.)
    @bartlettroscoe
    bartlettroscoe committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    3024a80 View commit details
    Browse the repository at this point in the history