New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI elements for the tagging system #6453
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devos50
force-pushed
the
tags_gui
branch
2 times, most recently
from
October 15, 2021 14:16
49f201d
to
b52cb64
Compare
devos50
changed the title
[DO NOT MERGE] GUI elements for tagging system
GUI elements for tagging system
Oct 15, 2021
devos50
requested review from
ichorid and
drew2a
and removed request for
a team
October 15, 2021 14:23
ichorid
previously approved these changes
Oct 15, 2021
devos50
changed the title
GUI elements for tagging system
GUI elements for the tagging system
Oct 15, 2021
Added GUI setting to disable tags Fixed fetching tag GUI settings Closing edit tags dialog on ESC press
drew2a
previously approved these changes
Oct 18, 2021
Kudos, SonarCloud Quality Gate passed! |
drew2a
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the GUI elements related to the tagging system, including a dialog to add/remove tags, and changes to the table views.
There are some parts of the GUI code that remain uncovered by the tests. These parts are mostly related to mouse/timer events since they are very hard to test automatically (e.g., on Mac they require accessibility permissions). I tried to come up with a clean way to work around this (for example, by calling
mousePressEvent
directly), but this would not result in any clean code. Instead, I have tested the uncovered code manually. If you believe that there is code that absolutely needs to be covered, please let me know.Design decisions behind the GUI elements