Skip to content

Conversation

@dangreen
Copy link
Member

@dangreen dangreen commented Jul 6, 2025

No description provided.

@dangreen dangreen force-pushed the feat-stylelint-config branch from cf4cff7 to 189b732 Compare July 6, 2025 18:48
@dangreen dangreen force-pushed the feat-stylelint-config branch from 189b732 to a439e95 Compare July 6, 2025 20:13
@dangreen dangreen marked this pull request as ready for review July 6, 2025 20:13
@dangreen dangreen requested a review from Copilot July 6, 2025 20:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new Stylelint configuration package with multiple subconfigs for common, SCSS, strict, and logical rules, along with matchers and concentric CSS ordering.

  • Added a strict subconfig enforcing stricter naming and declaration rules.
  • Added an SCSS-specific config with custom syntax and overrides based on common rules.
  • Defined regex matchers and the concentric-css property ordering; updated package exports, metadata, and documentation.

Reviewed Changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/stylelint-config/src/subconfigs/strict.js New strict rules and custom matchers
packages/stylelint-config/src/subconfigs/scss.js SCSS-specific config with syntax and rule overrides
packages/stylelint-config/src/subconfigs/matchers.js Regex matchers for naming conventions
packages/stylelint-config/src/subconfigs/common.js Core shared config, plugins, and property ordering
packages/stylelint-config/src/subconfigs/logical.js Logical CSS properties plugin config
packages/stylelint-config/src/subconfigs/concentric-css.js Concentric CSS property-order groups
packages/stylelint-config/src/*.js Entry-point exports for each subconfig
packages/stylelint-config/package.json Package metadata, dependencies, and publish settings
packages/stylelint-config/eslint.config.js ESLint overrides for the config package
packages/stylelint-config/README.md Documentation and usage examples
package.json (root) Updated clear script to match new package layout
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)

packages/stylelint-config/src/subconfigs/matchers.js:1

  • Consider adding unit tests for these regex matchers to ensure they correctly accept and reject expected naming patterns, improving confidence when upgrading or refactoring.
/**

plugins: ['stylelint-declaration-strict-value', 'stylelint-plugin-a11y'],
rules: {
'scale-unlimited/declaration-strict-value': [
['font-family', '/color([^A-Z]|$)/'],
Copy link

Copilot AI Jul 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex is provided as a string literal. You should use a RegExp literal (without quotes), e.g. [/color([^A-Z]|$)/], so the rule correctly interprets it as a regex.

Suggested change
['font-family', '/color([^A-Z]|$)/'],
['font-family', /color([^A-Z]|$)/],

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dangreen dangreen merged commit a3437f3 into main Jul 6, 2025
6 checks passed
@dangreen dangreen deleted the feat-stylelint-config branch July 6, 2025 20:21
@github-actions github-actions bot mentioned this pull request Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants