Permalink
Browse files

Core/Group: Add sanity checks to CMSG_LOOT_METHOD's handler

If lootMethod or lootThreshold is invalid, portrait menus become unusable to the entire raid.
  • Loading branch information...
1 parent aaa4b3a commit 916d84bdca52d04b8a808cc3e519ddc1ee3c2ffe Dehravor committed Feb 9, 2014
Showing with 6 additions and 0 deletions.
  1. +6 −0 src/server/game/Handlers/GroupHandler.cpp
@@ -425,6 +425,12 @@ void WorldSession::HandleLootMethodOpcode(WorldPacket& recvData)
/** error handling **/
if (!group->IsLeader(GetPlayer()->GetGUID()))
return;
+
+ if (lootMethod > NEED_BEFORE_GREED)
+ return;
+
+ if (lootThreshold < ITEM_QUALITY_UNCOMMON || lootThreshold > ITEM_QUALITY_ARTIFACT)
+ return;
/********************/
// everything's fine, do it

0 comments on commit 916d84b

Please sign in to comment.