Skip to content
Browse files

Core/Battleground/SOTA: Initialize uninitialized variables.

Fixes:

==8111== Conditional jump or move depends on uninitialised value(s)
==8111==    at 0x12B542C: BattlegroundSA::FillInitialWorldStates(WorldPacket&) (BattlegroundSA.cpp:421)
==8111==    by 0xF93CD9: Player::SendInitWorldStates(unsigned int, unsigned int) (Player.cpp:9664)'

And similar.
  • Loading branch information...
1 parent 91228d2 commit cc0448a017a418446c4c28cdcc2d64940c7e9ecf @Machiavell1 Machiavell1 committed Mar 28, 2012
Showing with 5 additions and 0 deletions.
  1. +5 −0 src/server/game/Battlegrounds/Zones/BattlegroundSA.cpp
View
5 src/server/game/Battlegrounds/Zones/BattlegroundSA.cpp
@@ -37,6 +37,11 @@ BattlegroundSA::BattlegroundSA()
SignaledRoundTwo = false;
SignaledRoundTwoHalfMin = false;
InitSecondRound = false;
+
+ //! This is here to prevent an uninitialised variable warning
+ //! The warning only occurs when SetUpBattleGround fails though.
+ //! In the future this function should be called BEFORE sending initial worldstates.
+ memset(&GraveyardStatus, 0, sizeof(GraveyardStatus));
}
BattlegroundSA::~BattlegroundSA()

1 comment on commit cc0448a

@Vasago
Vasago commented on cc0448a Mar 28, 2012

Wow thank you for these memory leaks fixed it is nice to see somebody care about it :)

How is movements problems going? Need any help?

Can you look also at this crash? Happened after recent changes - crash immediatelly after server starts http://paste2.org/p/1956052

Is thre any way how to PM some people in Github? It seems they emoved this option ...

Please sign in to comment.
Something went wrong with that request. Please try again.