From d0e34a9bed23aaf35c4c7e8775d04cef477b47ee Mon Sep 17 00:00:00 2001 From: Mykhailo Redko Date: Wed, 24 Jan 2024 22:09:01 +0200 Subject: [PATCH] Core/PacketIO: Implemented CMSG_BUSY_TRADE and CMSG_IGNORE_TRADE (#29570) Closes #29308 (cherry picked from commit 420cbd7396ca59497328d372ed028d976f23b150) # Conflicts: # src/server/game/Handlers/TradeHandler.cpp --- src/server/game/Entities/Player/Player.cpp | 7 +++---- src/server/game/Entities/Player/Player.h | 2 +- src/server/game/Handlers/TradeHandler.cpp | 13 ++++--------- src/server/game/Server/WorldSession.h | 2 +- 4 files changed, 9 insertions(+), 15 deletions(-) diff --git a/src/server/game/Entities/Player/Player.cpp b/src/server/game/Entities/Player/Player.cpp index 2f08e55e074df..158621ebad3e8 100644 --- a/src/server/game/Entities/Player/Player.cpp +++ b/src/server/game/Entities/Player/Player.cpp @@ -12851,17 +12851,16 @@ bool Player::IsUsingTwoHandedWeaponInOneHand() const return true; } -void Player::TradeCancel(bool sendback) +void Player::TradeCancel(bool sendback, TradeStatus status /*= TRADE_STATUS_TRADE_CANCELED*/) { if (m_trade) { Player* trader = m_trade->GetTrader(); - // send yellow "Trade canceled" message to both traders if (sendback) - GetSession()->SendCancelTrade(); + GetSession()->SendCancelTrade(status); - trader->GetSession()->SendCancelTrade(); + trader->GetSession()->SendCancelTrade(status); // cleanup delete m_trade; diff --git a/src/server/game/Entities/Player/Player.h b/src/server/game/Entities/Player/Player.h index 73b4f32ea04fa..56e401644f535 100644 --- a/src/server/game/Entities/Player/Player.h +++ b/src/server/game/Entities/Player/Player.h @@ -1447,7 +1447,7 @@ class TC_GAME_API Player final : public Unit, public GridObject Player* GetTrader() const; TradeData* GetTradeData() const { return m_trade; } - void TradeCancel(bool sendback); + void TradeCancel(bool sendback, TradeStatus status = TRADE_STATUS_TRADE_CANCELED); CinematicMgr* GetCinematicMgr() const { return _cinematicMgr.get(); } diff --git a/src/server/game/Handlers/TradeHandler.cpp b/src/server/game/Handlers/TradeHandler.cpp index 62a2c74a2baca..85c49b6f46ff7 100644 --- a/src/server/game/Handlers/TradeHandler.cpp +++ b/src/server/game/Handlers/TradeHandler.cpp @@ -42,10 +42,12 @@ void WorldSession::SendTradeStatus(WorldPackets::Trade::TradeStatus& info) void WorldSession::HandleIgnoreTradeOpcode(WorldPackets::Trade::IgnoreTrade& /*ignoreTrade*/) { + _player->TradeCancel(true, TRADE_STATUS_IGNORE_YOU); } void WorldSession::HandleBusyTradeOpcode(WorldPackets::Trade::BusyTrade& /*busyTrade*/) { + _player->TradeCancel(true, TRADE_STATUS_BUSY); } void WorldSession::SendUpdateTrade(bool trader_data /*= true*/) @@ -559,13 +561,13 @@ void WorldSession::HandleBeginTradeOpcode(WorldPackets::Trade::BeginTrade& /*beg SendTradeStatus(info); } -void WorldSession::SendCancelTrade() +void WorldSession::SendCancelTrade(TradeStatus status) { if (PlayerRecentlyLoggedOut() || PlayerLogout()) return; WorldPackets::Trade::TradeStatus info; - info.Status = TRADE_STATUS_CANCELLED; + info.Status = status; SendTradeStatus(info); } @@ -661,13 +663,6 @@ void WorldSession::HandleInitiateTradeOpcode(WorldPackets::Trade::InitiateTrade& return; } - if (pOther->GetSocial()->HasIgnore(GetPlayer()->GetGUID(), GetPlayer()->GetSession()->GetAccountGUID())) - { - info.Status = TRADE_STATUS_PLAYER_IGNORED; - SendTradeStatus(info); - return; - } - if ((pOther->GetTeam() != _player->GetTeam() || pOther->HasPlayerFlagEx(PLAYER_FLAGS_EX_MERCENARY_MODE) || _player->HasPlayerFlagEx(PLAYER_FLAGS_EX_MERCENARY_MODE)) && diff --git a/src/server/game/Server/WorldSession.h b/src/server/game/Server/WorldSession.h index 4d98e0380ce92..dd939b7d89b9e 100644 --- a/src/server/game/Server/WorldSession.h +++ b/src/server/game/Server/WorldSession.h @@ -1046,7 +1046,7 @@ class TC_GAME_API WorldSession void SendTradeStatus(WorldPackets::Trade::TradeStatus& status); void SendUpdateTrade(bool trader_data = true); - void SendCancelTrade(); + void SendCancelTrade(TradeStatus status); void SendPetitionQueryOpcode(ObjectGuid petitionguid);