Skip to content
Branch: 3.3.5-battlegr…
Commits on Sep 4, 2016
  1. Fix siege engine!

    ariel- committed Sep 4, 2016
Commits on Sep 3, 2016
  1. Initial work on Siege Engine, also some sql import fixes

    ariel- committed Sep 3, 2016
  2. Magic typedef

    ariel- committed Aug 26, 2016
  3. [WiP] Core/PvP: Extensive cleanup, bug-fixing and optimization of Bat…

    ariel- committed Aug 18, 2016
    …tleground scripts:
    - Standards: Moved all statics to cpps where they belong.
    - Cleanups: NULL -> nullptr, moved #defines to constants/enums
    - Added a helper struct for handling spawns easily. Rewrote spawns using it.
    - Moved spawn containers to private scope of Battleground (idea taken from boss states array in InstanceScripts)
    - Remove unused teamId parameter from Battleground::SpawnCreature
    - Prevent Battleground::RelocateDeadPlayers creating new entries on map.
    - Make AddObject return a GameObject pointer instead of a bool (just like its AddCreature sibling)
    - Corrected and added proper GO rotation to spawns
    - De-hardcode buff entries for Battlegrounds, each BG uses their own entries (blizzlike).
    - Moved logs from incorrect logger "sql.sql" to "bg.battleground"
    Additional Notes for some BGs:
    - Warsong Gulch:
      * Fixed inverted worldstates of flags being sent to new players, wrong flag state was shown on UI
    - Alterac Valley:
      * Fix Snowfall graveyard cap time as per Patch 2.3.0
      * Use proper gameobject entries for each node (blizzlike)
      * Removed magic numbers in favor of compile time consts (enum offsets etc)
      * More additional missing spawns (both creatures and gameobjects)
    - Isle of Conquest:
      * Removed Transport pointers from class, instead store GUIDs and use HashMapHolder to access them
      * Fixed some wrong spawns which had Y coord set as X coord, Z as Y and Orientation as Z, fix a double spawn related to this
      * Additional cleanups of spawn code that checked if the spawn was correct only to then do a Get(spawntype) to manipulate it.
      * Incremented door close time to 30 seconds, as it is on sniff
    - Strand of the Ancients:
      * Fixed sending timer to players that join with BG in progress
      * Corrected ships rotation as per sniff
      * Added missing seaforium bomb spawns
      * Implemented team switch logic to different spawn entries (like Titan Relic)
      * Implemented changing teleport locations depending on destroyed doors (Closes #12127)
  4. Core/Misc: calculate rotation fields from orientation in some places …

    ariel- committed Sep 3, 2016
    …it's impossible to get:
    - SmartScripts: SMART_ACTION_SUMMON_GO
    - Spell Effects:
    - Command Scripts: .gobject add
    Closes #17891
  5. Core/RBAC: Added rbac permissions from 6.x branch

    joschiwald committed Sep 3, 2016
  6. Drycoding is bad, mmkay?

    Treeston committed Sep 3, 2016
  7. Scripts/Events: Globally fix all ExecuteEvent loops to check UNIT_STA…

    Treeston committed Sep 3, 2016
    …TE_CASTING after each iteration, instead of just checking it once initially.
    Fixes and closes #17892.
Commits on Sep 2, 2016
  1. Core/SmartScripts: Add missing break, 5f43e7b follow-up.

    Treeston committed Sep 2, 2016
  2. Merge branch '3.3.5-goshdangitsmartai' into 3.3.5 (PR #17738)

    Treeston committed Sep 2, 2016
  3. Scripts/SmartScripts: Fix charmed behavior for SmartAI. For real this…

    Treeston committed Aug 5, 2016
    … time.
    - Core AI logic will no longer issue attack/movement commands while under player control.
    - Add new SMART_EVENT_FLAG_WHILE_CHARMED (0x200). Any event without this flag won't run while charmed.
    - Add SMART_EVENT_FLAG_WHILE_CHARMED to existing actions, except a select subset (movement, talking, and nontriggered casts, pretty much).
  4. Another build fix.

    ariel- committed Sep 2, 2016
    (it was probably better to just revert the commit instead)
  5. Note to self: drycoding is bad

    ariel- committed Sep 2, 2016
  6. Core/Spell: no need to bloat existing parameter lists. (f81754a follo…

    ariel- committed Sep 2, 2016
    …w up)
  7. DB: Add missing racial mounts to faction change

    ariel- committed Sep 2, 2016
  8. DB/Creature: Hardened Steel Skycaller

    ariel- committed Sep 2, 2016
    Fix correct spell, was 52775 Summon Escort
  9. DB/Creature: Make Coldarra Spellweavers cast Arcane Missiles (channel…

    Treeston committed Sep 2, 2016
    …) instead of Arcane Missile (triggered spell).
Commits on Sep 1, 2016
  1. DB/Creature: More fixes for that poor Cabal Abjurist! Plus bonus cont…

    Treeston committed Sep 1, 2016
    …ent for Bleeding Hollow Darkcaster.
    I feel like a DB dev now.
  2. DB/Creature: Fix Cabal Abjurist SAI

    Treeston committed Sep 1, 2016
  3. Core/Spell: Workaround cobra strikes into a charged aura instead of s…

    ariel- committed Sep 1, 2016
    Fixes #754
  4. Core/Spells: Remove spellmods from SpellMod owner instead of caster (…

    ariel- committed Sep 1, 2016
    …needed so pet casts properly remove aura charges)
  5. Core/Spells: fix Bullheaded immunities

    ariel- committed Sep 1, 2016
    Closes #421
  6. Core/Spells: Move Missile Barrage, Hot Streak and Brain Freeze mage t…

    ariel- committed Sep 1, 2016
    …alents to proc system. Also implement T8 4P Bonus.
    Closes #1536
Commits on Aug 31, 2016
  1. Core/Position: Allow implicit casting to G3D::Vector. Also, add a uti…

    Treeston committed Aug 31, 2016
    …lity overload to MotionMaster.
  2. DB/Creature: Fix random inhabittype that was making an Outland world …

    Treeston committed Aug 31, 2016
    …elite permanently rooted.
Commits on Aug 30, 2016
  1. Replace a leftover const char* with a std::string const&.

    Treeston committed Aug 30, 2016
  2. Entities/Gossip: The Big One™ that gets rid of all uses of The Bad™ a…

    Treeston committed Aug 30, 2016
    …nd The Ugly™, e.g. gossip preprocessor macros, and replaces them with the new-and-shiny gossip functions.
  3. Fix dynamic build.

    Treeston committed Aug 30, 2016
  4. Core/Scripts: remove forgotten #define in boss_kalecgos.cpp

    illfated committed Aug 30, 2016
    This #define was originally supposed to be removed in my PR #17832,
    but for some reason it remained undeleted. This commit corrects it.
    Also aligned all the enum values to the same column for readability,
    based on a common multiple of 4 spaces.
  5. SQL file fixed: insert newline at End Of File

    illfated committed Aug 30, 2016
  6. DB/Quest: The Scepter of Celebras

    illfated committed Aug 30, 2016
    Main SQL content by Gargarensis and DevQuad
    (possibly sourced from classicdb/database@b5d4eeb )
    Closes #4929
Commits on Aug 29, 2016
  1. Core/Define: Remove the conditional macro for constexpr.

    Naios committed Aug 27, 2016
    * Not needed anymore since the requirements were raised to MSVC 2015.
You can’t perform that action at this time.