New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{quest}March of the Giants #10246

Closed
BlackVortex opened this Issue Jul 7, 2013 · 2 comments

Comments

Projects
None yet
3 participants
@BlackVortex

BlackVortex commented Jul 7, 2013

hello everyone,
You can use quest item on giants while they are alive and counts towards the quest when you use it on the same one.
WoWWiKi link to quest-http://www.wowwiki.com/Quest:March_of_the_Giants_%28Horde%29
wowhead link to quest item-http://www.wowhead.com/item=33806
TBD : 335.51
Hash: 0e4cebf
Linux, SQL.
Thx for help.

@Justiciar

This comment has been minimized.

Show comment
Hide comment
@Justiciar

Justiciar Aug 24, 2013

I fixed it.
I'm not sure if my fix is an hack or not, but it's working.
It can serve as a temp fix if it's not legit.
I fixed 3 issues:
*It was possible to target any npc with the Runeseeking Pick and get the credit, now it's only targeting Runed Stone Giant at it should(corpse, ^it's a separate condition).
*It was possible to use the Runeseeking pick on the Runed Stone Giant and get the credit while it was alive, now it's working only on a Runed Stone Giant Corpe.
*It was possible to use the Runeseeking pick on the same Runed Stone Giant and get unlimited credit, now it's possible to get only 1 credit from each corpse(afterwards, the Runed Stone Giant despawn).
Hash: 20a61b6
TDB: �335.52�

Fix:

SET @RUNESEEKINGPICK :=  43666; 
SET @RUNEDSTONEGIANT :=  24329;
SET @NPC_REWARD      :=  24329; 
DELETE FROM `conditions` WHERE `SourceEntry`=@RUNESEEKINGPICK AND `SourceTypeOrReferenceId`=17;
INSERT INTO `conditions` (`SourceTypeOrReferenceId`, `SourceGroup`, `SourceEntry`, `SourceId`, `ElseGroup`, `ConditionTypeOrReference`, `ConditionTarget`, `ConditionValue1`, `ConditionValue2`, `ConditionValue3`, `NegativeCondition`, `ErrorTextId`, `ScriptName`, `Comment`) VALUES
(17,0,@RUNESEEKINGPICK,0,0,36,1,0,0,0,1,0,'', 'Runeseeking Pick can target only a corpse'),
(17,0,@RUNESEEKINGPICK,0,0,31,1,3,@RUNEDSTONEGIANT,0,0,0,'', 'Runeseeking Pick can target only RUNEDSTONEGIANT');
UPDATE `creature_template` SET `AIName`='SmartAI' WHERE `entry` = @RUNEDSTONEGIANT; 
DELETE FROM `smart_scripts` WHERE `entryorguid` = @RUNEDSTONEGIANT AND `source_type`=0; 
INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, 
`event_param2`, `event_param3`, `event_param4`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, 
`action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES 
(@RUNEDSTONEGIANT,0,0,1,8,0,100,1,@RUNESEEKINGPICK,0,0,0,80,@NPC_REWARD*100+1,2,0,0,0,0,16,0,0,0,0,0,0,0, 'Runed Stone Giant- Script - Give Quest Credit'),
(@RUNEDSTONEGIANT,0,1,0,61,0,100,1,0,0,0,0,41,2000,0,0,0,0,0,1,0,0,0,0,0,0,0, 'Runed Stone Giant - Despawn after 2 seconds');

Justiciar commented Aug 24, 2013

I fixed it.
I'm not sure if my fix is an hack or not, but it's working.
It can serve as a temp fix if it's not legit.
I fixed 3 issues:
*It was possible to target any npc with the Runeseeking Pick and get the credit, now it's only targeting Runed Stone Giant at it should(corpse, ^it's a separate condition).
*It was possible to use the Runeseeking pick on the Runed Stone Giant and get the credit while it was alive, now it's working only on a Runed Stone Giant Corpe.
*It was possible to use the Runeseeking pick on the same Runed Stone Giant and get unlimited credit, now it's possible to get only 1 credit from each corpse(afterwards, the Runed Stone Giant despawn).
Hash: 20a61b6
TDB: �335.52�

Fix:

SET @RUNESEEKINGPICK :=  43666; 
SET @RUNEDSTONEGIANT :=  24329;
SET @NPC_REWARD      :=  24329; 
DELETE FROM `conditions` WHERE `SourceEntry`=@RUNESEEKINGPICK AND `SourceTypeOrReferenceId`=17;
INSERT INTO `conditions` (`SourceTypeOrReferenceId`, `SourceGroup`, `SourceEntry`, `SourceId`, `ElseGroup`, `ConditionTypeOrReference`, `ConditionTarget`, `ConditionValue1`, `ConditionValue2`, `ConditionValue3`, `NegativeCondition`, `ErrorTextId`, `ScriptName`, `Comment`) VALUES
(17,0,@RUNESEEKINGPICK,0,0,36,1,0,0,0,1,0,'', 'Runeseeking Pick can target only a corpse'),
(17,0,@RUNESEEKINGPICK,0,0,31,1,3,@RUNEDSTONEGIANT,0,0,0,'', 'Runeseeking Pick can target only RUNEDSTONEGIANT');
UPDATE `creature_template` SET `AIName`='SmartAI' WHERE `entry` = @RUNEDSTONEGIANT; 
DELETE FROM `smart_scripts` WHERE `entryorguid` = @RUNEDSTONEGIANT AND `source_type`=0; 
INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, 
`event_param2`, `event_param3`, `event_param4`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, 
`action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES 
(@RUNEDSTONEGIANT,0,0,1,8,0,100,1,@RUNESEEKINGPICK,0,0,0,80,@NPC_REWARD*100+1,2,0,0,0,0,16,0,0,0,0,0,0,0, 'Runed Stone Giant- Script - Give Quest Credit'),
(@RUNEDSTONEGIANT,0,1,0,61,0,100,1,0,0,0,0,41,2000,0,0,0,0,0,1,0,0,0,0,0,0,0, 'Runed Stone Giant - Despawn after 2 seconds');

@ghost ghost assigned DDuarte Aug 24, 2013

@BlackVortex

This comment has been minimized.

Show comment
Hide comment
@BlackVortex

BlackVortex Aug 25, 2013

working.
ty.

BlackVortex commented Aug 25, 2013

working.
ty.

@Aokromes Aokromes closed this in 741eed4 Nov 3, 2013

raczman pushed a commit to raczman/TrinityCore that referenced this issue Apr 20, 2014

DB/Misc: March of the Giants
by Justiciar, closes #10246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment