Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quest] Deep in the bowels of the Underhalls 3.3.5 #10844

Closed
ghost opened this issue Sep 16, 2013 · 11 comments
Closed

[Quest] Deep in the bowels of the Underhalls 3.3.5 #10844

ghost opened this issue Sep 16, 2013 · 11 comments

Comments

@ghost
Copy link

ghost commented Sep 16, 2013

TrinityCore rev. 0177d1c+ 2013-09-15 07:01:58 -0700 (master branch) (Win32, Release)

The Bone Witch in Njorndar Village has asked you to beat information out of Apprentice Osterkilgr concerning what Dr. Terrible is truly up to.

http://www.wowhead.com/quest=13042/deep-in-the-bowels-of-the-underhalls

You don't get credit for beating the information out of Apprentice Osterkilgr. You do get credit for killing him.

@untaught
Copy link
Contributor

Try this:

UPDATE `smart_scripts` SET `target_type`=24 WHERE `entryorguid`=30409 AND `source_type`=0 AND `id`=4 AND `link`=0;

@dr-j
Copy link
Contributor

dr-j commented Sep 17, 2013

Ye that will work (I know) already done that, was looking for sql last night but could not find it though,

@ghost ghost assigned DDuarte Sep 17, 2013
@filipboev
Copy link
Contributor

Sigh, wish we didn't have to hack our way through credits at least.

@untaught
Copy link
Contributor

Yeah, but now the invoker is not everything ;)
I don't think this is a hack. :S

@ghost
Copy link
Author

ghost commented Sep 17, 2013

If something works correctly and doesn't conflict with anything else we should call it a fix and not a hack. : )

@ghost
Copy link
Author

ghost commented Sep 17, 2013

This works for me as well. Nice job

@ghost
Copy link
Author

ghost commented Sep 17, 2013

Yeah this works great.

@filipboev
Copy link
Contributor

It works, true. And I'm also forced a lot of times to use it as opposed to something that should in fact be applicable to that current way of giving credit, but let's face it SMART_TARGET_THREAT_LIST isn't what we primarily want to use, since we can't be sure everyone on the threat list is also on the quest. Nonetheless. we will make due with what works.

@untaught
Copy link
Contributor

You can't be sure that INVOKER is on the quest too. That's the way it works - if you have the quest you recieve the quest credit and it counts in the quest progression, if you are not on the quest - you recieve the credit but it does nothing for you. Every quest credit works like this because if we use conditions table to check it we'll only slow the core down.
I can't understand why SMART_TARGET_THREAT_LIST is a hack solution but nvm.
Also if we set the target_type to INVOKER here and if there are 2 players in a group doing the quest the core will reward only the player who hit and made the NPC go below 40% HP which is wrong again. Usage of INVOKER_PARTY or THREAT_LIST is the solution. But as i said invoker is not everything at this time and the alternative in this case is THREAT_LIST which is NOT a hack.

@filipboev
Copy link
Contributor

Sniffs say otherwise, we don't argue with sniffs.

@untaught
Copy link
Contributor

Sniffs contains target_types? :octocat: Damn sniffs!

raczman pushed a commit to raczman/TrinityCore that referenced this issue Apr 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants