Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[Core / Pet] [Patch] Pets at rest are too far away #10865

Closed
MrSmite opened this Issue Sep 18, 2013 · 6 comments

Comments

Projects
None yet
5 participants
Contributor

MrSmite commented Sep 18, 2013

Rev: All

Bug:

When pets are idle, they are too far away from their owner

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Contributor

MrSmite commented Oct 13, 2013

Any reason this hasn't been merged?

tkrokli added a commit to tkrokli/TrinityCore that referenced this issue Nov 9, 2015

3.3.5 Core/Pet: Modified following speed and distance between owner a…
…nd pet

Changes

- Move pets closer to their owner
- Help prevent stop-and-go movement in follow mode
- Cap pet follow speed bonus
- Only sync speed with owner when near or slower
- Pets only walk when near their owner
- Creature pets can walk
- Pets swim at thier swim speed not run/walk speed
- Pets can sync swim speed with their owner
- SetSwim() checks if water IsSwimmable()
- Creatures move at run/walk speed in water until it gets too deep
- Creatures can be slowed in the water
- All minions (pets, guardians, companions) can sync speed with their owner
- Player pets change the direction they are looking to match their owners

Closes #8924 #10865 #12595 #12817

tkrokli added a commit to tkrokli/TrinityCore that referenced this issue Nov 9, 2015

Core/Pet: Modified following speed and distance between owner and pet
Changes

- Move pets closer to their owner
- Help prevent stop-and-go movement in follow mode
- Cap pet follow speed bonus
- Only sync speed with owner when near or slower
- Pets only walk when near their owner
- Creature pets can walk
- Pets swim at thier swim speed not run/walk speed
- Pets can sync swim speed with their owner
- SetSwim() checks if water IsSwimmable()
- Creatures move at run/walk speed in water until it gets too deep
- Creatures can be slowed in the water
- All minions (pets, guardians, companions) can sync speed with their owner
- Player pets change the direction they are looking to match their owners

Closes #8924 #10865 #12595 #12817

tkrokli added a commit to tkrokli/TrinityCore that referenced this issue Nov 9, 2015

Core/Pet: Modified following speed and distance between owner and pet
Changes:

- Move pets closer to their owner
- Help prevent stop-and-go movement in follow mode
- Cap pet follow speed bonus
- Only sync speed with owner when near or slower
- Pets only walk when near their owner
- Creature pets can walk
- Pets swim at their swim speed, not run/walk speed
- Pets can sync swim speed with their owner
- SetSwim() checks if water IsSwimmable()
- Creatures move at run/walk speed in water until it gets too deep
- Creatures can be slowed in the water
- All minions (pets, guardians, companions) can sync speed with their owner
- Player pets change the direction they are looking to match their owners

Closes #8924 #10865 #12595 #12817

tkrokli added a commit to tkrokli/TrinityCore that referenced this issue Nov 9, 2015

Core/Pet: Modified following speed and distance between owner and pet
Changes:

- Move pets closer to their owner
- Help prevent stop-and-go movement in follow mode
- Cap pet follow speed bonus
- Only sync speed with owner when near or slower
- Pets only walk when near their owner
- Creature pets can walk
- Pets swim at their swim speed, not run/walk speed
- Pets can sync swim speed with their owner
- SetSwim() checks if water IsSwimmable()
- Creatures move at run/walk speed in water until it gets too deep
- Creatures can be slowed in the water
- All minions (pets, guardians, companions) can sync speed with their owner
- Player pets change the direction they are looking to match their owners

Closes #8924 #10865 #12595 #12817

tkrokli added a commit to tkrokli/TrinityCore that referenced this issue Nov 10, 2015

Core/Pet: Modified following speed and distance between owner and pet
Changes:

- Move pets closer to their owner
- Help prevent stop-and-go movement in follow mode
- Cap pet follow speed bonus
- Only sync speed with owner when near or slower
- Pets only walk when near their owner
- Creature pets can walk
- Pets swim at their swim speed, not run/walk speed
- Pets can sync swim speed with their owner
- SetSwim() checks if water IsSwimmable()
- Creatures move at run/walk speed in water until it gets too deep
- Creatures can be slowed in the water
- All minions (pets, guardians, companions) can sync speed with their owner
- Player pets change the direction they are looking to match their owners

Closes #8924 #10865 #12595 #12817

tkrokli added a commit to tkrokli/TrinityCore that referenced this issue Nov 10, 2015

Core/Pet: Modified following speed and distance between owner and pet
Changes:

- Move pets closer to their owner
- Help prevent stop-and-go movement in follow mode
- Cap pet follow speed bonus
- Only sync speed with owner when near or slower
- Pets only walk when near their owner
- Creature pets can walk
- Pets swim at their swim speed, not run/walk speed
- Pets can sync swim speed with their owner
- SetSwim() checks if water IsSwimmable()
- Creatures move at run/walk speed in water until it gets too deep
- Creatures can be slowed in the water
- All minions (pets, guardians, companions) can sync speed with their owner
- Player pets change the direction they are looking to match their owners

Closes #8924 #10865 #12595 #12817

tkrokli added a commit to tkrokli/TrinityCore that referenced this issue Nov 16, 2015

Core/Pet: Modified following speed and distance between owner and pet
Changes:

- Move pets closer to their owner
- Help prevent stop-and-go movement in follow mode
- Cap pet follow speed bonus
- Only sync speed with owner when near or slower
- Pets only walk when near their owner
- Creature pets can walk
- Pets swim at their swim speed not run/walk speed
- Pets can sync swim speed with their owner
- SetSwim() checks if water IsSwimmable()
- Creatures move at run/walk speed in water until it gets too deep
- Creatures can be slowed in the water
- All minions (pets, guardians, companions) can sync speed with their owner
- Player pets change the direction they are looking to match their owner

Closes #8924 #10865 #12595 #12817

tkrokli added a commit to tkrokli/TrinityCore that referenced this issue Nov 16, 2015

Core/Pet: Modified following speed and distance between owner and pet
Changes:

- Move pets closer to their owner
- Help prevent stop-and-go movement in follow mode
- Cap pet follow speed bonus
- Only sync speed with owner when near or slower
- Pets only walk when near their owner
- Creature pets can walk
- Pets swim at their swim speed not run/walk speed
- Pets can sync swim speed with their owner
- SetSwim() checks if water IsSwimmable()
- Creatures move at run/walk speed in water until it gets too deep
- Creatures can be slowed in the water
- All minions (pets, guardians, companions) can sync speed with their owner
- Player pets change the direction they are looking to match their owner

Closes #8924 #10865 #12595 #12817

tkrokli added a commit to tkrokli/TrinityCore that referenced this issue Nov 16, 2015

Core/Pet: Modified following speed and distance between owner and pet
Changes:

- Move pets closer to their owner
- Help prevent stop-and-go movement in follow mode
- Cap pet follow speed bonus
- Only sync speed with owner when near or slower
- Pets only walk when near their owner
- Creature pets can walk
- Pets swim at their swim speed not run/walk speed
- Pets can sync swim speed with their owner
- SetSwim() checks if water IsSwimmable()
- Creatures move at run/walk speed in water until it gets too deep
- Creatures can be slowed in the water
- All minions (pets, guardians, companions) can sync speed with their owner
- Player pets change the direction they are looking to match their owner

Closes #8924 #10865 #12595 #12817
Owner

Aokromes commented May 26, 2016

If the fix here is valid, plz open a PR.

Contributor

MrSmite commented May 28, 2016

If the fix here is valid, plz open a PR.

A PR was created in 2013 (see entry below OP) and the topic was already labeled "feedback-patchfix"

Member

tkrokli commented May 28, 2016

Are you saying that this issue could have been closed in 2013, or did you close your PR because it did not get merged? (sorry, it is a bit confusing when I don't see if anything got added to the source)


edit: is 831b404 something that god added to the 3.3.5 source, or is that a github page bug? I can't find that same change in the current source, did it get reverted later or just changed somewhere else?

Contributor

MrSmite commented May 29, 2016

No, The original PR had multiple commits and I'd been asked to squash them. I wasn't sure how to do that so I closed it and pushed a clean PR (see above): d1e6b60 which is still open.

As for 831b404 , I don't know what that is but it doesn't appear to address the issue anyway.

Owner

Aokromes commented May 29, 2016

I don't see that PR on PR lists.

Aokromes added a commit to Aokromes/TrinityCore that referenced this issue May 29, 2016

Aokromes added a commit to Aokromes/TrinityCore that referenced this issue May 29, 2016

Aokromes added a commit to Aokromes/TrinityCore that referenced this issue May 29, 2016

Aokromes added a commit to Aokromes/TrinityCore that referenced this issue May 29, 2016

Aokromes added a commit that referenced this issue Jun 18, 2016

Core/Pet: Fix pet at rest distance (#17206)
* Core/Pet: Fix pet at rest distance

By MrSmite, closes #10865

* Update TargetedMovementGenerator.cpp

Keader added a commit to Keader/TrinityCore that referenced this issue Jul 10, 2016

Core/Pet: Fix pet at rest distance (#17206)
* Core/Pet: Fix pet at rest distance

By MrSmite, closes #10865

* Update TargetedMovementGenerator.cpp

Aokromes added a commit to Aokromes/TrinityCore that referenced this issue Jul 20, 2016

Core/Pet: Fix pet at rest distance (#17206)
* Core/Pet: Fix pet at rest distance

By MrSmite, closes #10865

* Update TargetedMovementGenerator.cpp

joschiwald added a commit that referenced this issue Jan 29, 2017

Core/Pet: Fix pet at rest distance (#17206)
* Core/Pet: Fix pet at rest distance

By MrSmite, closes #10865

* Update TargetedMovementGenerator.cpp

(cherry picked from commit b2effe4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment