[4.3.4] Random Battleground Daily Reward

[puka]

When you win a battleground using the Random Battleground queue, you win 4000 honor points (max honor). Its seem that is taking the WOTLK system reward and not the Cataclysm Reward.

Thanks and sorry for my english.

TrinityCore rev. d349e61 2014-02-02 11:59:27 +0100 (4.3.4 branch) (Unix, Release)
DB: TDB_full_434.05_2013_07_17 + 4.3.4 DB_alpha

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[killradio]

Confirm + "conquest points this week" bar bugged as well.

[OneB1t]

void Player::SendPvPRewards()
{
    uint32 t1 = GetCurrencyWeekCap(CURRENCY_TYPE_CONQUEST_POINTS, true);
    uint32 t2 = GetCurrencyOnWeek(CURRENCY_TYPE_CONQUEST_POINTS, true);
    uint32 t3 = GetCurrencyWeekCap(CURRENCY_TYPE_CONQUEST_META_ARENA, true);
    uint32 t4 = GetCurrencyOnWeek(CURRENCY_TYPE_CONQUEST_META_RBG, true);
    uint32 t5 = GetCurrencyOnWeek(CURRENCY_TYPE_CONQUEST_META_ARENA, true);
    uint32 t6 = GetCurrencyWeekCap(CURRENCY_TYPE_CONQUEST_POINTS, true);


    WorldPacket packet(SMSG_REQUEST_PVP_REWARDS_RESPONSE, 24);
    packet << t1;
    packet << t2;
    packet << t3;
    packet << t4;
    packet << t5;
    packet << t6;
    GetSession()->SendPacket(&packet);
}


uint32 Player::_GetCurrencyWeekCap(const CurrencyTypesEntry* currency) const
{
    uint32 cap = currency->WeekCap;

    switch (currency->ID)
    {
        //original conquest not have week cap
    case CURRENCY_TYPE_CONQUEST_POINTS:
        return std::max(GetCurrencyWeekCap(CURRENCY_TYPE_CONQUEST_META_ARENA, false), GetCurrencyWeekCap(CURRENCY_TYPE_CONQUEST_META_RBG, false));
    case CURRENCY_TYPE_CONQUEST_META_ARENA:
        // should add precision mod = 100
        return Trinity::Currency::ConquestRatingCalculator(_maxPersonalArenaRate) * CURRENCY_PRECISION;
    case CURRENCY_TYPE_CONQUEST_META_RBG:
        // should add precision mod = 100
        return Trinity::Currency::BgConquestRatingCalculator(GetRBGPersonalRating()) * CURRENCY_PRECISION;
    }

    if (cap != currency->WeekCap && IsInWorld() && !GetSession()->PlayerLoading())
    {
        WorldPacket packet(SMSG_UPDATE_CURRENCY_WEEK_LIMIT, 8);
        packet << uint32(cap / ((currency->Flags & CURRENCY_FLAG_HIGH_PRECISION) ? 100 : 1));
        packet << uint32(currency->ID);
        GetSession()->SendPacket(&packet);
    }

    return cap;
}

this is for conquest point fix ;)

[burnham]

And what about he honor points?.

[Aokromes]

Anyone can create a PR about this?

[Shauren]

Objection. That is a horrible hack with horrible design.

[DDuarte]

The hack is not required at all.