[crash] CharmInfo::IsReturning #11656

Closed
digz6666 opened this Issue Mar 1, 2014 · 8 comments

Projects

None yet

5 participants

@digz6666
digz6666 commented Mar 1, 2014

Crashlog: http://www.trinitycore.org/f/pastebin/4o9gh5gemlj3/

Revision: d5d2805
Database: TDB 335.52 (with updates)

@jackpoz jackpoz added the HasBacktrace label Mar 1, 2014
@MrSmite
Contributor
MrSmite commented Mar 5, 2014

You need to provide more detail. What were you doing, were mmaps enabled, etc.

The revision you linked has mmap changes so I'm guessing it's related (there's crash discussion on the commit itself). The pet AI has been pretty stable for several years now.

@digz6666
digz6666 commented Mar 5, 2014

I have mmaps enabled.

@jackpoz
Member
jackpoz commented Mar 5, 2014

so I'm guessing it's related

wrong guess, the callstack in the crash log has nothing to do with mmaps

@MrSmite
Contributor
MrSmite commented Mar 5, 2014

@jackpoz Not necessarily. Devs. here are known for not testing their commits and since the crash happened after an mmaps commit, it's likely that something in that commit broke something else.

That's what I meant by related, not that mmaps was a direct cause of the crash but possibly an untested commit. When you read the comments in that commit and see other people had crashes, it indicates it was an unstable (and possibly untested) commit.

The easy way for the OP to check is to pull the commit prior to the mmap change, duplicate whatever action they did in-game and see if it crashes.

@jackpoz
Member
jackpoz commented Mar 5, 2014

Comments in that commit were about crashes with no clear crash log and now they don't happen anymore even on same user, so again, totally unrelated to mmaps.
It's also clear reading which code mmaps commit changed that it will not add any random crash like this one since it just updated recast to a more recent version.
It's not about user comments, it's about what has been changed.

@Sovak
Contributor
Sovak commented Mar 5, 2014

Ive been seing this crash for over a year already, its not mmaps ^^

@jackpoz
Member
jackpoz commented Mar 6, 2014

Any clue about how to reproduce it ?

@Aokromes
Member

No feedback after more than 6 months, closing, if this bug is still valid open a new ticket.

@Aokromes Aokromes closed this Nov 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment