Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BG/SotA #12127

Open
Trisjdc opened this Issue May 25, 2014 · 0 comments

Comments

Projects
None yet
3 participants
@Trisjdc
Copy link
Contributor

commented May 25, 2014

Core: 01b33a6
DB: Up to the date to that commit

When a gate is destroyed, the teleport of both the gates in that 'line' should guide to the previous line

Conceptually:
Green OR Blue Gate destroyed -> teleport leads to Red/Purple, respectively
Red OR Purple Gate destroyed -> teleport leads to Yellow

I believe this should be done by simply despawning the creatures which are used for the teleport spell

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Aokromes Aokromes added the Comp-Core label May 25, 2014

@ariel- ariel- self-assigned this Aug 17, 2016

ariel- added a commit that referenced this issue Aug 18, 2016

Core/PvP: Extensive cleanup, bug-fixing and optimization of Battlegro…
…und scripts:

- Standards: Moved all statics to cpps where they belong.
- Cleanups: NULL -> nullptr, moved #defines to constants/enums
- Added a helper struct for handling spawns easily. Rewrote spawns using it.
- Moved spawn containers to private scope of Battleground (idea taken from boss states array in InstanceScripts)
- Remove unused teamId parameter from Battleground::SpawnCreature
- Make AddObject return a GameObject pointer instead of a bool (just like its AddCreature sibling)
- Corrected and added proper GO rotation to spawns
- De-hardcode buff entries for Battlegrounds, each BG uses their own entries (blizzlike).
- Moved logs from incorrect logger "sql.sql" to "bg.battleground"

Additional Notes for some BGs:
- Alterac Valley:
  * Fix Snowfall graveyard cap time as per Patch 2.3.0
  * Use proper gameobject entries for each node (blizzlike)
  * Removed magic numbers in favor of compile time consts (enum offsets etc)
  * More additional missing spawns (both creatures and gameobjects)

- Isle of Conquest:
  * Removed Transport pointers from class, instead store GUIDs and use HashMapHolder to access them
  * Fixed some wrong spawns which had Y coord set as X coord, Z as Y and Orientation as Z, fix a double spawn related to this
  * Additional cleanups of spawn code that checked if the spawn was correct only to then do a Get(spawntype) to manipulate it.
  * Incremented door close time to 30 seconds, as it is on sniff

- Strand of the Ancients:
  * Fixed sending timer to players that join with BG in progress
  * Corrected ships rotation as per sniff
  * Added missing seaforium bomb spawns
  * Implemented team switch logic to different spawn entries (like Titan Relic)
  * Implemented changing teleport locations depending on destroyed doors (Closes #12127)

ariel- added a commit that referenced this issue Aug 18, 2016

Core/PvP: Extensive cleanup, bug-fixing and optimization of Battlegro…
…und scripts:

- Standards: Moved all statics to cpps where they belong.
- Cleanups: NULL -> nullptr, moved #defines to constants/enums
- Added a helper struct for handling spawns easily. Rewrote spawns using it.
- Moved spawn containers to private scope of Battleground (idea taken from boss states array in InstanceScripts)
- Remove unused teamId parameter from Battleground::SpawnCreature
- Make AddObject return a GameObject pointer instead of a bool (just like its AddCreature sibling)
- Corrected and added proper GO rotation to spawns
- De-hardcode buff entries for Battlegrounds, each BG uses their own entries (blizzlike).
- Moved logs from incorrect logger "sql.sql" to "bg.battleground"

Additional Notes for some BGs:
- Alterac Valley:
  * Fix Snowfall graveyard cap time as per Patch 2.3.0
  * Use proper gameobject entries for each node (blizzlike)
  * Removed magic numbers in favor of compile time consts (enum offsets etc)
  * More additional missing spawns (both creatures and gameobjects)

- Isle of Conquest:
  * Removed Transport pointers from class, instead store GUIDs and use HashMapHolder to access them
  * Fixed some wrong spawns which had Y coord set as X coord, Z as Y and Orientation as Z, fix a double spawn related to this
  * Additional cleanups of spawn code that checked if the spawn was correct only to then do a Get(spawntype) to manipulate it.
  * Incremented door close time to 30 seconds, as it is on sniff

- Strand of the Ancients:
  * Fixed sending timer to players that join with BG in progress
  * Corrected ships rotation as per sniff
  * Added missing seaforium bomb spawns
  * Implemented team switch logic to different spawn entries (like Titan Relic)
  * Implemented changing teleport locations depending on destroyed doors (Closes #12127)

ariel- added a commit that referenced this issue Aug 18, 2016

Core/PvP: Extensive cleanup, bug-fixing and optimization of Battlegro…
…und scripts:

- Standards: Moved all statics to cpps where they belong.
- Cleanups: NULL -> nullptr, moved #defines to constants/enums
- Added a helper struct for handling spawns easily. Rewrote spawns using it.
- Moved spawn containers to private scope of Battleground (idea taken from boss states array in InstanceScripts)
- Remove unused teamId parameter from Battleground::SpawnCreature
- Prevent Battleground::RelocateDeadPlayers creating new entries on map.
- Make AddObject return a GameObject pointer instead of a bool (just like its AddCreature sibling)
- Corrected and added proper GO rotation to spawns
- De-hardcode buff entries for Battlegrounds, each BG uses their own entries (blizzlike).
- Moved logs from incorrect logger "sql.sql" to "bg.battleground"

Additional Notes for some BGs:
- Warsong Gulch:
  * Fixed inverted worldstates of flags being sent to new players, wrong flag state was shown on UI

- Alterac Valley:
  * Fix Snowfall graveyard cap time as per Patch 2.3.0
  * Use proper gameobject entries for each node (blizzlike)
  * Removed magic numbers in favor of compile time consts (enum offsets etc)
  * More additional missing spawns (both creatures and gameobjects)

- Isle of Conquest:
  * Removed Transport pointers from class, instead store GUIDs and use HashMapHolder to access them
  * Fixed some wrong spawns which had Y coord set as X coord, Z as Y and Orientation as Z, fix a double spawn related to this
  * Additional cleanups of spawn code that checked if the spawn was correct only to then do a Get(spawntype) to manipulate it.
  * Incremented door close time to 30 seconds, as it is on sniff

- Strand of the Ancients:
  * Fixed sending timer to players that join with BG in progress
  * Corrected ships rotation as per sniff
  * Added missing seaforium bomb spawns
  * Implemented team switch logic to different spawn entries (like Titan Relic)
  * Implemented changing teleport locations depending on destroyed doors (Closes #12127)

ariel- added a commit that referenced this issue Aug 18, 2016

Core/PvP: Extensive cleanup, bug-fixing and optimization of Battlegro…
…und scripts:

- Standards: Moved all statics to cpps where they belong.
- Cleanups: NULL -> nullptr, moved #defines to constants/enums
- Added a helper struct for handling spawns easily. Rewrote spawns using it.
- Moved spawn containers to private scope of Battleground (idea taken from boss states array in InstanceScripts)
- Remove unused teamId parameter from Battleground::SpawnCreature
- Prevent Battleground::RelocateDeadPlayers creating new entries on map.
- Make AddObject return a GameObject pointer instead of a bool (just like its AddCreature sibling)
- Corrected and added proper GO rotation to spawns
- De-hardcode buff entries for Battlegrounds, each BG uses their own entries (blizzlike).
- Moved logs from incorrect logger "sql.sql" to "bg.battleground"

Additional Notes for some BGs:
- Warsong Gulch:
  * Fixed inverted worldstates of flags being sent to new players, wrong flag state was shown on UI

- Alterac Valley:
  * Fix Snowfall graveyard cap time as per Patch 2.3.0
  * Use proper gameobject entries for each node (blizzlike)
  * Removed magic numbers in favor of compile time consts (enum offsets etc)
  * More additional missing spawns (both creatures and gameobjects)

- Isle of Conquest:
  * Removed Transport pointers from class, instead store GUIDs and use HashMapHolder to access them
  * Fixed some wrong spawns which had Y coord set as X coord, Z as Y and Orientation as Z, fix a double spawn related to this
  * Additional cleanups of spawn code that checked if the spawn was correct only to then do a Get(spawntype) to manipulate it.
  * Incremented door close time to 30 seconds, as it is on sniff

- Strand of the Ancients:
  * Fixed sending timer to players that join with BG in progress
  * Corrected ships rotation as per sniff
  * Added missing seaforium bomb spawns
  * Implemented team switch logic to different spawn entries (like Titan Relic)
  * Implemented changing teleport locations depending on destroyed doors (Closes #12127)

ariel- added a commit that referenced this issue Aug 22, 2016

[WiP] Core/PvP: Extensive cleanup, bug-fixing and optimization of Bat…
…tleground scripts:

- Standards: Moved all statics to cpps where they belong.
- Cleanups: NULL -> nullptr, moved #defines to constants/enums
- Added a helper struct for handling spawns easily. Rewrote spawns using it.
- Moved spawn containers to private scope of Battleground (idea taken from boss states array in InstanceScripts)
- Remove unused teamId parameter from Battleground::SpawnCreature
- Prevent Battleground::RelocateDeadPlayers creating new entries on map.
- Make AddObject return a GameObject pointer instead of a bool (just like its AddCreature sibling)
- Corrected and added proper GO rotation to spawns
- De-hardcode buff entries for Battlegrounds, each BG uses their own entries (blizzlike).
- Moved logs from incorrect logger "sql.sql" to "bg.battleground"

Additional Notes for some BGs:
- Warsong Gulch:
  * Fixed inverted worldstates of flags being sent to new players, wrong flag state was shown on UI

- Alterac Valley:
  * Fix Snowfall graveyard cap time as per Patch 2.3.0
  * Use proper gameobject entries for each node (blizzlike)
  * Removed magic numbers in favor of compile time consts (enum offsets etc)
  * More additional missing spawns (both creatures and gameobjects)

- Isle of Conquest:
  * Removed Transport pointers from class, instead store GUIDs and use HashMapHolder to access them
  * Fixed some wrong spawns which had Y coord set as X coord, Z as Y and Orientation as Z, fix a double spawn related to this
  * Additional cleanups of spawn code that checked if the spawn was correct only to then do a Get(spawntype) to manipulate it.
  * Incremented door close time to 30 seconds, as it is on sniff

- Strand of the Ancients:
  * Fixed sending timer to players that join with BG in progress
  * Corrected ships rotation as per sniff
  * Added missing seaforium bomb spawns
  * Implemented team switch logic to different spawn entries (like Titan Relic)
  * Implemented changing teleport locations depending on destroyed doors (Closes #12127)

ariel- added a commit that referenced this issue Sep 3, 2016

[WiP] Core/PvP: Extensive cleanup, bug-fixing and optimization of Bat…
…tleground scripts:

- Standards: Moved all statics to cpps where they belong.
- Cleanups: NULL -> nullptr, moved #defines to constants/enums
- Added a helper struct for handling spawns easily. Rewrote spawns using it.
- Moved spawn containers to private scope of Battleground (idea taken from boss states array in InstanceScripts)
- Remove unused teamId parameter from Battleground::SpawnCreature
- Prevent Battleground::RelocateDeadPlayers creating new entries on map.
- Make AddObject return a GameObject pointer instead of a bool (just like its AddCreature sibling)
- Corrected and added proper GO rotation to spawns
- De-hardcode buff entries for Battlegrounds, each BG uses their own entries (blizzlike).
- Moved logs from incorrect logger "sql.sql" to "bg.battleground"

Additional Notes for some BGs:
- Warsong Gulch:
  * Fixed inverted worldstates of flags being sent to new players, wrong flag state was shown on UI

- Alterac Valley:
  * Fix Snowfall graveyard cap time as per Patch 2.3.0
  * Use proper gameobject entries for each node (blizzlike)
  * Removed magic numbers in favor of compile time consts (enum offsets etc)
  * More additional missing spawns (both creatures and gameobjects)

- Isle of Conquest:
  * Removed Transport pointers from class, instead store GUIDs and use HashMapHolder to access them
  * Fixed some wrong spawns which had Y coord set as X coord, Z as Y and Orientation as Z, fix a double spawn related to this
  * Additional cleanups of spawn code that checked if the spawn was correct only to then do a Get(spawntype) to manipulate it.
  * Incremented door close time to 30 seconds, as it is on sniff

- Strand of the Ancients:
  * Fixed sending timer to players that join with BG in progress
  * Corrected ships rotation as per sniff
  * Added missing seaforium bomb spawns
  * Implemented team switch logic to different spawn entries (like Titan Relic)
  * Implemented changing teleport locations depending on destroyed doors (Closes #12127)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.