Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[BUG]visual bug about drink and food #12567

Open
kldxzzhc2 opened this Issue Jul 19, 2014 · 15 comments

Comments

Projects
None yet
7 participants

db : up-to-date
core : 5d5cbf0

when player drink and food, there should be a cup or food in hands until you finish the action, at times player will do drink or eat action.
In trinitycore, the cup and food will soon disapear, and player do nothing.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Can someone give a generic direction? I traced the code, but get no progress.

anything news?

@Aokromes Aokromes added this to the 3.3.5a cosmetic milestone Aug 28, 2014

Hi, guys anything news for this?
Or someone tell me how to control player's emote when he cast a spell

Contributor

Rushor commented Sep 2, 2014

probably you can find some hints in the mangos-code. there all these emotes work 'perfect' :D

thanks I will trace the mangos code, maybe we can fix a serial issues about emote
Can you tell me the address of the mangos code?

Contributor

Rushor commented Sep 2, 2014

on the bc one (https://github.com/mangosone/) it works (tested this 3 weeks ago), but i have no idea where they fixed it /trinity broke it.

I will trace the code, there must be some reason

So far, do not find the reason

Member

tkrokli commented Sep 5, 2014

TrinityCore rev. b7f5080 2014-09-04 22:50:26 -0300 (master branch) (Win64, Release)
TDB 355.55 + updates up to and including 2014_09_05_01_world_misc.sql .

Confirming that this happens: the drinking mug disappears after 6 seconds, even if the drinking time lasts 14-20 seconds (depending on item). Food item appears in the hands, but no movement at all. The player char sits with the food model in its lap and does no emote except bubbles and rays.
Sorry, but I don't know where to find the solution to this issue.

Yes, agree with @tkrokli

don't get any progress...

Member

tkrokli commented Sep 8, 2014

@kldxzzhc2 : This issue has priority "Cosmetic - (very very very low)" and will not be worked on before more important bugs are fixed (unless someone knows a solution directly and just writes a finished fix).

Member

Shauren commented Sep 8, 2014

Funny how this VERY IRRELEVANT ISSUE is the one that spams my notification inbox

Contributor

cr4st commented Sep 8, 2014

diff --git a/src/server/game/Entities/Player/Player.cpp b/src/server/game/Entities/Player/Player.cpp
index fa009d9..a96cbfe 100644
--- a/src/server/game/Entities/Player/Player.cpp
+++ b/src/server/game/Entities/Player/Player.cpp
@@ -2488,6 +2488,11 @@ void Player::RegenerateAll()
             HasAuraType(SPELL_AURA_MOD_REGEN_DURING_COMBAT) ||
             HasAuraType(SPELL_AURA_MOD_HEALTH_REGEN_IN_COMBAT))
         {
+            AuraEffectList const& mTotalAuraList = GetAuraEffectsByType(SPELL_AURA_MOD_REGEN);
+            for (AuraEffectList::const_iterator itr = mTotalAuraList.begin(); itr != mTotalAuraList.end(); ++itr)
+                if ((*itr)->GetSpellInfo()->AuraInterruptFlags & AURA_INTERRUPT_FLAG_NOT_SEATED)
+                    HandleEmoteCommand(EMOTE_ONESHOT_EAT);
+
             RegenerateHealth();
         }

Here would be a possible hackfix for visual food but not drink. Maybe it will help you more... and sorry for notification. xD

thanks a lot ~
I can make the player play emote while drink or food, but I don't know why the cup will disappear after drink for a few seconds

@DDuarte DDuarte modified the milestone: Cosmetic Mar 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment