Replace map extractors with StormLib #12576

Closed
DDuarte opened this Issue Jul 19, 2014 · 6 comments

Comments

Projects
None yet
3 participants
@DDuarte
Member

DDuarte commented Jul 19, 2014

StormLib is already used in the 4.3.4 branch. Changing master extractors to StormLib would reduce the code differences between both branches and, probably, the StormLib is faster and more robust than master extractors

Core a59ec8c

@DDuarte

This comment has been minimized.

Show comment
Hide comment
@DDuarte

DDuarte Jul 19, 2014

Member

By @Aokromes:

Now we are looking for someone to convert the extractor of wow 3.3.5a from libmpq to StormLIB, the reason of this is that libmpq is not longer maintained and having the same extractor on all branches will ease merges between branches, the best idea is to allow the extractor extract wow 3.3.5a, 4.3.4 and 5.4.8 on all possible locales.

Member

DDuarte commented Jul 19, 2014

By @Aokromes:

Now we are looking for someone to convert the extractor of wow 3.3.5a from libmpq to StormLIB, the reason of this is that libmpq is not longer maintained and having the same extractor on all branches will ease merges between branches, the best idea is to allow the extractor extract wow 3.3.5a, 4.3.4 and 5.4.8 on all possible locales.

@MrSmite

This comment has been minimized.

Show comment
Hide comment
@MrSmite

MrSmite Jul 20, 2014

Contributor

This sounds like a good idea. Where do you get StormLIB and documentation?

Also, where did the 5.4.8 branch go?

Contributor

MrSmite commented Jul 20, 2014

This sounds like a good idea. Where do you get StormLIB and documentation?

Also, where did the 5.4.8 branch go?

@MrSmite

This comment has been minimized.

Show comment
Hide comment
@MrSmite

MrSmite Jul 20, 2014

Contributor

@Aokromes Thanks. By the way, in keeping my backup client up-to-date, is the 5.4.8 branch going to be for the base 5.4.8 or will Trinity require the hotfix?

I have a 5.4.7 client that I am planning on patching.

Contributor

MrSmite commented Jul 20, 2014

@Aokromes Thanks. By the way, in keeping my backup client up-to-date, is the 5.4.8 branch going to be for the base 5.4.8 or will Trinity require the hotfix?

I have a 5.4.7 client that I am planning on patching.

@Aokromes

This comment has been minimized.

Show comment
Hide comment
@Aokromes

Aokromes Jul 20, 2014

Member

Like allways, we will use the latest version available, and for now, that's 5.4.8

Member

Aokromes commented Jul 20, 2014

Like allways, we will use the latest version available, and for now, that's 5.4.8

@MrSmite

This comment has been minimized.

Show comment
Hide comment
@MrSmite

MrSmite Jul 21, 2014

Contributor

Like allways, we will use the latest version available, and for now, that's 5.4.8

Ok, thanks. I wasn't sure if you guys were going to freeze it at a specific revision like we did with 335 and 434.

Contributor

MrSmite commented Jul 21, 2014

Like allways, we will use the latest version available, and for now, that's 5.4.8

Ok, thanks. I wasn't sure if you guys were going to freeze it at a specific revision like we did with 335 and 434.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment