New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.3.5a] Val'kyr Shadowguard are not spawning (25man) #15048

Closed
ghost opened this Issue Jul 10, 2015 · 13 comments

Comments

Projects
None yet
7 participants
@ghost

ghost commented Jul 10, 2015

Not tested on 25 HC, only on NORM.

b574c99

They're just not spawning, no idea why.

@Keader

This comment has been minimized.

Show comment
Hide comment
@Keader

Keader Jul 10, 2015

Member

On Lich King 25 hc not spawning too.

Member

Keader commented Jul 10, 2015

On Lich King 25 hc not spawning too.

@Rushor

This comment has been minimized.

Show comment
Hide comment
@Rushor

Rushor Jul 10, 2015

Contributor

you tested this with >5 people?

Contributor

Rushor commented Jul 10, 2015

you tested this with >5 people?

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jul 10, 2015

They aren't spawning for me either.

ghost commented Jul 10, 2015

They aren't spawning for me either.

@ghost ghost removed the Invalid-CannotReproduce label Jul 10, 2015

@Keader

This comment has been minimized.

Show comment
Hide comment
@Keader

Keader Jul 10, 2015

Member

@Rushor Until about four months ago they appeared even with one person in the raid.

Member

Keader commented Jul 10, 2015

@Rushor Until about four months ago they appeared even with one person in the raid.

@Pirricli

This comment has been minimized.

Show comment
Hide comment
@Pirricli

Pirricli Jul 10, 2015

Contributor

confirm on b4a293f

Contributor

Pirricli commented Jul 10, 2015

confirm on b4a293f

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jul 10, 2015

Tested 3234 times with 25 players in a raid. They are not spawning. LK says: VALKYR BLAH BLAH and nothing happens.

ghost commented Jul 10, 2015

Tested 3234 times with 25 players in a raid. They are not spawning. LK says: VALKYR BLAH BLAH and nothing happens.

@Frytiks

This comment has been minimized.

Show comment
Hide comment
@Frytiks

Frytiks Jul 11, 2015

I'm pretty sure it's cause so much latest DB updates. Somewhere is fuckup.

Frytiks commented Jul 11, 2015

I'm pretty sure it's cause so much latest DB updates. Somewhere is fuckup.

@Frytiks

This comment has been minimized.

Show comment
Hide comment
@Frytiks

Frytiks Jul 13, 2015

That bug is there more then 3 weeks

Frytiks commented Jul 13, 2015

That bug is there more then 3 weeks

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jul 13, 2015

Also doing some testing, this is a hard one.

ghost commented Jul 13, 2015

Also doing some testing, this is a hard one.

@Keader

This comment has been minimized.

Show comment
Hide comment
@Keader

Keader Jan 20, 2016

Member
diff --git a/src/server/scripts/Northrend/IcecrownCitadel/boss_the_lich_king.cpp b/src/server/scripts/Northrend/IcecrownCitadel/boss_the_lich_king.cpp
index 755bbd7..c861450 100644
--- a/src/server/scripts/Northrend/IcecrownCitadel/boss_the_lich_king.cpp
+++ b/src/server/scripts/Northrend/IcecrownCitadel/boss_the_lich_king.cpp
@@ -1005,7 +1005,7 @@ class boss_the_lich_king : public CreatureScript
                         case EVENT_SUMMON_VALKYR:
                             me->GetMap()->SetZoneMusic(AREA_THE_FROZEN_THRONE, MUSIC_SPECIAL);
                             Talk(SAY_LK_SUMMON_VALKYR);
-                            DoCastAOE(SUMMON_VALKYR);
+                            DoCastAOE(SUMMON_VALKYR,true);
                             events.ScheduleEvent(EVENT_SUMMON_VALKYR, urand(45000, 50000), 0, PHASE_TWO);
                             break;
                         case EVENT_START_ATTACK:

Use this, work 🎯
@declart @Demonid

Member

Keader commented Jan 20, 2016

diff --git a/src/server/scripts/Northrend/IcecrownCitadel/boss_the_lich_king.cpp b/src/server/scripts/Northrend/IcecrownCitadel/boss_the_lich_king.cpp
index 755bbd7..c861450 100644
--- a/src/server/scripts/Northrend/IcecrownCitadel/boss_the_lich_king.cpp
+++ b/src/server/scripts/Northrend/IcecrownCitadel/boss_the_lich_king.cpp
@@ -1005,7 +1005,7 @@ class boss_the_lich_king : public CreatureScript
                         case EVENT_SUMMON_VALKYR:
                             me->GetMap()->SetZoneMusic(AREA_THE_FROZEN_THRONE, MUSIC_SPECIAL);
                             Talk(SAY_LK_SUMMON_VALKYR);
-                            DoCastAOE(SUMMON_VALKYR);
+                            DoCastAOE(SUMMON_VALKYR,true);
                             events.ScheduleEvent(EVENT_SUMMON_VALKYR, urand(45000, 50000), 0, PHASE_TWO);
                             break;
                         case EVENT_START_ATTACK:

Use this, work 🎯
@declart @Demonid

@Kittnz

This comment has been minimized.

Show comment
Hide comment
@Kittnz

Kittnz Jan 20, 2016

Member

PR it please =)

Member

Kittnz commented Jan 20, 2016

PR it please =)

@Keader

This comment has been minimized.

Show comment
Hide comment
@Keader

Keader Jan 20, 2016

Member

@Kittnz I believe this will be fixed by #16322

Member

Keader commented Jan 20, 2016

@Kittnz I believe this will be fixed by #16322

@Demonid

This comment has been minimized.

Show comment
Hide comment
@Demonid

Demonid Jan 20, 2016

@Keader Already was using it, it works but it's a hackfix i guess.

Demonid commented Jan 20, 2016

@Keader Already was using it, it works but it's a hackfix i guess.

@Shauren Shauren closed this in 044edce Jan 22, 2016

Shauren added a commit that referenced this issue Jan 22, 2016

Core/Spells: Ignore category cooldowns for triggered spells.
* This fixes weird issues where triggered spell fails because it has the same category as the spell triggering it

Closes #15794
Closes #15048

(cherry picked from commit 044edce)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment