Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Crash] Player::LoadFromDB #15633

Closed
Pirricli opened this issue Sep 29, 2015 · 5 comments
Closed

[Crash] Player::LoadFromDB #15633

Pirricli opened this issue Sep 29, 2015 · 5 comments

Comments

@Pirricli
Copy link
Contributor

Recently I had this crashlog.

http://pastebin.com/fH4QtigW

fcc6ef6
3.3.5
@shenhuyong
Copy link

Comfirmed
3.3.5
70a5cdf

@Carbenium
Copy link
Member

@shenhuyong : Crashlog or nothing happened.

@Shauren
Copy link
Member

Shauren commented Sep 29, 2015

note for debugging: Player logged out/in on the gunship inside ICC

@jackpoz jackpoz mentioned this issue Sep 29, 2015
Open
6 tasks
@jackpoz
Copy link
Member

jackpoz commented Sep 29, 2015

https://gist.github.com/jackpoz/80c03fa078cad41ae4a2 valgrind log

@r00ty-tc
Copy link
Contributor

Just for useful information. Steps to reproduce are as follows:

  • Set config option Instance.UnloadDelay = 1
  • Enter ICC, kill first 2 bosses and head to Lootship Gunship.
  • Start event and as soon as ship starts to move logout.
  • Wait a second, map will unload.
  • log back in and observe the crashed worldserver.

Issue is that transport object is unloaded but pointer remains in hashmap and old guid is stored in player record. Hence it finds the old guid in the hashmap pointing to invalid memory area.

This was referenced Sep 29, 2015
Closed
Closed
@imbavirus imbavirus mentioned this issue Sep 29, 2015
Merged
@TrinityCoreBot TrinityCoreBot mentioned this issue Sep 30, 2015
Closed
Shauren added a commit that referenced this issue Sep 30, 2015
@Shauren @jackpoz
Core/Transports: Fixed accessing deleted instance transports
3253361 
Thanks @jackpoz for valgrind log and @pete318 for reproduction steps

Closes #15633

(cherry picked from commit 8745e08)
FrancescoBorzi pushed a commit to FrancescoBorzi/TrinityCore that referenced this issue Oct 8, 2015
@Shauren @FrancescoBorzi
Core/Transports: Fixed accessing deleted instance transports
7e87fb6 
Thanks @jackpoz for valgrind log and @pete318 for reproduction steps

Closes TrinityCore#15633

(cherry picked from commit 8745e08)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@r00ty-tc @Shauren @jackpoz @Pirricli @Carbenium @shenhuyong