Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.3.5] Object - Defias Gunpowder - Acquisition should spawn attacker #16374

Closed
XaveT opened this issue Jan 24, 2016 · 6 comments
Closed

[3.3.5] Object - Defias Gunpowder - Acquisition should spawn attacker #16374

XaveT opened this issue Jan 24, 2016 · 6 comments

Comments

@XaveT
Copy link

XaveT commented Jan 24, 2016

TrinityCore rev. 3f88602 2016-01-22 22:14:28 +0100 (3.3.5 branch) (Unix, Release)

The Defias Gunpowder object (# 17155) in Deadmines instance should spawn an Elite Defias Overseer (would link, but wowhead doesn't have the old version anymore, "new" NPC is http://www.wowhead.com/npc=48421/defias-overseer) with agro on the person who picked up the powder. From retail days, you wouldn't even always get the item before the first shot would hit you.

@XaveT
Copy link
Author

XaveT commented Jan 24, 2016

Not the right NPC. It should spawn an Elite Defias Taskmaster instead. NPC #4417
(to self: Read your notes when you do the write ups... SMH)

@Rushor
Copy link
Contributor

Rushor commented Jan 24, 2016

-- Defias Gunpowder SAI
SET @ENTRY := 17155;
UPDATE `gameobject_template` SET `AIName`="SmartGameObjectAI" WHERE `entry`=@ENTRY;
DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=1;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(@ENTRY,1,0,0,70,0,100,0,2,0,0,0,12,4417,3,120000,1,0,0,8,0,0,0,-123.77,-613.586,14.126,6.035,"Defias Gunpowder - On Gossip Hello - Summon Creature 'Defias Taskmaster' (No Repeat)");

@XaveT
Copy link
Author

XaveT commented Jan 27, 2016

This fix is perfect.

@Rushor Rushor changed the title Object - Defias Gunpowder - Acquisition should spawn attacker [3.3.5] Object - Defias Gunpowder - Acquisition should spawn attacker Feb 2, 2016
@XaveT
Copy link
Author

XaveT commented Feb 3, 2016

Since this fixes my problem, what do I need to do to get it merged into the build? (I'm new to this concept on github, but I'd like to help. Is there a sticky somewhere I've missed?)

@Kittnz
Copy link
Member

Kittnz commented Feb 3, 2016

Someone needs to push it, @Rushor since it's your fix, can you push it?

@Rushor
Copy link
Contributor

Rushor commented Feb 3, 2016

maybe tomorrow ~4 pm

@Rushor Rushor self-assigned this Feb 5, 2016
Rushor added a commit that referenced this issue Feb 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants