Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash #17664

Closed
MrWorld opened this issue Jul 26, 2016 · 2 comments
Closed

Crash #17664

MrWorld opened this issue Jul 26, 2016 · 2 comments

Comments

@MrWorld
Copy link

MrWorld commented Jul 26, 2016

Description: New Crash

Branch(es): 3.3.5

TC hash/commit: after b008b67

TDB version: 61

Operating system: Win

https://gist.github.com/MrWorld/da174fbee6caaa37fa27f7fff1be6d0a

@jackpoz
Copy link
Member

jackpoz commented Jul 26, 2016

I see a lot of 0xDDDDDDDD around, in particular in m_groupInvite.
Also Group::RemoveInvite() has "this" with a lot of 0xDDDDDDDD, it's like if the group got deleted while removing the invite.

@MrWorld
Copy link
Author

MrWorld commented Jul 26, 2016

and Some user have edited WowAddin Project ,so see this packets

ClientToServer: CMSG_CONTACT_LIST (0x0066) Length: 4 ConnIdx: 0 EP: xx.xx.xxx.xx:27957 Time: 07/23/2016 11:40:27.659 Number: 41072
List Flags?: Unknown1 (1)

ClientToServer: CMSG_CONTACT_LIST (0x0066) Length: 4 ConnIdx: 0 EP: xx.xx.xxx.xx:27957 Time: 07/23/2016 11:40:27.659 Number: 41073
List Flags?: Unknown1 (1)

ClientToServer: CMSG_CONTACT_LIST (0x0066) Length: 4 ConnIdx: 0 EP: xx.xx.xxx.xx:27957 Time: 07/23/2016 11:40:27.660 Number: 41074
List Flags?: Unknown1 (1)

ClientToServer: CMSG_CONTACT_LIST (0x0066) Length: 4 ConnIdx: 0 EP: xx.xx.xxx.xx:27957 Time: 07/23/2016 11:40:27.661 Number: 41075
List Flags?: Unknown1 (1)

ClientToServer: CMSG_CONTACT_LIST (0x0066) Length: 4 ConnIdx: 0 EP: xx.xx.xxx.xx:27957 Time: 07/23/2016 11:40:27.662 Number: 41076
List Flags?: Unknown1 (1)

ClientToServer: CMSG_CONTACT_LIST (0x0066) Length: 4 ConnIdx: 0 EP: xx.xx.xxx.xx:27957 Time: 07/23/2016 11:40:27.663 Number: 41077
List Flags?: Unknown1 (1)

ClientToServer: CMSG_CONTACT_LIST (0x0066) Length: 4 ConnIdx: 0 EP: xx.xx.xxx.xx:27957 Time: 07/23/2016 11:40:27.664 Number: 41078
List Flags?: Unknown1 (1)

client send 41078 CMSG_CONTACT_LIST to server .
any way to fix this Crash ?

jackpoz added a commit that referenced this issue Aug 1, 2016
Do not allow a player to invite himself in group.
Fix an edge case when inviting another player that would cause a crash.
Fix #17664
Aokromes pushed a commit to Aokromes/TrinityCore that referenced this issue Aug 3, 2016
Do not allow a player to invite himself in group.
Fix an edge case when inviting another player that would cause a crash.
Fix TrinityCore#17664
joschiwald pushed a commit that referenced this issue Feb 11, 2017
Do not allow a player to invite himself in group.
Fix an edge case when inviting another player that would cause a crash.
Fix #17664

(cherry picked from commit bcfa47c)
Krudor pushed a commit to Krudor/TrinityCore that referenced this issue Jul 13, 2017
Do not allow a player to invite himself in group.
Fix an edge case when inviting another player that would cause a crash.
Fix TrinityCore#17664

(cherry picked from commit bcfa47c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants