Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: GameObject Orientation #17891

Closed
Killyana opened this Issue Sep 3, 2016 · 0 comments

Comments

Projects
None yet
3 participants
@Killyana
Copy link
Member

commented Sep 3, 2016

If you .add gob the object added must take character's orientation, same thing if you cast a spell that summon a gob, After the recent changes orientation is always 0
If you summon a gob using SAI target type=8 the orientation is also always 0

Current behaviour: Gobs summoned by spell or SAI (taget type=8) or .gob add is always=0

Expected behaviour: Gobs summoned by spells or .gob add must take invoker's orientation also gobs summoned by SAI must use the orientation specified on (target type=8)

Steps to reproduce the problem:

  1. .gob add 194541 many time when you change orientation
  2. cast any spell that summon a gob many times when you change orientation
  3. I cannot find a fast sai that summon a gob using target 8 but I confirm the issue exist

Branch(es): 3.3.5 / 6.x (Select the branch(es) affected by this issue)

TC hash/commit: rev. be8d113

TDB version: 3.3.5

@ariel- ariel- added the Sub-Entities label Sep 3, 2016

ariel- added a commit that referenced this issue Sep 3, 2016

Core/Misc: calculate rotation fields from orientation in some places …
…it's impossible to get:

- SmartScripts: SMART_ACTION_SUMMON_GO
- Spell Effects:
  * SPELL_EFFECT_DUEL
  * SPELL_EFFECT_SUMMON_OBJECT_WILD
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT1
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT2
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT3
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT4
- Command Scripts: .gobject add

Closes #17891

joschiwald added a commit that referenced this issue Feb 19, 2017

Core/Misc: calculate rotation fields from orientation in some places …
…it's impossible to get:

- SmartScripts: SMART_ACTION_SUMMON_GO
- Spell Effects:
  * SPELL_EFFECT_DUEL
  * SPELL_EFFECT_SUMMON_OBJECT_WILD
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT1
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT2
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT3
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT4
- Command Scripts: .gobject add

Closes #17891

(cherry picked from commit 14445d2)

conan513 pushed a commit to conan513/SingleCore_TC that referenced this issue Mar 13, 2017

Core/Misc: calculate rotation fields from orientation in some places …
…it's impossible to get:

- SmartScripts: SMART_ACTION_SUMMON_GO
- Spell Effects:
  * SPELL_EFFECT_DUEL
  * SPELL_EFFECT_SUMMON_OBJECT_WILD
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT1
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT2
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT3
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT4
- Command Scripts: .gobject add

Closes TrinityCore#17891

(cherry picked from commit 14445d2)

Krudor added a commit to Krudor/TrinityCore that referenced this issue Jul 13, 2017

Core/Misc: calculate rotation fields from orientation in some places …
…it's impossible to get:

- SmartScripts: SMART_ACTION_SUMMON_GO
- Spell Effects:
  * SPELL_EFFECT_DUEL
  * SPELL_EFFECT_SUMMON_OBJECT_WILD
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT1
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT2
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT3
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT4
- Command Scripts: .gobject add

Closes TrinityCore#17891

(cherry picked from commit 14445d2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.