[master] Core/Group error. #18757

Closed
Edreisantafe opened this Issue Jan 7, 2017 · 0 comments

Projects

None yet

3 participants

@Edreisantafe
Edreisantafe commented Jan 7, 2017 edited

Description: Problem when you are leader of group/raid and you try to leave the group.

Current behaviour: (Tell us what happens.)
When you create a group/raid of 3 or more people when you try to leave the group/raid with the option of leave group, you are leaving the group but in the screen the group panel is not dismissing until you log out and log in

Expected behaviour: (Tell us what should happen instead.)
When you create a group/raid and you select the option of leave the group/raid you have to leave the group without log out and log in

Steps to reproduce the problem:

  1. Create a group of 3 people or more
  2. Try to leave the group
  3. log out and log in

Branch(es): 3.3.5 / master (Tell us which branch(es) this issue affects.)
master

TC rev. hash/commit: a82488a

TDB version: 7.0.3+updates

Operating system:

@Shauren Shauren closed this Jan 7, 2017
@Shauren Shauren reopened this Jan 7, 2017
@Shauren Shauren closed this in d2c77d8 Jan 10, 2017
@LuigiElleBalotta LuigiElleBalotta added a commit to LuigiElleBalotta/TrinityCore that referenced this issue Jan 12, 2017
@LuigiElleBalotta LuigiElleBalotta Merge (#3)
* Tools/Patcher: Maybe fix mac

Ref #18145

* Core/Chat: Updated item link format

* DB/SAI: Redridge Mountains

* Core/Logging: Fix static analysis issue

CID 1367942, 1367944, 1367953,1367955,1367957, 1367958, 1367960, 1367961, 1367962, 1367964

* DB/SAI: Hillsbrad Foothills

By cooler-SAI

* DB: Rename file

* DB/SAI: Western Plaguelands

By cooler-SAI

* DB/SAI: Shimmering Expanse

By cooler-SAI

* DB/SAI: The Cape of Stranglethorn

By cooler-SAI

* Core/Units: Update druid shapeshift form models (#18554)

* Update README.md (#18572)

* Update README.md

Updated some link's as well as the formatting. Synced the structure with the 3.3.5 branch readme.md file.

* Use trinitycore.info instead of trinitycore.atlassian.net.

* Core/Players: Added new 7.1 hidden slots transmog items

* Core/Items: Implemented bonus list as a possible result of RandomSuffix

Ref #18423

* Core/Loot: Fixed group loot

Closes #17696

* Core/Misc: fixed compile warning

* Core/Loot: Implemented AoE loot

Closes #16065

* Build fix

* Core/Items: Fixed applying artifact powers scaling with number of purchased ranks (+stamina/+damage)

Closes #18644

* Dep: Update fmt (cppformat) to 3.0.1 fmtlib/fmt@7fa8f8f

Also renamed cppformat to fmt

* TravisCI: Clang 3.9

* Build/Clang: Suppress -Wexpansion-to-defined because of rapidjson dep

https://travis-ci.org/TrinityCore/TrinityCore/builds/187588737#L985-L995

* Core/PacketIO: Fixed SMSG_TRADE_UPDATED structure

Closes #18652

* Core/Loot: Increased allowed loot range and updated SendLootError

Closes #18685

* Build fix

* Core/Spells: SPELL_ATTR0_CU_SHARE_DAMAGE no longer depend on SpellFamily

* Core/Scripting: Added missing hotswap code for SceneScripts

* Update copyright note for 2017
Happy new year

* Core/Entities: fixed array size

Core/Misc: fixed compile warning

* Dep: Update rapidjson to v1.1.0

* Revert "Build/Clang: Suppress -Wexpansion-to-defined because of rapidjson dep"

This reverts commit 467e49c.

* TravisCI: Rollback to using current Clang on Travis VMs

Change from Clang 3.9 to 3.5 (current version available).

3.9 was shown to take longer than 3.5 and having random segfaults here and there.

* Core/SpellScripts: Added some const correctness

* Core/PacketIO: Fixed value sent in SMSG_SET_PCT_SPELL_MODIFIER

* Core/Spells: Fixed SPELLMOD_PCT calculation

Closes #18726

* Core/Misc: Warning fixes

* Core/Spells: Extended remaining 8bit EffectMasks to 32bit

* Core/PacketIO: Fixed leaving group not fully removing it clientside

Closes #18744

* DB/Quest: A Lesson in Fear

Properly script http://www.wowhead.com/quest=11282/a-lesson-in-fear#comments so that you actually have to kill Winterskorn Defenders to get the named npcs to spawn, added missing texts for the yell for when they spawn
(cherry picked from commit 2640f37)

* DB/Quest: Blast the Gateway

Closes #2548

(cherry picked from commit 79df25e)

* DB/Creature: Steam Pump Overseer

Closes #16840

(cherry picked from commit e70cdca)

* DB/Creature: Shadowmoon Zealot

Respawn http://www.wowhead.com/npc=21788/shadowmoon-zealot as noticed we were missing quiet a few of these.
(cherry picked from commit 61999b1)

* DB/Creature: add few missing flag_extra
(cherry picked from commit f9582ed)

* DB/Creature: Shadowmoon Harbringer

Same as with Zealots (we were missing a lot of spawns)
(cherry picked from commit 30db032)

* DB/Creature: Dark Iron Land Mines

By adeutscher
Closes #17019

(cherry picked from commit b641d7b)

* DB/Pathing:

Full paths for : -

http://www.wowhead.com/npc=24516/bjomolf
http://www.wowhead.com/npc=24517/varg
http://www.wowhead.com/npc=24277/garwal
(cherry picked from commit b82ffb8)

* DB/Script: The Etymidian

Fix Meeting a Great One quest

(cherry picked from commit e130593)

* DB/Quest: The Drakkensryd

Closes #1350
by Txknight

(cherry picked from commit b3a26fc)

* DB/Creature: Add accessory to Frigid Proto-Drake

(cherry picked from commit 17e661f)

* DB/Quest: A Rough Ride

Waypoints again since have more experience and had a lot more wp than needed previously
A couple of cosmetic fixes for this quest
(cherry picked from commit 732ec94)

* DB/SAI: Sholazar Guardians (Summoning on quest accept)

When you accept quest where you receive item to summon Goregek, Dajik, Zepik, Lafoo, Jaloot or Moodle the guardian for which player just received item is also summoned automatically.
(cherry picked from commit 4a85b65)

* Scripts/Icecrown Citadel: Sindragosa - Ice Tomb should always deal damage to all other ice tombs too

Closes #7808
Merges #16863

* DB/Misc: The Maker's Overlook

* Respawn all http://www.wowhead.com/npc=28069/sholazar-guardian and add pathing for the 3 with paths
* Spawn missing http://www.wowhead.com/npc=28840/overlook-sentry and pathing
* Correct inhabitat flags for http://www.wowhead.com/npc=29066/titan-sentry
(cherry picked from commit d6c05c5)

* DB/Event: Children's week

Add missing reward mail when either version of Return to the Orphanage in Shattrath is returned

Horde (185) - Subject: Thank you!  Body: Dear, $n,$B$BThank you for taking me out during Children's Week. Lady Liadrin, the leader of the Blood Knights, has asked that I be released to her custody for training in Silvermoon City!$B$BI just wanted to thank you for taking me to see my friend, Hch'uu, as well as the Dark Portal, the Throne of the Elements, and the Caverns of Time. I like my toy dragon very much!$B$BI'm sure that you're taking good care of my pet. Please tell him that I miss him!$B$BSincerely,$B$BSalandria
Alliance (184) - Subject: Thank you!  Body: $n,$B$BThank you for the time that we spent together during Children's Week. Did you know that Farseer Nobundo has asked the orphan matron to allow me to study with him at the Exodar?$B$BThank you for taking me to all of those neat places, and to visit my brother, Jheel. I miss him almost as much as I miss you. And, the Ring of Observance, the Dark Portal and the Caverns of Time were neato!$B$BI'm sure that you're taking good care of my pet. Tell him that I miss him, too!$B$BLove,$B$BDornaa
(cherry picked from commit e4a22f9)

Actually add the sql to last commit
(cherry picked from commit 9566b94)

* DB/Creature: Flamebringer

Some corrections to previous script from sniff.
(cherry picked from commit 769b7ff)

* CreatureAI: Adjust AI behavior when a charm ends. OnCharmed will be invoked on the creature's base (non-charmed) AI, allowing the AI to react to the creature no longer being charmed.

(cherry picked from commit 26b084a)

align fix
(cherry picked from commit 58486fc)

* Entities/Unit: Finally fix no-path evasion.

- When a creature cannot find a path to its victim, it begins evading all attacks and regenerating health.
- If this persists for 5 seconds, it evades back to spawn position with new EvadeReason value EVADE_REASON_NO_PATH.
- Also some SmartAI cleanup (why oh why does it have so much duplicated code) and getting rid of #defines in favor of type-checked compile-time constants.

(cherry picked from commit 7b1560f)

* DB/SAI: Rejek (Part 1)

Turn in event for http://www.wowhead.com/quest=12758/a-heros-headgear
(cherry picked from commit 5668bc3)

* Core/Spells: fix console spam (#17084)
(cherry picked from commit 8d09065)

* Core/Movement: Do not launch pathfinding for splines turning on the spot

(cherry picked from commit 66006e3)

* DB/Creature: fix Orgrimmar Grunt console spam

By Ariel-, closes #17083
(cherry picked from commit 945abb1)

* DB/SAI: Rejek (Part 2)

* Turn in event for http://www.wowhead.com/quest=12732/the-heartbloods-strength
* Remove previous hack for chicken net which is no longer needed
* Fix Jaina again - closes #17087
(cherry picked from commit d9dcbbc)

* Core/Auras: SPELL_AURA_PERIODIC_LEECH can now properly overkill

(cherry picked from commit 3d8bab8)

* DB/Creature: Soo-holu & Kartak the Abominable

* Corrections to vehicle id and spells (Soo-holu previously had vehicleid 134 in sniff both are 257)
* Move spell focus for summoning Soo-holu with http://www.wowhead.com/item=39266/tainted-crystal to correct place
* On summon texts for when summoned
* Add some broadcasttext ids I forgot to add in my last commit.
(cherry picked from commit c42f0bd)

* Core/Random: Removed ancient and unused MAP_BASED_RAND_GEN

(cherry picked from commit 1ad02a0)

* Core/Spells: Fix wrong totem placement

(cherry picked from commit 37b2f59)

* Implement Quest Riding the Red Rocket
(cherry picked from commit 20b3feb)

Fix SQL name
(cherry picked from commit 2329648)

* Core/Battleground Script for Isle of Conquest Bosses

by @gerripeach
(cherry picked from commit c1ed002)

SQL file name fix
(cherry picked from commit 74f3a84)

* Script/SWP Full Rework on M'uru Encounter

(cherry picked from commit 6002acf)

Another sql fix
(cherry picked from commit 204acbb)

* Core/Auras: Renamed fields of SpellProcEntry structure and change types to more appropriate ones

(cherry picked from commit ef7df65)

Build fix
(cherry picked from commit c03e7ec)

SQL fix
(cherry picked from commit 7a41467)

* Creature/CreatureAI:

- Default range for DoZoneInCombat: 50.0f -> 250.0f.
- Add optional second arg to SummonList::DoZoneInCombat to specify range.
- Also a bunch of random NULL -> nullptr cleanup.

(cherry picked from commit b7f2c87)

Too many damn stars in that damn argument list.
(cherry picked from commit afbda04)

* Core/AI: Add DoCastSelf helper.

(I have no idea why I never bothered to do this before, really. It had crossed my mind a few times.)

(cherry picked from commit ab0abdb)

This discussion is more effort than it takes to change it.
(cherry picked from commit b52a6b8)

* DB/Gameobject: Add 2 missing spawns

By Girib Dragos

* Rename 2017_01_08_00_world.sql to 2017_01_08_04_world.sql

* Core/Scripts: Added reasonable default params to GetCreatureListWithEntryInGrid/GetGameObjectListWithEntryInGrid for ease of use. Also, entry = 0 means no filter now, since we lacked an easy way to get a list of all creatures in grid.

(cherry picked from commit 0d5adf3)

* Allow BossAI::_DespawnAtEvade to work on creatures other than the boss itself (optional argument).

(cherry picked from commit 6040e30)

* Core/Movement: Fix issues where creatures cancel spell casts chasing target and Implement SPELL_ATTR5_CAN_CHANNEL_WHEN_MOVING

(cherry picked from commit bf2cee8)

* Add a LOG_WARN when attempting to summon a non-existing summon group.
(cherry picked from commit 4d4d2f5)

Seriously, who doesn't support std::string instead of char* in 2016?
(cherry picked from commit a012b37)

* Core/Unit: Pet shouldn't be notified for DOT damage on the owner (#17133)

- Fix by @MrSmite
- Closes #16894
(cherry picked from commit 4de1426)

* Core/Quests: Fixed issue reported by static analysis

Coverity defect ID: 1355241

(cherry picked from commit a01fd52)

* Core/Spells Make certain spells (e.g. Mind Control) properly flag the caster for PvP (#17145)

* This issue was caused by PvP-flagging being done calculated after the target's flag was turned off by becoming a pet.

(cherry picked from commit e7a12ed)

* Core/Spells: Proc handler script converions (#17122)

* Blazing Speed (Mage)
* Blessed Recovery (Priest)
* Druid Forms Trinket
* Idol Of Mutilation
* Nature's Guardian (Shaman)
* Nether Protection (Warlock)
* Piercing Shots and Bonus 4P T9 Hunter
* Lightning Shield (Shaman)
* Acclimation (DK)
* Move DK T10 4P Melee Bonus
* Move DK Improved Blood Presence triggered heal (DK)
* Rogue T10 2P Bonus
* Illumination (Paladin)
* Soul Preserver
* Death Choice trinket
* stack trinket scripts (ToC25 Caster Trinket, Lightning Capacitor, Thunder Capacitor)
* Battle Experience (ICC - Gunship)
* Blood Reserve (enchant proc)
* Darkmoon Card Greatness
* Charm of the Amani Witch Doctor
* Mana Drain

(cherry picked from commit 5b8e68e)

* Core/Auras: Fixed cooldowns for procs calling PreventDefaultAction() in aura proc script

* This also fixes proc cooldows unneccessarily being sent to client
* Also removes the need for cooldown hacks when the proc trigger is selected randomly like for Deathbringer's Will

(cherry picked from commit 1e1fcd6)

* Core/Chat: Don't check item suffix name when validating item links when the item has ITEM_FLAG3_HIDE_NAME_SUFFIX

* DB/Creature: Add missing creature spawns in Ghostlands & Eversong Woods

Added the following NPC's : Toad, Snake, Frog, Lesser Scourgebat, Greater Spindleweb, Ghostclaw Ravager, Ghostclaw Lynx, Vampiric Mistbat, Whitetail Frenzy, Yellowgill Frenzy, Rabbit, Feral Dragonhawk Hatchling, Springpaw Stalker, Crazed Dragonhawk, Ghostlands Guardian, Spider

(cherry picked from commit 7c8c3b9)

* DB/Object: Add missing object spawns in Ghostlands & Eversong Woods

Bonfire, Cauldron & Campfire

(cherry picked from commit 7427ca5)

*  DB/trainers: Engineering trainers & spells

By clintskie

Updates #14682

* Conditions/ConditionMgr: Add a comment so MitchesD can go away.

(cherry picked from commit 759aae5)

* DB/Creature: Cabal Ritualists don't cast Crystal Channel

By Saben65, closes #16986
(cherry picked from commit b0f9a99)

* Core: updated creature type flags enum (#17128)

Core/Misc: Update CreatureTypeFlags enum according to TrinityCoreWiki
(cherry picked from commit fb08813)

# Conflicts:
#	src/server/game/AI/ScriptedAI/ScriptedEscortAI.cpp
#	src/server/game/AI/ScriptedAI/ScriptedFollowerAI.cpp
#	src/server/game/AI/SmartScripts/SmartAI.cpp
#	src/server/game/Entities/Unit/Unit.cpp
#	src/server/game/Miscellaneous/SharedDefines.h

* Core/Object: Use object edges to calculate LoS

(cherry picked from commit da6065d)

* Core/Spells: Implemented SPELL_ATTR1_DISMISS_PET

Closes #7372

(cherry picked from commit 9246189)

* Core/Loot: Fixed resaving looted items from containers

Closes #15299

(cherry picked from commit 4a074ca)

* DB/Creature: Clam Master K Waypoints

by Saben65

(cherry picked from commit 5536a96)

* Sorry, it's too late...

* DB/Creature: Pathing for Houndmaster Grebmar

by Kodekc

(cherry picked from commit 9e797e4)

* DB/Creature: Add flag guard Deathguard Elite

by Kodekc
Closes #17147

(cherry picked from commit 4f79114)

* DB/Creature: Add missing Ornery Plainstrider SAI

by Kodekc
Closes #17146

(cherry picked from commit c461e21)

* DB/Creature: Mebok Mizzyrix SAI

by tkrokli
Closes #17179

(cherry picked from commit 4ebed6e)

* DB/Gameobject: Spawn Rite of the Winds spellfocus

Updates #18262

* DB/Creature: Pathing Hinterlands

By Malcrom

* SQL: Fix import

* Merge pull request #17138 from ForesterDev/creature_family

Core/Misc: Define CREATURE_FAMILY_NONE to avoid magic numbers in code
(cherry picked from commit 62635f0)

* Core/Units: Renamed and documented UNIT_FLAG_DISABLE_MOVE to prevent people from trying to use this flag to root a creature leaving them wondering why it doesn't do anything

(cherry picked from commit b36da77)

Core/Scripts: build fix

(cherry picked from commit 258368a)

* DB/Creature: Add missing aura for Snorts

by Kodekc
Closes #17194

(cherry picked from commit bd13475)

* Core/Unit Do not allow addition of threat to units in evade mode

(cherry picked from commit 7d76900)

* Core/Achievement A-bomb-inable and A-bomb-ination
(cherry picked from commit e016bf8)

DB: SQL rename
(cherry picked from commit 71081c2)

* Core/Quests: Remove wrong call to SendQuestComplete(). (#17200)
(cherry picked from commit 9480a21)

* DB/Quest: Thwart the Dark Conclave

Closes #11791
(cherry picked from commit 80fc9cc)

* Revert "Merge pull request #16433 from Tonghost/3.3.5"

This reverts commit e3d5299, reversing
changes made to 6d8e39f.

Opens #16759

(cherry picked from commit 5aae019)

* DB/Quest: ExclusiveGroup for breadcrumb quests in Mudsprocket, Dustwallow Marsh

By SnapperRy, closes #17217
(cherry picked from commit ae6b3eb)

* DB/Spells: fix Searing Wrath's chain jump targeting

Ny SnapperRy closes #17216 closes #6671
(cherry picked from commit a5bd790)

* Fixed warning

* DB/Creature: More Hinterlands fixes

By Malcrom

* DB/Creature: Apothecary Surlis

By Malcrom

* Core/Groups: Send PartyUpdate to all players leaving group, not only on disband

Closes #18757

* Script/Taxi Sharpbeak Hinterlands

By Malcrom

* missing part of b3f2dd6

* Update zone_hinterlands.cpp

* DB/Creature: Fix some carts

By Malcrom

* DB/SAI: actually execute Technician Zhanaa's script on quest turn-in

Closes #17209 by SnapperRy
(cherry picked from commit 291a264)

* DB/Misc: Miscellenous Fixes

1) Fix http://www.wowhead.com/quest=1144/willix-the-importer so this quest does not complete as soon as taken so that players actually have to do the escort before been able to return quest
2) Remove XP at kill from several creatures which dont give xp on retail
3) Put alliance/horde versions of Reigns of the Grand War Mammoth (VOA) into seperate loot groups so chance for drop is actually 1% rather than been 1% chance of reference loot been called then been a 50/50 chance of which factions mount dropped which in fact reduced chance to 0.5% as if opposite factions dropped then not visible
4) Update to text target for one text from Rohin the Decaying
5) Move spell focus for http://www.wowhead.com/quest=12569/crocolisk-mastery-the-ambush so its on top of log and not behind it so position matches doing quest on retail
(cherry picked from commit f941dad)

* DB/Misc: Everfrost Chip

1) Remove required quest from loot tables for http://www.wowhead.com/item=44724/everfrost-chip , http://www.wowhead.com/item=44725/everfrost-chip and http://www.wowhead.com/item=44729/everfrost-powder so that everfrost chip is not always empty when looted since none of these items should require active quest to drop only that player is friendly with sons of hodir or has completed pre-quest in case of remember everfrost
2) Add missing quest data for http://www.wowhead.com/quest=13421/remember-everfrost start/end/prevquest and set as repeatable
(cherry picked from commit a481dd3)

* Core/World: Remove unused config CONFIG_SIGHT_GUARDER

(cherry picked from commit ca231cb)

* AI/PlayerAI: Finally implement cast logic for controlled players.

(cherry picked from commit 25c5570)

* DB/Creature:  Fix positions and movements type for Explorers' League Researcher and Chief Archaeologist Letoll

(cherry picked from commit ebb4cca)

* DB/Creature: Make some creatures appear dead when appropriate: K3 Snow Runner, Trapped Animal, Marsh Caribou

Closes #17239
By SnapperRy

(cherry picked from commit e518e29)

* DB/conditions: Fix quest Condition to loot item "Vrykul Scroll of Ascension

Closes #17238
By SnapperRy

(cherry picked from commit 6242399)

* DB: Scripts for teleportation Pads in Storm Peaks and K3

Closes #17236
By SnapperRy

(cherry picked from commit 73b51bb)

* DB/Quest: correct some quests' availability in K3, Storm Peaks

Closes #17235
By SnapperRy

(cherry picked from commit 2a97320)

* DB/Creature: Remove and fix some wrong spawns in Eversong Woods

Closes #17230
By SnapperRy and lyn1337

(cherry picked from commit dec66e3)

* DB/Loot: Reduce dropped quantity for item "Ravasaur Pheromone Gland"

Closes #17229
By SnapperRy
(cherry picked from commit 5161a83)

DB/Conditions: Add condition target for spell cast by item "Zorbin's Ultra-Shrinker

Closes #17228
By SnapperRy
(cherry picked from commit f177b81)

DB/Creature: Frogger

Fix pathing and speed
Updates #16488
(cherry picked from commit 37d0185)

DB/Loot: item "Primed Key Mold" should not be droppable by any NPC

Closes #17224
By SnapperRy
(cherry picked from commit d455b77)

DB/Loot: Waterlogged Recipe

Closes #17222
By SnapperRy
(cherry picked from commit 6b95d0b)

DB/Quest: Improvements to the Brood of Nozdormu rings quests

Closes #17220
By SnapperRy
(cherry picked from commit 51d100f)

* DB/Creature: Fix spawn position for Froggers

Updates #16488
(cherry picked from commit 3feeecf)

DB/Quest: Fix required class for "You Have Served Us Well"

Closes #17245
By SnapperRy
(cherry picked from commit b451c93)

DB/Loot: Fix chance for contents of item "Fireproof Satchel"

Closes #17247
By SnapperRy
(cherry picked from commit 4b8f285)

DB/Loot: Fix drop chance for quest item "Burning Legion Gate Key"

Closes #17250
By SnapperRy
(cherry picked from commit e7ac023)

DB/Quest: set required profession for quest "Gathering Leather"

Closes #17252
By SnapperRy
(cherry picked from commit 6083593)

DB/Quest: Add conditions related to certain kinds of quests

Closes #17255
By SnapperRy
(cherry picked from commit b1aca1d)

* AI/PlayerAI: Code style cleanup.
(cherry picked from commit e3aa192)

Build fix for horrendous, outdated, non-standards-compliant compilers. Such as the one in VS 2013. I hate VS 2013.

Closes #17260.
(cherry picked from commit 321d354)

* DB: Fix some DB errors

(cherry picked from commit 3251439)

* Core/DBLayer: Added new async query callback api

* Core/Scripts Improve  Jormungars fight
(cherry picked from commit 0912df2)

Rename spell_snakes_spray for spell_jormungars_snakes_spray and cleanup
(cherry picked from commit 2c9c8af)

Fixing the issue
(cherry picked from commit 81083a8)

Changing remove aura method
(cherry picked from commit b88d49b)

changing creature_text (tk feedback)
(cherry picked from commit 9b44487)

Override and tkrokli again :D
(cherry picked from commit 7205b4d)

Fix SQL name
(cherry picked from commit cae1969)

* Core/SmartAI: remove unneeded check for SMART_ACTION_FORCE_DESPAWN.

Gameobjects do not need to use SmartAI in order to be targeted by other entities' scripts.

(cherry picked from commit 9803e58)

* Core/Scripts Improve Felflame Infernal of Lord Jaraxxus fight (#16998)
(cherry picked from commit 43855b4)

Rename 9999_99_99_world.sql to 2016_06_02_01_world.sql
(cherry picked from commit 7f0e1ca)

* Core/Creatures: Remove resetting of UNIT_FLAG_IMMUNE_TO_PC on combat clearing

(cherry picked from commit 34ef05c)

* AI/PlayerAI: Fix potential edge case crash.

(cherry picked from commit 2d2544f)

* Scripts/Instances: Follow-up to #16346. Fix Illidan and Northrend Beasts.

(cherry picked from commit 4e922a5)

# Conflicts:
#	src/server/scripts/Outland/BlackTemple/boss_illidan.cpp

* Scripts/TotC: More follow-up to #16346. Also code style cleanup. Who names all their creature pointers "temp"?

(cherry picked from commit 4407877)

Compiler warning fix.
(cherry picked from commit 7fbd70d)

* AI/SmartScripts: Add action_param3 "disablePathfinding" to SMART_ACTION_MOVE_TO_POS (69).

(cherry picked from commit 123e45c)

* Core/VMaps: Fix some vmap height edge cases

Fix Map::GetWaterOrGroundLevel() checking dynamic object only in phase 1 instead of current Unit phase.
Improve DynamicMapTree::getHeight() dynamic object check by casting the ray at +0.5f from the passed Z coordinate, this value will be tuned to improve even more the results.

(cherry picked from commit 1347d7c)

* DB/Quest: A Little Slime Goes a Long Way

http://www.wowhead.com/quest=4513/a-little-slime-goes-a-long-way

* Conditions so spell can only be http://www.wowhead.com/spell=15702/filling-empty-jar can only be used on dead oozes in Un'goro Crater rather than any npc regardless of if dead or alive
* Script to despawn on spellhit so the item cant be re-used on same ooze
(cherry picked from commit 8d2ccc4)

* Scripts/Instances: More #16346 follow-ups. Fixed this time: Halls of Reflection, Ignis the Furnace Master, Mimiron and Rend Blackhand.
(cherry picked from commit 27a3eaa)

Scripts/MoltenCore: Fix Ragnaros (#16346 follow-up).
(cherry picked from commit 83e5df5)

Scripts/BlackrockMountain: Nefarian. (#16346 f-u)
(cherry picked from commit 650d7ab)

* Core/Scripts: Sharpbeak update

By Malcrom

* Missing part of 5317a81

* warning fix

* Script/Quest: Script Quest 24125 Rite of the Winds

By Malcrom, closes #18262

* Missing part of c76226c

* Missing part of c76226c

* someone lives on the past :P

* DB/Item: fix text for item "Verna's Westfall Stew Recipe"

Closes #17263 by SnapperRy
(cherry picked from commit 0e8f3e0)

DB/Item: fix text for item "Lewis' Note"

Closes #17264 by SnapperRy
(cherry picked from commit 5a2726a)

DB/Item: fix text for item "A Letter to Grelin Whitebeard"

Closes #17268 by SnapperRy
(cherry picked from commit 5a91e2c)

DB/Quest: fix prevquest for "Rejold's New Brew"

Closes #17269 by SnapperRy
(cherry picked from commit a932eb4)

DB/Quest: fix RewardText for "Beer Basted Boar Ribs"

Closes #17275 by SnapperRy
(cherry picked from commit ce107f3)

DB/Quest: fix chaining for quests related to Well Watcher Solanian

Closes #17282 by SnapperRy
(cherry picked from commit b14c554)

DB/Quest: fix chaining for Blood Elves' training quests

Closes #17284 by SnapperRy
(cherry picked from commit de9c423)

DB/locales_item: add missing localization for item "Bamboo Cage Key"

Closes #17285 by lyn1337
(cherry picked from commit ea12727)

DB/gameobject: close "Cage Door" (STV)

Close #17287 by lyn1337
(cherry picked from commit af03601)

DB/Creature: Plague Scientist spells

Closes #16729 by Gargarensis and Rushor
(cherry picked from commit 3cd66c9)

DB/Quest: Preparin' For Battle

Closes #9743 by Wylath
(cherry picked from commit 7f6b8ed)

DB/Quest: Army of the Damned

Closes #7801 by sirikfoll
(cherry picked from commit 3bba685)

DB/Creature: Fix pathing for A Cry For Help

Closes #15722 by Joslyn-Maddie
(cherry picked from commit a6e7c98)

* Core/Player: Fix duel edge case crash

Fix a crash that could be triggered if an aura removed after duel finished would have caused damage to one of the players.

(cherry picked from commit 7ff0f3c)

* DB/Creature: Ghoul Attack power

Closes #9090 by Rushor
(cherry picked from commit f82f06e)

* Scripts/Outland: Fix a potential crash. Closes #17308.

(cherry picked from commit 96c05db)

* Scripts/Instances: Fix a bug that would cause the Hodir encounter to never properly begin. Tagging issue #17302.

(cherry picked from commit e5382ee)

* DB/Creature: Ghostland waypoints

(cherry picked from commit ecd217a)

* Core/Movement: enable item use and spell cast when dismounting

Remove error message and allow spell cast or item use from
mounted state on ground, especially when sitting on
a landed flying mount. Current behavior is that the player
will get the error message "You can't do that while moving"
when trying to cast a spell or pick up an item
while sitting on a flying mount after having landed.

By joschiwald, closes #6236

(cherry picked from commit 19aac66)

* Core/Scripts: move npc_mountaineer_pebblebitty to DB

- move gossip text to DB and add quest condition
- remove core script npc_mountaineer_pebblebitty,
- thereby removing the file zone_loch_modan.cpp
- because the original core script dialog is incorrect

This version of the dialog can be verified from the following web pages:
- http://wow.gamepedia.com/Key_to_Searing_Gorge_quest_chain
- http://www.wowhead.com/npc=3836/mountaineer-pebblebitty#comments:id=332234

(cherry picked from commit 25881de)
700ead1
@LuigiElleBalotta LuigiElleBalotta referenced this issue in LuigiElleBalotta/TrinityCore Jan 12, 2017
Merged

Merge From Master #4

0 of 2 tasks complete
@LuigiElleBalotta LuigiElleBalotta added a commit to LuigiElleBalotta/TrinityCore that referenced this issue Jan 12, 2017
@LuigiElleBalotta LuigiElleBalotta Merge (#3) (#4)
* Tools/Patcher: Maybe fix mac

Ref #18145

* Core/Chat: Updated item link format

* DB/SAI: Redridge Mountains

* Core/Logging: Fix static analysis issue

CID 1367942, 1367944, 1367953,1367955,1367957, 1367958, 1367960, 1367961, 1367962, 1367964

* DB/SAI: Hillsbrad Foothills

By cooler-SAI

* DB: Rename file

* DB/SAI: Western Plaguelands

By cooler-SAI

* DB/SAI: Shimmering Expanse

By cooler-SAI

* DB/SAI: The Cape of Stranglethorn

By cooler-SAI

* Core/Units: Update druid shapeshift form models (#18554)

* Update README.md (#18572)

* Update README.md

Updated some link's as well as the formatting. Synced the structure with the 3.3.5 branch readme.md file.

* Use trinitycore.info instead of trinitycore.atlassian.net.

* Core/Players: Added new 7.1 hidden slots transmog items

* Core/Items: Implemented bonus list as a possible result of RandomSuffix

Ref #18423

* Core/Loot: Fixed group loot

Closes #17696

* Core/Misc: fixed compile warning

* Core/Loot: Implemented AoE loot

Closes #16065

* Build fix

* Core/Items: Fixed applying artifact powers scaling with number of purchased ranks (+stamina/+damage)

Closes #18644

* Dep: Update fmt (cppformat) to 3.0.1 fmtlib/fmt@7fa8f8f

Also renamed cppformat to fmt

* TravisCI: Clang 3.9

* Build/Clang: Suppress -Wexpansion-to-defined because of rapidjson dep

https://travis-ci.org/TrinityCore/TrinityCore/builds/187588737#L985-L995

* Core/PacketIO: Fixed SMSG_TRADE_UPDATED structure

Closes #18652

* Core/Loot: Increased allowed loot range and updated SendLootError

Closes #18685

* Build fix

* Core/Spells: SPELL_ATTR0_CU_SHARE_DAMAGE no longer depend on SpellFamily

* Core/Scripting: Added missing hotswap code for SceneScripts

* Update copyright note for 2017
Happy new year

* Core/Entities: fixed array size

Core/Misc: fixed compile warning

* Dep: Update rapidjson to v1.1.0

* Revert "Build/Clang: Suppress -Wexpansion-to-defined because of rapidjson dep"

This reverts commit 467e49c.

* TravisCI: Rollback to using current Clang on Travis VMs

Change from Clang 3.9 to 3.5 (current version available).

3.9 was shown to take longer than 3.5 and having random segfaults here and there.

* Core/SpellScripts: Added some const correctness

* Core/PacketIO: Fixed value sent in SMSG_SET_PCT_SPELL_MODIFIER

* Core/Spells: Fixed SPELLMOD_PCT calculation

Closes #18726

* Core/Misc: Warning fixes

* Core/Spells: Extended remaining 8bit EffectMasks to 32bit

* Core/PacketIO: Fixed leaving group not fully removing it clientside

Closes #18744

* DB/Quest: A Lesson in Fear

Properly script http://www.wowhead.com/quest=11282/a-lesson-in-fear#comments so that you actually have to kill Winterskorn Defenders to get the named npcs to spawn, added missing texts for the yell for when they spawn
(cherry picked from commit 2640f37)

* DB/Quest: Blast the Gateway

Closes #2548

(cherry picked from commit 79df25e)

* DB/Creature: Steam Pump Overseer

Closes #16840

(cherry picked from commit e70cdca)

* DB/Creature: Shadowmoon Zealot

Respawn http://www.wowhead.com/npc=21788/shadowmoon-zealot as noticed we were missing quiet a few of these.
(cherry picked from commit 61999b1)

* DB/Creature: add few missing flag_extra
(cherry picked from commit f9582ed)

* DB/Creature: Shadowmoon Harbringer

Same as with Zealots (we were missing a lot of spawns)
(cherry picked from commit 30db032)

* DB/Creature: Dark Iron Land Mines

By adeutscher
Closes #17019

(cherry picked from commit b641d7b)

* DB/Pathing:

Full paths for : -

http://www.wowhead.com/npc=24516/bjomolf
http://www.wowhead.com/npc=24517/varg
http://www.wowhead.com/npc=24277/garwal
(cherry picked from commit b82ffb8)

* DB/Script: The Etymidian

Fix Meeting a Great One quest

(cherry picked from commit e130593)

* DB/Quest: The Drakkensryd

Closes #1350
by Txknight

(cherry picked from commit b3a26fc)

* DB/Creature: Add accessory to Frigid Proto-Drake

(cherry picked from commit 17e661f)

* DB/Quest: A Rough Ride

Waypoints again since have more experience and had a lot more wp than needed previously
A couple of cosmetic fixes for this quest
(cherry picked from commit 732ec94)

* DB/SAI: Sholazar Guardians (Summoning on quest accept)

When you accept quest where you receive item to summon Goregek, Dajik, Zepik, Lafoo, Jaloot or Moodle the guardian for which player just received item is also summoned automatically.
(cherry picked from commit 4a85b65)

* Scripts/Icecrown Citadel: Sindragosa - Ice Tomb should always deal damage to all other ice tombs too

Closes #7808
Merges #16863

* DB/Misc: The Maker's Overlook

* Respawn all http://www.wowhead.com/npc=28069/sholazar-guardian and add pathing for the 3 with paths
* Spawn missing http://www.wowhead.com/npc=28840/overlook-sentry and pathing
* Correct inhabitat flags for http://www.wowhead.com/npc=29066/titan-sentry
(cherry picked from commit d6c05c5)

* DB/Event: Children's week

Add missing reward mail when either version of Return to the Orphanage in Shattrath is returned

Horde (185) - Subject: Thank you!  Body: Dear, $n,$B$BThank you for taking me out during Children's Week. Lady Liadrin, the leader of the Blood Knights, has asked that I be released to her custody for training in Silvermoon City!$B$BI just wanted to thank you for taking me to see my friend, Hch'uu, as well as the Dark Portal, the Throne of the Elements, and the Caverns of Time. I like my toy dragon very much!$B$BI'm sure that you're taking good care of my pet. Please tell him that I miss him!$B$BSincerely,$B$BSalandria
Alliance (184) - Subject: Thank you!  Body: $n,$B$BThank you for the time that we spent together during Children's Week. Did you know that Farseer Nobundo has asked the orphan matron to allow me to study with him at the Exodar?$B$BThank you for taking me to all of those neat places, and to visit my brother, Jheel. I miss him almost as much as I miss you. And, the Ring of Observance, the Dark Portal and the Caverns of Time were neato!$B$BI'm sure that you're taking good care of my pet. Tell him that I miss him, too!$B$BLove,$B$BDornaa
(cherry picked from commit e4a22f9)

Actually add the sql to last commit
(cherry picked from commit 9566b94)

* DB/Creature: Flamebringer

Some corrections to previous script from sniff.
(cherry picked from commit 769b7ff)

* CreatureAI: Adjust AI behavior when a charm ends. OnCharmed will be invoked on the creature's base (non-charmed) AI, allowing the AI to react to the creature no longer being charmed.

(cherry picked from commit 26b084a)

align fix
(cherry picked from commit 58486fc)

* Entities/Unit: Finally fix no-path evasion.

- When a creature cannot find a path to its victim, it begins evading all attacks and regenerating health.
- If this persists for 5 seconds, it evades back to spawn position with new EvadeReason value EVADE_REASON_NO_PATH.
- Also some SmartAI cleanup (why oh why does it have so much duplicated code) and getting rid of #defines in favor of type-checked compile-time constants.

(cherry picked from commit 7b1560f)

* DB/SAI: Rejek (Part 1)

Turn in event for http://www.wowhead.com/quest=12758/a-heros-headgear
(cherry picked from commit 5668bc3)

* Core/Spells: fix console spam (#17084)
(cherry picked from commit 8d09065)

* Core/Movement: Do not launch pathfinding for splines turning on the spot

(cherry picked from commit 66006e3)

* DB/Creature: fix Orgrimmar Grunt console spam

By Ariel-, closes #17083
(cherry picked from commit 945abb1)

* DB/SAI: Rejek (Part 2)

* Turn in event for http://www.wowhead.com/quest=12732/the-heartbloods-strength
* Remove previous hack for chicken net which is no longer needed
* Fix Jaina again - closes #17087
(cherry picked from commit d9dcbbc)

* Core/Auras: SPELL_AURA_PERIODIC_LEECH can now properly overkill

(cherry picked from commit 3d8bab8)

* DB/Creature: Soo-holu & Kartak the Abominable

* Corrections to vehicle id and spells (Soo-holu previously had vehicleid 134 in sniff both are 257)
* Move spell focus for summoning Soo-holu with http://www.wowhead.com/item=39266/tainted-crystal to correct place
* On summon texts for when summoned
* Add some broadcasttext ids I forgot to add in my last commit.
(cherry picked from commit c42f0bd)

* Core/Random: Removed ancient and unused MAP_BASED_RAND_GEN

(cherry picked from commit 1ad02a0)

* Core/Spells: Fix wrong totem placement

(cherry picked from commit 37b2f59)

* Implement Quest Riding the Red Rocket
(cherry picked from commit 20b3feb)

Fix SQL name
(cherry picked from commit 2329648)

* Core/Battleground Script for Isle of Conquest Bosses

by @gerripeach
(cherry picked from commit c1ed002)

SQL file name fix
(cherry picked from commit 74f3a84)

* Script/SWP Full Rework on M'uru Encounter

(cherry picked from commit 6002acf)

Another sql fix
(cherry picked from commit 204acbb)

* Core/Auras: Renamed fields of SpellProcEntry structure and change types to more appropriate ones

(cherry picked from commit ef7df65)

Build fix
(cherry picked from commit c03e7ec)

SQL fix
(cherry picked from commit 7a41467)

* Creature/CreatureAI:

- Default range for DoZoneInCombat: 50.0f -> 250.0f.
- Add optional second arg to SummonList::DoZoneInCombat to specify range.
- Also a bunch of random NULL -> nullptr cleanup.

(cherry picked from commit b7f2c87)

Too many damn stars in that damn argument list.
(cherry picked from commit afbda04)

* Core/AI: Add DoCastSelf helper.

(I have no idea why I never bothered to do this before, really. It had crossed my mind a few times.)

(cherry picked from commit ab0abdb)

This discussion is more effort than it takes to change it.
(cherry picked from commit b52a6b8)

* DB/Gameobject: Add 2 missing spawns

By Girib Dragos

* Rename 2017_01_08_00_world.sql to 2017_01_08_04_world.sql

* Core/Scripts: Added reasonable default params to GetCreatureListWithEntryInGrid/GetGameObjectListWithEntryInGrid for ease of use. Also, entry = 0 means no filter now, since we lacked an easy way to get a list of all creatures in grid.

(cherry picked from commit 0d5adf3)

* Allow BossAI::_DespawnAtEvade to work on creatures other than the boss itself (optional argument).

(cherry picked from commit 6040e30)

* Core/Movement: Fix issues where creatures cancel spell casts chasing target and Implement SPELL_ATTR5_CAN_CHANNEL_WHEN_MOVING

(cherry picked from commit bf2cee8)

* Add a LOG_WARN when attempting to summon a non-existing summon group.
(cherry picked from commit 4d4d2f5)

Seriously, who doesn't support std::string instead of char* in 2016?
(cherry picked from commit a012b37)

* Core/Unit: Pet shouldn't be notified for DOT damage on the owner (#17133)

- Fix by @MrSmite
- Closes #16894
(cherry picked from commit 4de1426)

* Core/Quests: Fixed issue reported by static analysis

Coverity defect ID: 1355241

(cherry picked from commit a01fd52)

* Core/Spells Make certain spells (e.g. Mind Control) properly flag the caster for PvP (#17145)

* This issue was caused by PvP-flagging being done calculated after the target's flag was turned off by becoming a pet.

(cherry picked from commit e7a12ed)

* Core/Spells: Proc handler script converions (#17122)

* Blazing Speed (Mage)
* Blessed Recovery (Priest)
* Druid Forms Trinket
* Idol Of Mutilation
* Nature's Guardian (Shaman)
* Nether Protection (Warlock)
* Piercing Shots and Bonus 4P T9 Hunter
* Lightning Shield (Shaman)
* Acclimation (DK)
* Move DK T10 4P Melee Bonus
* Move DK Improved Blood Presence triggered heal (DK)
* Rogue T10 2P Bonus
* Illumination (Paladin)
* Soul Preserver
* Death Choice trinket
* stack trinket scripts (ToC25 Caster Trinket, Lightning Capacitor, Thunder Capacitor)
* Battle Experience (ICC - Gunship)
* Blood Reserve (enchant proc)
* Darkmoon Card Greatness
* Charm of the Amani Witch Doctor
* Mana Drain

(cherry picked from commit 5b8e68e)

* Core/Auras: Fixed cooldowns for procs calling PreventDefaultAction() in aura proc script

* This also fixes proc cooldows unneccessarily being sent to client
* Also removes the need for cooldown hacks when the proc trigger is selected randomly like for Deathbringer's Will

(cherry picked from commit 1e1fcd6)

* Core/Chat: Don't check item suffix name when validating item links when the item has ITEM_FLAG3_HIDE_NAME_SUFFIX

* DB/Creature: Add missing creature spawns in Ghostlands & Eversong Woods

Added the following NPC's : Toad, Snake, Frog, Lesser Scourgebat, Greater Spindleweb, Ghostclaw Ravager, Ghostclaw Lynx, Vampiric Mistbat, Whitetail Frenzy, Yellowgill Frenzy, Rabbit, Feral Dragonhawk Hatchling, Springpaw Stalker, Crazed Dragonhawk, Ghostlands Guardian, Spider

(cherry picked from commit 7c8c3b9)

* DB/Object: Add missing object spawns in Ghostlands & Eversong Woods

Bonfire, Cauldron & Campfire

(cherry picked from commit 7427ca5)

*  DB/trainers: Engineering trainers & spells

By clintskie

Updates #14682

* Conditions/ConditionMgr: Add a comment so MitchesD can go away.

(cherry picked from commit 759aae5)

* DB/Creature: Cabal Ritualists don't cast Crystal Channel

By Saben65, closes #16986
(cherry picked from commit b0f9a99)

* Core: updated creature type flags enum (#17128)

Core/Misc: Update CreatureTypeFlags enum according to TrinityCoreWiki
(cherry picked from commit fb08813)

# Conflicts:
#	src/server/game/AI/ScriptedAI/ScriptedEscortAI.cpp
#	src/server/game/AI/ScriptedAI/ScriptedFollowerAI.cpp
#	src/server/game/AI/SmartScripts/SmartAI.cpp
#	src/server/game/Entities/Unit/Unit.cpp
#	src/server/game/Miscellaneous/SharedDefines.h

* Core/Object: Use object edges to calculate LoS

(cherry picked from commit da6065d)

* Core/Spells: Implemented SPELL_ATTR1_DISMISS_PET

Closes #7372

(cherry picked from commit 9246189)

* Core/Loot: Fixed resaving looted items from containers

Closes #15299

(cherry picked from commit 4a074ca)

* DB/Creature: Clam Master K Waypoints

by Saben65

(cherry picked from commit 5536a96)

* Sorry, it's too late...

* DB/Creature: Pathing for Houndmaster Grebmar

by Kodekc

(cherry picked from commit 9e797e4)

* DB/Creature: Add flag guard Deathguard Elite

by Kodekc
Closes #17147

(cherry picked from commit 4f79114)

* DB/Creature: Add missing Ornery Plainstrider SAI

by Kodekc
Closes #17146

(cherry picked from commit c461e21)

* DB/Creature: Mebok Mizzyrix SAI

by tkrokli
Closes #17179

(cherry picked from commit 4ebed6e)

* DB/Gameobject: Spawn Rite of the Winds spellfocus

Updates #18262

* DB/Creature: Pathing Hinterlands

By Malcrom

* SQL: Fix import

* Merge pull request #17138 from ForesterDev/creature_family

Core/Misc: Define CREATURE_FAMILY_NONE to avoid magic numbers in code
(cherry picked from commit 62635f0)

* Core/Units: Renamed and documented UNIT_FLAG_DISABLE_MOVE to prevent people from trying to use this flag to root a creature leaving them wondering why it doesn't do anything

(cherry picked from commit b36da77)

Core/Scripts: build fix

(cherry picked from commit 258368a)

* DB/Creature: Add missing aura for Snorts

by Kodekc
Closes #17194

(cherry picked from commit bd13475)

* Core/Unit Do not allow addition of threat to units in evade mode

(cherry picked from commit 7d76900)

* Core/Achievement A-bomb-inable and A-bomb-ination
(cherry picked from commit e016bf8)

DB: SQL rename
(cherry picked from commit 71081c2)

* Core/Quests: Remove wrong call to SendQuestComplete(). (#17200)
(cherry picked from commit 9480a21)

* DB/Quest: Thwart the Dark Conclave

Closes #11791
(cherry picked from commit 80fc9cc)

* Revert "Merge pull request #16433 from Tonghost/3.3.5"

This reverts commit e3d5299, reversing
changes made to 6d8e39f.

Opens #16759

(cherry picked from commit 5aae019)

* DB/Quest: ExclusiveGroup for breadcrumb quests in Mudsprocket, Dustwallow Marsh

By SnapperRy, closes #17217
(cherry picked from commit ae6b3eb)

* DB/Spells: fix Searing Wrath's chain jump targeting

Ny SnapperRy closes #17216 closes #6671
(cherry picked from commit a5bd790)

* Fixed warning

* DB/Creature: More Hinterlands fixes

By Malcrom

* DB/Creature: Apothecary Surlis

By Malcrom

* Core/Groups: Send PartyUpdate to all players leaving group, not only on disband

Closes #18757

* Script/Taxi Sharpbeak Hinterlands

By Malcrom

* missing part of b3f2dd6

* Update zone_hinterlands.cpp

* DB/Creature: Fix some carts

By Malcrom

* DB/SAI: actually execute Technician Zhanaa's script on quest turn-in

Closes #17209 by SnapperRy
(cherry picked from commit 291a264)

* DB/Misc: Miscellenous Fixes

1) Fix http://www.wowhead.com/quest=1144/willix-the-importer so this quest does not complete as soon as taken so that players actually have to do the escort before been able to return quest
2) Remove XP at kill from several creatures which dont give xp on retail
3) Put alliance/horde versions of Reigns of the Grand War Mammoth (VOA) into seperate loot groups so chance for drop is actually 1% rather than been 1% chance of reference loot been called then been a 50/50 chance of which factions mount dropped which in fact reduced chance to 0.5% as if opposite factions dropped then not visible
4) Update to text target for one text from Rohin the Decaying
5) Move spell focus for http://www.wowhead.com/quest=12569/crocolisk-mastery-the-ambush so its on top of log and not behind it so position matches doing quest on retail
(cherry picked from commit f941dad)

* DB/Misc: Everfrost Chip

1) Remove required quest from loot tables for http://www.wowhead.com/item=44724/everfrost-chip , http://www.wowhead.com/item=44725/everfrost-chip and http://www.wowhead.com/item=44729/everfrost-powder so that everfrost chip is not always empty when looted since none of these items should require active quest to drop only that player is friendly with sons of hodir or has completed pre-quest in case of remember everfrost
2) Add missing quest data for http://www.wowhead.com/quest=13421/remember-everfrost start/end/prevquest and set as repeatable
(cherry picked from commit a481dd3)

* Core/World: Remove unused config CONFIG_SIGHT_GUARDER

(cherry picked from commit ca231cb)

* AI/PlayerAI: Finally implement cast logic for controlled players.

(cherry picked from commit 25c5570)

* DB/Creature:  Fix positions and movements type for Explorers' League Researcher and Chief Archaeologist Letoll

(cherry picked from commit ebb4cca)

* DB/Creature: Make some creatures appear dead when appropriate: K3 Snow Runner, Trapped Animal, Marsh Caribou

Closes #17239
By SnapperRy

(cherry picked from commit e518e29)

* DB/conditions: Fix quest Condition to loot item "Vrykul Scroll of Ascension

Closes #17238
By SnapperRy

(cherry picked from commit 6242399)

* DB: Scripts for teleportation Pads in Storm Peaks and K3

Closes #17236
By SnapperRy

(cherry picked from commit 73b51bb)

* DB/Quest: correct some quests' availability in K3, Storm Peaks

Closes #17235
By SnapperRy

(cherry picked from commit 2a97320)

* DB/Creature: Remove and fix some wrong spawns in Eversong Woods

Closes #17230
By SnapperRy and lyn1337

(cherry picked from commit dec66e3)

* DB/Loot: Reduce dropped quantity for item "Ravasaur Pheromone Gland"

Closes #17229
By SnapperRy
(cherry picked from commit 5161a83)

DB/Conditions: Add condition target for spell cast by item "Zorbin's Ultra-Shrinker

Closes #17228
By SnapperRy
(cherry picked from commit f177b81)

DB/Creature: Frogger

Fix pathing and speed
Updates #16488
(cherry picked from commit 37d0185)

DB/Loot: item "Primed Key Mold" should not be droppable by any NPC

Closes #17224
By SnapperRy
(cherry picked from commit d455b77)

DB/Loot: Waterlogged Recipe

Closes #17222
By SnapperRy
(cherry picked from commit 6b95d0b)

DB/Quest: Improvements to the Brood of Nozdormu rings quests

Closes #17220
By SnapperRy
(cherry picked from commit 51d100f)

* DB/Creature: Fix spawn position for Froggers

Updates #16488
(cherry picked from commit 3feeecf)

DB/Quest: Fix required class for "You Have Served Us Well"

Closes #17245
By SnapperRy
(cherry picked from commit b451c93)

DB/Loot: Fix chance for contents of item "Fireproof Satchel"

Closes #17247
By SnapperRy
(cherry picked from commit 4b8f285)

DB/Loot: Fix drop chance for quest item "Burning Legion Gate Key"

Closes #17250
By SnapperRy
(cherry picked from commit e7ac023)

DB/Quest: set required profession for quest "Gathering Leather"

Closes #17252
By SnapperRy
(cherry picked from commit 6083593)

DB/Quest: Add conditions related to certain kinds of quests

Closes #17255
By SnapperRy
(cherry picked from commit b1aca1d)

* AI/PlayerAI: Code style cleanup.
(cherry picked from commit e3aa192)

Build fix for horrendous, outdated, non-standards-compliant compilers. Such as the one in VS 2013. I hate VS 2013.

Closes #17260.
(cherry picked from commit 321d354)

* DB: Fix some DB errors

(cherry picked from commit 3251439)

* Core/DBLayer: Added new async query callback api

* Core/Scripts Improve  Jormungars fight
(cherry picked from commit 0912df2)

Rename spell_snakes_spray for spell_jormungars_snakes_spray and cleanup
(cherry picked from commit 2c9c8af)

Fixing the issue
(cherry picked from commit 81083a8)

Changing remove aura method
(cherry picked from commit b88d49b)

changing creature_text (tk feedback)
(cherry picked from commit 9b44487)

Override and tkrokli again :D
(cherry picked from commit 7205b4d)

Fix SQL name
(cherry picked from commit cae1969)

* Core/SmartAI: remove unneeded check for SMART_ACTION_FORCE_DESPAWN.

Gameobjects do not need to use SmartAI in order to be targeted by other entities' scripts.

(cherry picked from commit 9803e58)

* Core/Scripts Improve Felflame Infernal of Lord Jaraxxus fight (#16998)
(cherry picked from commit 43855b4)

Rename 9999_99_99_world.sql to 2016_06_02_01_world.sql
(cherry picked from commit 7f0e1ca)

* Core/Creatures: Remove resetting of UNIT_FLAG_IMMUNE_TO_PC on combat clearing

(cherry picked from commit 34ef05c)

* AI/PlayerAI: Fix potential edge case crash.

(cherry picked from commit 2d2544f)

* Scripts/Instances: Follow-up to #16346. Fix Illidan and Northrend Beasts.

(cherry picked from commit 4e922a5)

# Conflicts:
#	src/server/scripts/Outland/BlackTemple/boss_illidan.cpp

* Scripts/TotC: More follow-up to #16346. Also code style cleanup. Who names all their creature pointers "temp"?

(cherry picked from commit 4407877)

Compiler warning fix.
(cherry picked from commit 7fbd70d)

* AI/SmartScripts: Add action_param3 "disablePathfinding" to SMART_ACTION_MOVE_TO_POS (69).

(cherry picked from commit 123e45c)

* Core/VMaps: Fix some vmap height edge cases

Fix Map::GetWaterOrGroundLevel() checking dynamic object only in phase 1 instead of current Unit phase.
Improve DynamicMapTree::getHeight() dynamic object check by casting the ray at +0.5f from the passed Z coordinate, this value will be tuned to improve even more the results.

(cherry picked from commit 1347d7c)

* DB/Quest: A Little Slime Goes a Long Way

http://www.wowhead.com/quest=4513/a-little-slime-goes-a-long-way

* Conditions so spell can only be http://www.wowhead.com/spell=15702/filling-empty-jar can only be used on dead oozes in Un'goro Crater rather than any npc regardless of if dead or alive
* Script to despawn on spellhit so the item cant be re-used on same ooze
(cherry picked from commit 8d2ccc4)

* Scripts/Instances: More #16346 follow-ups. Fixed this time: Halls of Reflection, Ignis the Furnace Master, Mimiron and Rend Blackhand.
(cherry picked from commit 27a3eaa)

Scripts/MoltenCore: Fix Ragnaros (#16346 follow-up).
(cherry picked from commit 83e5df5)

Scripts/BlackrockMountain: Nefarian. (#16346 f-u)
(cherry picked from commit 650d7ab)

* Core/Scripts: Sharpbeak update

By Malcrom

* Missing part of 5317a81

* warning fix

* Script/Quest: Script Quest 24125 Rite of the Winds

By Malcrom, closes #18262

* Missing part of c76226c

* Missing part of c76226c

* someone lives on the past :P

* DB/Item: fix text for item "Verna's Westfall Stew Recipe"

Closes #17263 by SnapperRy
(cherry picked from commit 0e8f3e0)

DB/Item: fix text for item "Lewis' Note"

Closes #17264 by SnapperRy
(cherry picked from commit 5a2726a)

DB/Item: fix text for item "A Letter to Grelin Whitebeard"

Closes #17268 by SnapperRy
(cherry picked from commit 5a91e2c)

DB/Quest: fix prevquest for "Rejold's New Brew"

Closes #17269 by SnapperRy
(cherry picked from commit a932eb4)

DB/Quest: fix RewardText for "Beer Basted Boar Ribs"

Closes #17275 by SnapperRy
(cherry picked from commit ce107f3)

DB/Quest: fix chaining for quests related to Well Watcher Solanian

Closes #17282 by SnapperRy
(cherry picked from commit b14c554)

DB/Quest: fix chaining for Blood Elves' training quests

Closes #17284 by SnapperRy
(cherry picked from commit de9c423)

DB/locales_item: add missing localization for item "Bamboo Cage Key"

Closes #17285 by lyn1337
(cherry picked from commit ea12727)

DB/gameobject: close "Cage Door" (STV)

Close #17287 by lyn1337
(cherry picked from commit af03601)

DB/Creature: Plague Scientist spells

Closes #16729 by Gargarensis and Rushor
(cherry picked from commit 3cd66c9)

DB/Quest: Preparin' For Battle

Closes #9743 by Wylath
(cherry picked from commit 7f6b8ed)

DB/Quest: Army of the Damned

Closes #7801 by sirikfoll
(cherry picked from commit 3bba685)

DB/Creature: Fix pathing for A Cry For Help

Closes #15722 by Joslyn-Maddie
(cherry picked from commit a6e7c98)

* Core/Player: Fix duel edge case crash

Fix a crash that could be triggered if an aura removed after duel finished would have caused damage to one of the players.

(cherry picked from commit 7ff0f3c)

* DB/Creature: Ghoul Attack power

Closes #9090 by Rushor
(cherry picked from commit f82f06e)

* Scripts/Outland: Fix a potential crash. Closes #17308.

(cherry picked from commit 96c05db)

* Scripts/Instances: Fix a bug that would cause the Hodir encounter to never properly begin. Tagging issue #17302.

(cherry picked from commit e5382ee)

* DB/Creature: Ghostland waypoints

(cherry picked from commit ecd217a)

* Core/Movement: enable item use and spell cast when dismounting

Remove error message and allow spell cast or item use from
mounted state on ground, especially when sitting on
a landed flying mount. Current behavior is that the player
will get the error message "You can't do that while moving"
when trying to cast a spell or pick up an item
while sitting on a flying mount after having landed.

By joschiwald, closes #6236

(cherry picked from commit 19aac66)

* Core/Scripts: move npc_mountaineer_pebblebitty to DB

- move gossip text to DB and add quest condition
- remove core script npc_mountaineer_pebblebitty,
- thereby removing the file zone_loch_modan.cpp
- because the original core script dialog is incorrect

This version of the dialog can be verified from the following web pages:
- http://wow.gamepedia.com/Key_to_Searing_Gorge_quest_chain
- http://www.wowhead.com/npc=3836/mountaineer-pebblebitty#comments:id=332234

(cherry picked from commit 25881de)
3b49297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment