[master] battleground MAX TYPE ID #18775

Open
zamalaev opened this Issue Jan 9, 2017 · 1 comment

Projects

None yet

3 participants

@zamalaev
zamalaev commented Jan 9, 2017 edited

Description:

enum BattlegroundTypeId
{
    BATTLEGROUND_TYPE_NONE      = 0,   // None
    BATTLEGROUND_AV             = 1,   // Alterac Valley
    BATTLEGROUND_WS             = 2,   // Warsong Gulch
    BATTLEGROUND_AB             = 3,   // Arathi Basin
    BATTLEGROUND_NA             = 4,   // Nagrand Arena
    BATTLEGROUND_BE             = 5,   // Blade's Edge Arena
    BATTLEGROUND_AA             = 6,   // All Arenas
    BATTLEGROUND_EY             = 7,   // Eye of the Storm
    BATTLEGROUND_RL             = 8,   // Ruins of Lordaernon
    BATTLEGROUND_SA             = 9,   // Strand of the Ancients
    BATTLEGROUND_DS             = 10,  // Dalaran Sewers
    BATTLEGROUND_RV             = 11,  // Ring of Valor
    BATTLEGROUND_IC             = 30,  // Isle of Conquest
    BATTLEGROUND_RB             = 32,  // Random Battleground
    BATTLEGROUND_RATED_10_VS_10 = 100, // Rated BG 10 vs 10
    BATTLEGROUND_RATED_15_VS_15 = 101, // Rated BG 15 vs 15
    BATTLEGROUND_RATED_25_VS_25 = 102, // Rated BG 25 vs 25
    BATTLEGROUND_TP             = 108, // Twin Peaks
    BATTLEGROUND_BFG            = 120, // Battle For Gilneas
    // 441 = "Icecrown Citadel"
    // 443 = "The Ruby Sanctum"
    // 656 = "Rated Eye of the Storm"
    BATTLEGROUND_TK             = 699, // Temple of Kotmogu
    // 706 = "CTF3"
    BATTLEGROUND_SM             = 708, // Silvershard Mines
    BATTLEGROUND_TVA            = 719, // Tol'Viron Arena
    BATTLEGROUND_DG             = 754, // Deepwind Gorge
    BATTLEGROUND_TTP            = 757, // The Tiger's Peak
    BATTLEGROUND_SS_VS_TM       = 789  // Southshore vs. Tarren Mill
};

#define MAX_BATTLEGROUND_TYPE_ID 758 ?

Current behaviour: (Tell us what happens.)

diff --git a/src/server/game/Miscellaneous/SharedDefines.h b/src/server/game/Miscellaneous/SharedDefines.h
index fa2e5df..4516222 100644
--- a/src/server/game/Miscellaneous/SharedDefines.h
+++ b/src/server/game/Miscellaneous/SharedDefines.h
@@ -4769,10 +4769,16 @@ enum BattlegroundTypeId
     BATTLEGROUND_TVA            = 719, // Tol'Viron Arena
     BATTLEGROUND_DG             = 754, // Deepwind Gorge
     BATTLEGROUND_TTP            = 757, // The Tiger's Peak
-    BATTLEGROUND_SS_VS_TM       = 789  // Southshore vs. Tarren Mill
+    BATTLEGROUND_SS_VS_TM       = 789, // Southshore vs. Tarren Mill
+    BATTLEGROUND_SMALL_D        = 803, // Small Battleground D
+    BATTLEGROUND_BRH            = 808, // Black Rook Hold Arena
+    //  809 = "New Nagrand Arena (Legion)"
+    BATTLEGROUND_AF             = 816, // Ashamane's Fall
+    //  844 = "New Blade's Edge Arena (Legion)"
+
 };

-#define MAX_BATTLEGROUND_TYPE_ID 758
+#define MAX_BATTLEGROUND_TYPE_ID 845

Expected behaviour: (Tell us what should happen instead.)

Steps to reproduce the problem:

Branch(es): master (Tell us which branch(es) this issue affects.)

TC rev. hash/commit:
56797f1
TDB version:

Operating system:

@P-Kito
Contributor
P-Kito commented Jan 10, 2017

Why not open a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment