Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.3.5] Core/Spells: Health Funnel removes more life than it should #21142

Open
Keader opened this issue Dec 30, 2017 · 2 comments
Open

[3.3.5] Core/Spells: Health Funnel removes more life than it should #21142

Keader opened this issue Dec 30, 2017 · 2 comments

Comments

@Keader
Copy link
Contributor

Keader commented Dec 30, 2017

Current script remove warlock health in 2 points.
Here: https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/game/Spells/Auras/SpellAuraEffects.cpp#L5421
And Here: https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/game/Spells/Auras/SpellAuras.cpp#L706
The second point, is called 2 times: First call is caused by Warlock Aura. The second is caused by Pet Aura.
And current script, dont check any SPELLMOD_COST, so reduce cost part of Improved Health Funnel not work.

PS: If you try fix it, please read #20559 (comment)

:)

More info here: #20559

Branch(es): 3.3.5

TC rev. hash/commit: 527ef19

@ghost ghost changed the title [3.3.5] Spell Health Funnel removing more life that should [3.3.5] Core/Spells: Health Funnel removes more life than it should Dec 30, 2017
@ariel- ariel- self-assigned this Jan 6, 2018
@ariel-
Copy link
Contributor

ariel- commented Feb 12, 2018

Needs #21395 first (because of two aura objects applied, one on pet, other on warlock)

@CraftedRO
Copy link
Contributor

8ad4314 not really sure if still valid but it can kill you and I doubt it shoud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants