[CRASH] in ThreatManager::_addThreat #235

Closed
click opened this Issue May 16, 2011 · 21 comments

7 participants

@click
TrinityCore member

CORE revision number : 014714f
Database: YTDB 579
Patches: AC1

@click
TrinityCore member

Author: shocker
Confirmed

@click
TrinityCore member

Author: marky81
Confirmed:

{{{

0 0x00000000007653b8 in ThreatManager::_addThreat(Unit, float) ()
#1 0x0000000000765669 in ThreatManager::addThreat(Unit
, float, SpellSchoolMask, SpellEntry const) ()
#2 0x0000000000763682 in HostileRefManager::threatAssist(Unit
, float, SpellEntry const, bool) ()
#3 0x0000000000acc265 in AuraEffect::PeriodicTick(AuraApplication
, Unit) const ()
#4 0x0000000000ace956 in AuraEffect::Update(unsigned int, Unit
) ()
#5 0x0000000000ab0cf4 in Aura::UpdateOwner(unsigned int, WorldObject*) ()
#6 0x000000000089055b in Unit::_UpdateSpells(unsigned int) ()
#7 0x000000000089f62c in Unit::Update(unsigned int) ()
#8 0x0000000000841b21 in Player::Update(unsigned int) ()
#9 0x00000000009e59bd in Map::Update(unsigned int const&) ()
#10 0x00000000009e5b09 in InstanceMap::Update(unsigned int const&) ()
#11 0x0000000000c15bae in MapInstanced::Update(unsigned int const&) ()
#12 0x0000000000c14e32 in MapUpdateRequest::call() ()
#13 0x0000000000c66fac in DelayExecutor::svc() ()
#14 0x00002aaaaac12687 in ACE_Task_Base::svc_run (args=) at ../../ace/Task.cpp:275
#15 0x00002aaaaac13605 in ACE_Thread_Adapter::invoke (this=0x2aaad0badfa0) at ../../ace/Thread_Adapter.cpp:98
#16 0x0000003ec320673d in start_thread () from /lib64/libpthread.so.0

}}}

@click
TrinityCore member

Author: marky81
Any new about this crash ? Very often :(

@click
TrinityCore member

Author: 1mp3rator
http://pastebin.com/BvmHZqxx

@click
TrinityCore member

Author: marky81
Any fix ? Hack fix ? this crash is so bad :(

@click
TrinityCore member

Author: uncletom

{{{
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffd0bff700 (LWP 3160)]
0x0000000000c130e0 in ThreatManager::addThreat(Unit, float, SpellSchoolMask, SpellEntry const) ()
#0 0x0000000000c130e0 in ThreatManager::addThreat(Unit, float, SpellSchoolMask, SpellEntry const) ()
#1 0x00000000007ab971 in HostileRefManager::threatAssist(Unit, float, SpellEntry const, bool) ()
#2 0x0000000000b595af in AuraEffect::PeriodicTick(AuraApplication, Unit) const ()
#3 0x0000000000b5e6bf in AuraEffect::Update(unsigned int, Unit) ()
#4 0x0000000000b3d01b in Aura::UpdateOwner(unsigned int, WorldObject
) ()
#5 0x0000000000864c8e in Unit::_UpdateSpells(unsigned int) ()
#6 0x0000000000866cba in Unit::Update(unsigned int) ()
#7 0x000000000094679e in Player::Update(unsigned int) ()
#8 0x0000000000a352d5 in Map::Update(unsigned int const&) ()
#9 0x0000000000a353c9 in InstanceMap::Update(unsigned int const&) ()
#10 0x0000000000c49339 in MapInstanced::Update(unsigned int const&) ()
#11 0x0000000000a4291e in MapUpdateRequest::call() ()
#12 0x0000000000cd9d41 in DelayExecutor::svc() ()
#13 0x00007ffff7362fa7 in ACE_Task_Base::svc_run (args=)
at ../../ace/Task.cpp:275
#14 0x00007ffff7364655 in ACE_Thread_Adapter::invoke (this=0x7fffe2957be0)
at ../../ace/Thread_Adapter.cpp:98
}}}

@click
TrinityCore member

Author: uncletom
please fix...

@click
TrinityCore member

Author: stfx
Crashes due to multithreading when threatlist is being modified while it is read in a different threat at the same time. The modification of threatlist is usually (always?) happening in Spell::DoSpellHitOnUnit() => unit->getHostileRefManager().threatAssist(m_caster, 0.0f);

@click
TrinityCore member

Author: marky81
mutex needed

@click
TrinityCore member

Author: doggy
This totally destroys any multithreading :|

@click
TrinityCore member

Author: doggy
Could anyone please look into this =(

@click
TrinityCore member

Author: lazzalf
Confirm

Rev: 2717129
OS: Ubuntu Server 9.10 x64
DB: TDB 335.11.40

http://pastebin.com/3DB6KEDp

@jslack

Any hack to fix it ?

@jobbais

Trinity Revision: 360f053+
Custom patch: AC1
Database Version: TDB 335.11.41
server: Ubuntu server 64 bit 10.04

crashlog : http://pastebin.com/skfwd9Ge

@jslack

I make a lot test, with mutex and everything... this crash love me =/
Any dev is looking on this ?

@jobbais

crashdump again: http://pastebin.com/GUK3eKCZ

Trinity Revision: 944fb4c
patches: AC1
Database Version: TDB 335.11.41
server: ubuntu 10.04 64 bit

@LihO

confirmed on b2698d6
TDB 41 with updates

will take a look at it later, for now i paste crash log: http://paste2.org/p/1574676

@hacknowledge

Have a look at my pull request #2590 which might fix this issue.

@hacknowledge

Could someone provide a full backtrace of all threads while this crash occurs? Without prove that the mutex is necessary, the TC team is reluctant to pull my fix.

@n4ndo

the mutex could add delay?

@Aokromes
TrinityCore member

Try again on head if this crash is valid yet create a new ticket.

@Aokromes Aokromes closed this Jan 22, 2012
@ike3 ike3 pushed a commit to ike3/mangosbot that referenced this issue Aug 25, 2014
@rsa rsa [mr840] LFG: rewrite work with dungeons lists. Must finally solve #235,…
… but need test on online >500 :(
1c3b01e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment