New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Svala Sorrowgrave #4002

Closed
Albis opened this Issue Nov 19, 2011 · 6 comments

Comments

Projects
None yet
6 participants
@Albis

Albis commented Nov 19, 2011

Svala's Sorrowgrave dialog with arthas is wrong. King Ymiron is yelling instead of arthas.

Also, The event does not start cause of wrong flag.
Here is a fix written by me.
http://pastebin.com/q6E5hZag

Also this should be applied, fixes the voices :

UPDATE script_texts SET sound = 13855 , type = 1 WHERE entry = -1575022;
UPDATE script_texts SET sound = 13848 , type = 1 WHERE entry = -1575021;
UPDATE script_texts SET sound = 13847 , type = 1 WHERE entry = -1575020;
UPDATE script_texts SET sound = 13845 , type = 1 WHERE entry = -1575019;
UPDATE script_texts SET sound = 13842 , type = 1 WHERE entry = -1575018;
UPDATE script_texts SET sound = 13856 , type = 1 WHERE entry = -1575015;
UPDATE script_texts SET sound = 13857 , type = 1 WHERE entry = -1575016;
UPDATE script_texts SET sound = 13858 , type = 1 WHERE entry = -1575017;
INSERT INTO script_texts (`npc_entry`, `entry`, `content_default`, `content_loc1`, `content_loc2`, `content_loc3`, `content_loc4`, `content_loc5`, `content_loc6`, `content_loc7`, `content_loc8`, `sound`, `type`, `language`, `emote`, `comment`) VALUES
(24266,-1575003,'Your sacrifice is a testament to your obedience. Indeed you are worthy of this charge. Arise, and forever be known as Svala Sorrowgrave!',NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,14732,1,0,0,'SAY_DIALOG_OF_ARTHAS_1'),
(24266,-1575014,'Your first test awaits you. Destroy our uninvited guests.',NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,14733,1,0,0,'SAY_DIALOG_OF_ARTHAS_2');

And this, fixes her flag so script can be started (credit to ric)

UPDATE `creature_template` SET `unit_flags`=2 WHERE `entry`=29281 LIMIT 1;
UPDATE `creature_template` SET `unit_flags`=2 WHERE `entry`=30809 LIMIT 1;
@amable

This comment has been minimized.

Show comment
Hide comment
@amable

amable Nov 20, 2011

UPDATE script_texts SET sound = 13855 , type = 1 WHERE entry = -1575022;
UPDATE script_texts SET sound = 13848 , type = 1 WHERE entry = -1575021;
UPDATE script_texts SET sound = 13847 , type = 1 WHERE entry = -1575020;
UPDATE script_texts SET sound = 13845 , type = 1 WHERE entry = -1575019;
UPDATE script_texts SET sound = 13842 , type = 1 WHERE entry = -1575018;
UPDATE script_texts SET sound = 13856 , type = 1 WHERE entry = -1575015;
UPDATE script_texts SET sound = 13857 , type = 1 WHERE entry = -1575016;
UPDATE script_texts SET sound = 13858 , type = 1 WHERE entry = -1575017;
INSERT INTO script_texts (npc_entry, entry, content_default, content_loc1, content_loc2, content_loc3, content_loc4, content_loc5, content_loc6, content_loc7, content_loc8, sound, type, language, emote, comment) VALUES
(24266,-1575003,'Your sacrifice is a testament to your obedience. Indeed you are worthy of this charge. Arise, and forever be known as Svala Sorrowgrave!',NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,14732,1,0,0,'SAY_DIALOG_OF_ARTHAS_1'),
(24266,-1575014,'Your first test awaits you. Destroy our uninvited guests.',NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,14733,1,0,0,'SAY_DIALOG_OF_ARTHAS_2');

UPDATE creature_template SET unit_flags=2 WHERE entry=29281 LIMIT 1;
UPDATE creature_template SET unit_flags=2 WHERE entry=30809 LIMIT 1;

Look better :) Btw thank.

amable commented Nov 20, 2011

UPDATE script_texts SET sound = 13855 , type = 1 WHERE entry = -1575022;
UPDATE script_texts SET sound = 13848 , type = 1 WHERE entry = -1575021;
UPDATE script_texts SET sound = 13847 , type = 1 WHERE entry = -1575020;
UPDATE script_texts SET sound = 13845 , type = 1 WHERE entry = -1575019;
UPDATE script_texts SET sound = 13842 , type = 1 WHERE entry = -1575018;
UPDATE script_texts SET sound = 13856 , type = 1 WHERE entry = -1575015;
UPDATE script_texts SET sound = 13857 , type = 1 WHERE entry = -1575016;
UPDATE script_texts SET sound = 13858 , type = 1 WHERE entry = -1575017;
INSERT INTO script_texts (npc_entry, entry, content_default, content_loc1, content_loc2, content_loc3, content_loc4, content_loc5, content_loc6, content_loc7, content_loc8, sound, type, language, emote, comment) VALUES
(24266,-1575003,'Your sacrifice is a testament to your obedience. Indeed you are worthy of this charge. Arise, and forever be known as Svala Sorrowgrave!',NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,14732,1,0,0,'SAY_DIALOG_OF_ARTHAS_1'),
(24266,-1575014,'Your first test awaits you. Destroy our uninvited guests.',NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,14733,1,0,0,'SAY_DIALOG_OF_ARTHAS_2');

UPDATE creature_template SET unit_flags=2 WHERE entry=29281 LIMIT 1;
UPDATE creature_template SET unit_flags=2 WHERE entry=30809 LIMIT 1;

Look better :) Btw thank.

@Expecto

This comment has been minimized.

Show comment
Hide comment
@Expecto

Expecto Nov 20, 2011

nice work

Expecto commented Nov 20, 2011

nice work

@Albis

This comment has been minimized.

Show comment
Hide comment
@Albis

Albis Nov 20, 2011

Thanks amable. (btw how did you did, does github got some tag like [CODE] ?)

Albis commented Nov 20, 2011

Thanks amable. (btw how did you did, does github got some tag like [CODE] ?)

@nelegalno

This comment has been minimized.

Show comment
Hide comment
@nelegalno

nelegalno Nov 20, 2011

Contributor

The tag is </b> followed by the language ID ( in this case ) "SQL" and closes with <b>.

EXAMPLE:
SQL</b> SQL CODE LINE1 SQL CODE LINE2 SQL CODE LINE3 <b>

P.S. You need to leave an empty line before it in order for it to work correctly.

Contributor

nelegalno commented Nov 20, 2011

The tag is </b> followed by the language ID ( in this case ) "SQL" and closes with <b>.

EXAMPLE:
SQL</b> SQL CODE LINE1 SQL CODE LINE2 SQL CODE LINE3 <b>

P.S. You need to leave an empty line before it in order for it to work correctly.

@Norfik

This comment has been minimized.

Show comment
Hide comment
@Norfik

Norfik Jan 7, 2012

Contributor

Scripts/Utgarde Pinnacle: Rewritten script of Svala Sorrowgrave 3.3.5a and implementation of "The Incredible Hulk" achievement.

#4718

Contributor

Norfik commented Jan 7, 2012

Scripts/Utgarde Pinnacle: Rewritten script of Svala Sorrowgrave 3.3.5a and implementation of "The Incredible Hulk" achievement.

#4718

@DDuarte

This comment has been minimized.

Show comment
Hide comment
@DDuarte
Member

DDuarte commented Jan 8, 2012

@DDuarte DDuarte closed this Jan 8, 2012

Sovak pushed a commit to ProjectSkyfire/SkyFire_548 that referenced this issue Nov 29, 2013

Scripts/Utgarde Pinnacle:
- Re-write Svala Sorrowgrave
- Scripted achievement The Incredible Hulk.

This script was writen basing on work and data:
- Original TC script.
- Albis fix for Arthas sounds and texts TrinityCore/TrinityCore#4002 .
- Ric event start fix.
- Recorded encounters uploaded on YouTube.
- Data found on ScriptDev2 forums.
- Iov's custom SD2 repo and Svalas's script https://github.com/Iov/scriptdev2 .
Also thx to:
- ZxBiohazardZx for pointing how to fix looting problem when boss is killed when flying.
- Aokromes for confirmig how many times event "Ritual of the Sword" is performed.

- Mini event with Arthas.
- Call Flames: timers of cast and time between "Ball of Flame" (48246) can be wrong (based on videos).
- Ritual of the Sword works  and is performed once at 50% hp but:
  a) Still need retail data for teleport position of Svala floating above player.
  b) Need fully fixed spell Ritual of the Sword (48276), the triggering of spell Ritual Strike - Trigger Missile (48331) part was hardcoded.
- Spell Paralyze (48278) used by Ritual Channeler: fixed stacking and selection to ritual player only.
- Achievement "The Incredible Hulk": works but often Scourge Hulk don't get initial dmg from spell Ritual Strike (spell 48277 Effect #1 Value: 6650 to 7350).
- Looting problems when Svala was killed in air (require vmaps and option "vmap.enableHeight = 1" enabled in "worldserver.conf").
- Moved script_texts to creature_text.

It require option "vmap.enableHeight = 1" to work properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment