Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix Patch Binari Resit. #4116

Closed
Retriman opened this Issue · 18 comments

8 participants

@Retriman

After a lot of work with @Cepox, we show the term of this work, there is always some things that can be repaired and this is the reason for opening this Issue. have more information about missing this.

Fix in Part 1.
Retriman@a448f9c

Fix in Part 2.
Retriman@da45791

Fix in Part 3.
Retriman@893ac8f

Fix in Part 4.
Retriman@720ae04

Greetings and welcome your comments.

PD: Patch based in Dr.Temma Patchs.

INFO:
Its a patch to implement binary resistances. So characters can fully resists spells like fear, purge, polymorph etc, those spells that dont have a "damage" part or have both, damage and effect.

The problem is random crash with spells.

http://www.wowwiki.com/Resistance and http://www.wowwiki.com/Talk:Resistance

@kaelima

Perhaps you could explain what this is and what its for?

@Cepox

Its a patch to implement binary resistances. So characters can fully resists spells like fear, purge, polymorph etc, those spells that dont have a "damage" part or have both, damage and effect.

At the moment it has some problems with running on linux OS, with windows 7 and xp its fine. The problem is random crash with spells.

http://www.wowwiki.com/Resistance and http://www.wowwiki.com/Talk:Resistance

@Retriman

Problems in *Unix OS. Solved.

@Retriman

anyone tried this?, we need to have this crash log functional patch as soon as possible)!

@Ric101

\o/ will try it tomorrow

@Anonimo17

Can't test it any soon, but looks like a great job.

@Retriman

Hello @Ric101, some crashlog?

@Ric101

No crashes yet :D

@Retriman

@Ric101 , tested in my branch or CleanTC?.

not be possible if you try the patch to my branch https://github.com/Retriman/TrinityCore/commits/master

and your test patch with TC repository? (clean)

and at least in my local server and not had any crash, of course we are talking about 1 player online.

but with a population of 1000 + players that the server where we emulate our fix does not last more than 2 minutes UP. unfortunately I have not restarted with crashlog or GDB. (for administrator permissions on the machine).

this is why I would like to provide more information on how you tested.

thanks

@joshwhedon
  • targetInfo.missCondition = m_originalCaster->SpellHitResult(target, m_spellInfo, m_canReflect); This is the reason of your crashes : original caster disconnected -> crash.
@joshwhedon

bool binary = (uint32(sSpellMgr->GetSpellInfo(m_spellInfo->Id) && SPELL_ATTR0_CU_BINARY) > 0);
What the fuck ? Can you explain me what you do here ?

@Retriman

@joshwhedon, Finaly fix crash and more information for my patch in u inbox.
Retriman@fcd7f46

@SignFinder

Retriman tx for your work.
Tell me you did not appear in the resistance of normal mobs?

This patch fix this issue #1478

@Retriman

@joshwhedon and @anonimo17, thanks for your points were efficient in achieving solve some crash.

is any crash?, work (Retriman, Cepox) on this 100% to make this work as it should and running WITHOUT ANY crash.

@SignFinder, work resistance in Boss and Normal Boss.

@Cepox

@SignFinder , Yes mobs resistance is working and boss resistance is working too. Can you please test the patch and look for some crashes, because at the moment its very unstable under linux, carshes every 5 or 7 min with 400 ppl, probably related to instances.

@Anonimo17

Make a single patch file and I'll test it.

@SignFinder

@Anonimo17
here single patch
http://filebeam.com/4f79cfc4555c3abb2eedd87ffaa9723e
compilable, but not tested

@Retriman

no report yet? :(

@Aokromes Aokromes closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.