Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

[DK] Missing an attack doesn't automatically restores the runes you lost. #412

Closed
click opened this Issue · 5 comments

3 participants

@click
Collaborator

Missing an attack doesn't automatically restores the runes you lost. In retail they would reload in less than a GCD.

@click
Collaborator

Author: imnotyou
I have to add parry/dodge/blocked etc not only miss.

@click
Collaborator

Author: imnotyou
Since this problem has been there for a lot of time (even in the old tracker) I may consider it is really difficult to fix. I have not much idea about these things but how about this?
-In each spell of the DK that consumes runes, add some code than when it miss/dodged/parried/blocked it restores instantly the runes the spell has costed. In retail I think it will show the runes reloading at great speed in aproximately the same time of a gcd in unholy presence, but that's just aesthetics.

@click
Collaborator

Author: fecker
Not sure about miss, but sure about parry/dodge.
Your runes go on cd after your attacks are dodged/parried.
After dodge/parry your runes should go on GCD(1s-UH,1.5s-FP,BP).

@click
Collaborator

Author: greymane
I think the trick with the runes should be done on Spell::CheckRuneCost, adding some code like:

{{{

if (code_for_missed_parryed_dodged)
(src->NoRuneCost())
}}}

Or something like that, idk, just giving a shot in the darkness :P

Edit: or maybe something on Spell:TakePower()

{{{
if (hit && powerType == POWER_RUNE)
{
TakeRunePower();
return;
}
}}}

C'mon devs, this shouldn't be a thing so hard to fix :D

@QAston QAston was assigned
@Subv Subv closed this issue from a commit
@Subv Subv Core/Spells: Fixes the rune cooldown when a hit mises the target
Closes #412

Signed-off-by: Subv <s.v.h21@hotmail.com>
7ce33ca
@Subv Subv closed this in 7ce33ca
@eilo eilo referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@raczman raczman referenced this issue from a commit in raczman/TrinityCore
@Subv Subv Core/Spells: Fixes the rune cooldown when a hit mises the target
Closes #412

Signed-off-by: Subv <s.v.h21@hotmail.com>
78ab3f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.