[crash] WardenWin::RequestData #5469

Closed
daniik opened this Issue Feb 27, 2012 · 27 comments

5 participants

@Ka0z
Contributor
Ka0z commented Feb 28, 2012

Try the new rev with the recent change from @Machiavelli 218ed81

@leak
Contributor
leak commented Feb 29, 2012

Here some debug code: http://paste2.org/p/1920051

If that crash occures again post the line of the server log that says "WARDEN DEBUG CODE".

@leak leak was assigned Feb 29, 2012
@daniik
Contributor
daniik commented Feb 29, 2012

Ok i will try ty

@daniik
Contributor
daniik commented Feb 29, 2012

http://paste2.org/p/1920531

#2 0x0000000000be1ba0 in WardenWin::RequestData (this=) at /home/emu/wotlk/src/server/game/Warden/WardenWin.cpp:269
269 if (!wd->Data.AsByteArray(0, false))

@leak
Contributor
leak commented Feb 29, 2012

What OpenSSL version are you running?

@daniik
Contributor
daniik commented Feb 29, 2012

OpenSSL 1.0.0g 18 Jan 2012

@jobbais
jobbais commented Mar 1, 2012

@ Leak

got a new crash WardenWin::HandleData

http://paste2.org/p/1921776

Trinity Revision: 92af6ec

@leak
Contributor
leak commented Mar 4, 2012
@leak
Contributor
leak commented Mar 5, 2012

Feedback, anyone?

@jobbais
jobbais commented Mar 5, 2012

sorry leak i didnt got time yet to inplement this patch too busy with real life things..

@jobbais
jobbais commented Mar 6, 2012

going to inplement this right now Leak so expect within a few hours feedback if this is working or not..

and while we are at it Leak, can you please concider this suggestion that i made? http://www.trinitycore.org/f/topic/5790-suggestion-for-warden/

@daniik
Contributor
daniik commented Mar 6, 2012

I'am testing since yesterday. We must wait for any results

@jobbais
jobbais commented Mar 6, 2012

well i can say testing this for 1 hour now, that i havent got a crash on warden at this point, there was 1 crash but related to vehicle ( offcourse :P )

so there hope on the end of the tunnel..

@jobbais
jobbais commented Mar 6, 2012

@leak
Online for 1 hour, 23 minutes, 28 seconds
so i can say that the patch is working, normally it was online for 10 minutes max without it.
so i think its save to push it to repo..
if you wait a little bit longer then i can give you more feedback, but for now it looks good.

@jobbais
jobbais commented Mar 6, 2012

okay after more then 3 hours no crash so this patch work Leak.

@leak leak closed this in 700203a Mar 6, 2012
@Asido Asido pushed a commit to Asido/TrinityCore that referenced this issue Mar 12, 2012
@leak leak Core/Shared: Add thread-safe access to BigNumber::AsByteArray()
fixes #5469
3136f74
@telsamat

#5668 I have maybe similar problem...can you look at this

@jobbais
jobbais commented Mar 12, 2012

no no, telsamat, i use warden on a populated server and dont have problems with this, as far as i know Warden is not crashing now anymore, BUT is since multi thread not really good usable.. even my gms gets banned lawl.

@telsamat

I have mapupdatethreads on 16, I dont know, but after I have entered the world, server crashes with this backtrace in my post :/

@jobbais
jobbais commented Mar 12, 2012

lower it then, i think i have 12, why in gods name you do 16 anyway..
i think even that 4 is more then enough or maybe 8,

@telsamat

I have 8 and still crash

@jobbais
jobbais commented Mar 18, 2012

maybe update your core to latest revision telsamat..

@telsamat

I always use newest rev. after loging to world - crash

@telsamat
telsamat commented Apr 7, 2012

here better crashdump, rev from today

http://pastebin.com/4eknw2tt

@telsamat

solved

@jobbais
jobbais commented Apr 17, 2012

so what was it?

@telsamat

I have had SSL 0.9.8o, now with 1.0.0g works without crash , someone can rewrite wiki :P

@jobbais
jobbais commented Apr 17, 2012

omg!!!, i had that MONTHS ago aswell, but i totally forgot that indeed you need to have 1.0 or higher, and i did even pointed since i had 1.0 to the old one and had the same problem again.
so yeah, confirmed warden doesnt work and therefor trinity with 0.98,

@raczman raczman pushed a commit to raczman/TrinityCore that referenced this issue Apr 20, 2014
@leak leak Core/Shared: Add thread-safe access to BigNumber::AsByteArray()
fixes #5469
63f7f33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment