[Core/Items] Massive Seaforium Charge bugged in SOTA #6626

Open
Vasago opened this Issue May 28, 2012 · 24 comments
@Vasago
Vasago commented May 28, 2012 edited

CORE revision number : https://github.com/TrinityCore/TrinityCore/commits/master
Database: TDB 335.11.47
Patches: WG

Massive Seaforium Charge http://www.wowhead.com/item=39213 is not working properly in SOTA

  1. When one alliance player places the bomb - horde player cannot deactivate it and other way around
  2. It has no exploding effect
  3. Taking bomb is dismounting player - it should NOT

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@garyfisher

Confirm!

Core: TrinityCore/TrinityCore@fcc524d

TDB: TDB 335.49+

@digz6666

Confirmed!

@NeKroZ
NeKroZ commented Nov 23, 2012

@Vasago . Confirmed,

@durrrr
durrrr commented Nov 23, 2012

Cofirmed.

@kandera kandera was assigned Nov 24, 2012
@Ryosan23

Any fix?¿

@Vasago
Vasago commented Feb 12, 2013

Nothing in a year when original issue was reported (this is third report already)

@Expecto
Expecto commented Oct 20, 2014

Hello Guys, Use my fix (Works Fine)

http://paste.org.ru/?j4avq8

Screenshot: http://i.imgur.com/bdxMxu8.jpg

@kandera kandera was unassigned by Vasago Oct 20, 2014
@joschiwald joschiwald was assigned by Aokromes Feb 12, 2015
@Aokromes
Member

@joschiwald can you check if this is valid? :)

@dr-j
Contributor
dr-j commented Feb 26, 2015

Theres actually more things wrong with this

When a player takes massive seaforium charge they obtain the buff carrying seaforium but this buff can be removed by player who took bomb and massive seaforium remains in player inventory and can still be used but:

  1. Player no longer has the buff so enemy players cant tell that player is carrying bomb
  2. When killed player does not drop bomb for enemy player to pick up
  3. Credit is not given towards drop it achievement (kill 100 players carrying seaforium.
@Keader
Member
Keader commented Aug 3, 2015

still valid anyway ✌️
aff9672

@Raydor
Raydor commented Aug 3, 2015

aff9672
Confirmed, also confirm @dr-j comment. The fix from @Expecto is already in the core and it only fixes the achievement, not the deactivate effect for the bombs.

@Nyeriah
Contributor
Nyeriah commented Aug 3, 2015

.learn 1843 and try again.

@Raydor
Raydor commented Aug 3, 2015

@Nyeriah yeah with that now bombs can be deactivated, but they still don't give the player who deactivated the bomb another bomb, but well, the point 1 of the bugs in #6626 (comment) is solved by .learn 1843...

@Raydor
Raydor commented Aug 4, 2015

Then... is spell 1843 intended to be learned on char create or something?

@Rushor
Contributor
Rushor commented Aug 4, 2015
@Keader
Member
Keader commented Aug 25, 2015

Any news?

@Rushor
Contributor
Rushor commented Nov 14, 2015
diff --git a/src/server/game/Battlegrounds/Zones/BattlegroundSA.cpp b/src/server/game/Battlegrounds/Zones/BattlegroundSA.cpp
index e88ca9c..cc52d7c 100644
--- a/src/server/game/Battlegrounds/Zones/BattlegroundSA.cpp
+++ b/src/server/game/Battlegrounds/Zones/BattlegroundSA.cpp
@@ -522,6 +522,8 @@ void BattlegroundSA::AddPlayer(Player* player)
         else
             player->TeleportTo(607, 1209.7f, -65.16f, 70.1f, 0.0f, 0);
     }
+
+    player->LearnSpell(SPELL_LEARN_DISARM, false);
 }

 void BattlegroundSA::HandleAreaTrigger(Player* /*Source*/, uint32 /*Trigger*/)
diff --git a/src/server/game/Battlegrounds/Zones/BattlegroundSA.h b/src/server/game/Battlegrounds/Zones/BattlegroundSA.h
index 60a0b43..426a4e8 100644
--- a/src/server/game/Battlegrounds/Zones/BattlegroundSA.h
+++ b/src/server/game/Battlegrounds/Zones/BattlegroundSA.h
@@ -82,7 +82,8 @@ enum SASpellIds
     SPELL_END_OF_ROUND                      = 52459,
     SPELL_REMOVE_SEAFORIUM                  = 59077,
     SPELL_ALLIANCE_CONTROL_PHASE_SHIFT      = 60027,
-    SPELL_HORDE_CONTROL_PHASE_SHIFT         = 60028
+    SPELL_HORDE_CONTROL_PHASE_SHIFT         = 60028,
+    SPELL_LEARN_DISARM                      = 1843
 };

 enum SACreatureIds
@Aokromes
Member

If the fix here is valid, plz open a PR.

@Aokromes
Member
Aokromes commented Jul 9, 2016

@Shauren @joschiwald rushor's fix is valid?

@Raydor
Raydor commented Jul 9, 2016 edited

@Aokromes I don't know if its good for a PR, but what I can say is that the fix works.

@tkrokli
Member
tkrokli commented Jul 10, 2016

I think Rushor would have written it clearly if his suggestion is a hack, especially as late as in 2015.

@Golrag
Contributor
Golrag commented Jul 11, 2016

I've seen this spell being cast, but i'm not sure if the player should learn the spell, looking at Lock.DBC
https://trinitycore.atlassian.net/wiki/display/tc/Lock
Lock Entry 1819 has type 3 and lockproperty 1843 (which is the spell being cast).

@Golrag
Contributor
Golrag commented Oct 31, 2016

Try Golrag@c13a5c1
Made it a couple of months ago, never finished it due to the bugs it created (see commit message for known created bugs) and couldn't fix them (so I'm not sure if it's worth a PR) also, not much time to continue my work on it :/

@ariel-
Member
ariel- commented Oct 31, 2016

I already have done a battleground rewrite, the branch is stalled, waiting for dynamic spawn implementation so the work is not done twice.

The problem with the bombs is that players don't have the disarm spell learned (should they?)
Client sends a CMSG_CAST_SPELL opcode so maybe there is a dbc magic we can use to skip the HasSpell check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment