CORE revision number : https://github.com/TrinityCore/TrinityCore/commits/master
Database: TDB 335.11.47
Massive Seaforium Charge http://www.wowhead.com/item=39213 is not working properly in SOTA
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
TDB: TDB 335.49+
@Vasago . Confirmed,
Nothing in a year when original issue was reported (this is third report already)
Hello Guys, Use my fix (Works Fine)
@joschiwald can you check if this is valid? :)
Theres actually more things wrong with this
When a player takes massive seaforium charge they obtain the buff carrying seaforium but this buff can be removed by player who took bomb and massive seaforium remains in player inventory and can still be used but:
still valid anyway ✌️
Confirmed, also confirm @dr-j comment. The fix from @Expecto is already in the core and it only fixes the achievement, not the deactivate effect for the bombs.
.learn 1843 and try again.
@Nyeriah yeah with that now bombs can be deactivated, but they still don't give the player who deactivated the bomb another bomb, but well, the point 1 of the bugs in #6626 (comment) is solved by .learn 1843...
Then... is spell 1843 intended to be learned on char create or something?
seems to be betaspell or sth http://www.wowhead.com/spell=1843/disarm#comments
diff --git a/src/server/game/Battlegrounds/Zones/BattlegroundSA.cpp b/src/server/game/Battlegrounds/Zones/BattlegroundSA.cpp
index e88ca9c..cc52d7c 100644
@@ -522,6 +522,8 @@ void BattlegroundSA::AddPlayer(Player* player)
player->TeleportTo(607, 1209.7f, -65.16f, 70.1f, 0.0f, 0);
+ player->LearnSpell(SPELL_LEARN_DISARM, false);
void BattlegroundSA::HandleAreaTrigger(Player* /*Source*/, uint32 /*Trigger*/)
diff --git a/src/server/game/Battlegrounds/Zones/BattlegroundSA.h b/src/server/game/Battlegrounds/Zones/BattlegroundSA.h
index 60a0b43..426a4e8 100644
@@ -82,7 +82,8 @@ enum SASpellIds
SPELL_END_OF_ROUND = 52459,
SPELL_REMOVE_SEAFORIUM = 59077,
SPELL_ALLIANCE_CONTROL_PHASE_SHIFT = 60027,
- SPELL_HORDE_CONTROL_PHASE_SHIFT = 60028
+ SPELL_HORDE_CONTROL_PHASE_SHIFT = 60028,
+ SPELL_LEARN_DISARM = 1843
If the fix here is valid, plz open a PR.
@Shauren @joschiwald rushor's fix is valid?
@Aokromes I don't know if its good for a PR, but what I can say is that the fix works.
I think Rushor would have written it clearly if his suggestion is a hack, especially as late as in 2015.
I've seen this spell being cast, but i'm not sure if the player should learn the spell, looking at Lock.DBC
Lock Entry 1819 has type 3 and lockproperty 1843 (which is the spell being cast).
Made it a couple of months ago, never finished it due to the bugs it created (see commit message for known created bugs) and couldn't fix them (so I'm not sure if it's worth a PR) also, not much time to continue my work on it :/
I already have done a battleground rewrite, the branch is stalled, waiting for dynamic spawn implementation so the work is not done twice.
The problem with the bombs is that players don't have the disarm spell learned (should they?)
Client sends a CMSG_CAST_SPELL opcode so maybe there is a dbc magic we can use to skip the HasSpell check