Skip to content

Modify reputation not updating #7939

Closed
gpascualg opened this Issue Oct 1, 2012 · 10 comments

9 participants

@gpascualg

The command ".mod rep faction value" is not updating the client (relog must be done), though it does modify the reputation on the server side.

Rev: 174deb1
OS: Centos 6 64 bits
TDB 335.49

@SgT-Fatality

Hello,

Here is a patch to fix your problem :

 src/server/scripts/Commands/cs_modify.cpp |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/server/scripts/Commands/cs_modify.cpp b/src/server/scripts/Commands/cs_modify.cpp
index a88c765..de92dd1 100644
--- a/src/server/scripts/Commands/cs_modify.cpp
+++ b/src/server/scripts/Commands/cs_modify.cpp
@@ -1237,6 +1237,7 @@ public:
         }

         target->GetReputationMgr().SetOneFactionReputation(factionEntry, amount, false);
+       target->GetReputationMgr().SendState(target->GetReputationMgr().GetState(factionEntry));
         handler->PSendSysMessage(LANG_COMMAND_MODIFY_REP, factionEntry->name[handler->GetSessionDbcLocale()], factionId,
             handler->GetNameLink(target).c_str(), target->GetReputationMgr().GetReputation(factionEntry));
         return true;

By the way I think we should use "SetReputation" and not "SetOneFactionReputation". Because in "SetReputation" the function send the new state to client by the "SendState" function. And not in "SetOneFactionReputation".

@CDawg
CDawg commented Oct 3, 2012

Wow, this has been a problem for a very long time... I figured just relogging the toon to fix the issue. haha

@Subv
Subv commented Oct 3, 2012

@SgT-Fatality SetOneFactionReputation ensures that no spillover reputation templates are used (means we only get reputation for the faction we specified, and nothing more).

@tibbi
tibbi commented Oct 6, 2012

the suggested fix works fine

@SgT-Fatality

@Subv Alright, thanks a lot for your explanations !

@kandera kandera was assigned Nov 24, 2012
@Expecto
Expecto commented Dec 3, 2012

confirm

@Nevadas
Nevadas commented Jan 2, 2013

Any News about this? Can it pushed?

@ghost
ghost commented Feb 9, 2013

Thx SgT-Fatality, I test and work very fine ^^
pls implement inside the repository :P

@SgT-Fatality

You're welcome ;)

@Ascathor Ascathor added a commit that referenced this issue Mar 5, 2013
@Ascathor Ascathor Several changes:
Modify reputation on usage
#7939 - Fix by @SgT-Fatality

Fixes Spam Chat Check for Gms and Players
#9332 - Fix by @e000

Reversing on .ticket assign changes because of bugs
#9333 - Changes by @e000

Added a "todo" to resetTalents
Noted by @Vincent-Michael
86fd039
@DDuarte DDuarte added a commit that closed this issue Mar 9, 2013
SgT-Fatality Scripts/Commands: Fix .mod rep faction not updating client side reput…
…ation

Closes #7939
Closes #9354
8e8617c
@DDuarte DDuarte closed this in 8e8617c Mar 9, 2013
@DDuarte DDuarte added a commit to raczman/TrinityCore that referenced this issue Apr 20, 2014
SgT-Fatality Scripts/Commands: Fix .mod rep faction not updating client side reput…
…ation

Closes #7939
Closes #9354
1073524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.