Party/Group/Raid #846

Closed
click opened this Issue May 16, 2011 · 29 comments

Projects

None yet
@click
Member
click commented May 16, 2011

some players can't leave party. also they aren't in a group but can't join party when other player invites he. also he can't invite someone. there is a message that he isn't party leader but he isn't in a group or raid.

I think this is from
aa2455b

or

4dc1bf3

@click
Member
click commented May 16, 2011

Author: telsamat
please test this patch here http://www.trinitycore.org/t/trinitycore/ticket/736

@click
Member
click commented May 16, 2011

Author: leak
The patch in #736 shouldn't really have anything todo with this issue.

As for the actual bug, aa2455b was supposed to solve exactly that bug (Players not having a group interface while appearing to be in a group).

Please provide more information (error log, sql errors, etc.) how and when (bg, arena, dungeon finder, regular raid) this issue occurs.

@click
Member
click commented May 16, 2011

Author: tabo
players said that they always freeze in a party after arena match.

@click
Member
click commented May 16, 2011

Author: bloddy
leak the problem is when core crash, and after load again the table you set +1 you need to add check if that member has party/raid ID.

SQL I don't see any error.

@click
Member
click commented May 16, 2011

Author: leak
Please check if your problems persist after updating to f5e9c2c.

@click
Member
click commented May 16, 2011

Author: tabo
I updated trinitycore but problem still exist

@click
Member
click commented May 16, 2011

Author: chaosua
TC rev 1618afc
problem still exist
no sql errors in log

@click
Member
click commented May 16, 2011

Author: liho
there was same ticket: http://www.trinitycore.org/t/trinitycore/ticket/807
... players sometimes just don't see party, ticket 807 was closed as "fixed",
but this problem still persists (confirmed on rev 12015)

... it happens after battleground / arena match

@Elyotna
Elyotna commented May 22, 2011

Yup, this is still happening. After an arena match, players can't see their group (except for the leader sometimes) and usually need to group again.

@xjose93
Contributor
xjose93 commented Jun 14, 2011

Confirm after arena match...

@Saurom
Saurom commented Jun 18, 2011

Confirm after arena match and battlegrounds.. Players don't see their groups and need to relog to leave it automatically.

@cyberbrest
Contributor

i fix this problem by using mutex on GroupReference (calls GetFirstMember() ). there are a lot problems not safe using of GetFirstMember() (lost group after arena and etc).
Sorry but I fully reWright core and could't print patch.

@Miryu
Miryu commented Jul 7, 2011

Confirmed.. any progress with the solution?

@Miryu
Miryu commented Jul 10, 2011

Cyberbrest can U send the whole script pls?

@OneB1t
OneB1t commented Jul 11, 2011

jesus 3 months of broken groups please backport what caused this :-(

@cyberbrest
Contributor

sorry, problem not in MT, mutexing not help.

@jslack
jslack commented Jul 11, 2011

Really, try revert: aa2455b + 4dc1bf3

Maybe its work

@cyberbrest
Contributor

possible yes.
someone reaply 4dc1bf3
i think it could be fix a problem

@cyberbrest
Contributor

Someone try this on Battleground.cpp

 #include "SpellAuras.h"
 #include "SpellAuraEffects.h"
 #include "Util.h"
+#include "GroupMgr.h"

 namespace Trinity
 {
@@ -1327,6 +1328,7 @@
         group = new Group;
         SetBgRaid(team, group);
         group->Create(player);
+        sGroupMgr->AddGroup(group);
     }
     else                                            // raid already exist
     {
@jslack
jslack commented Jul 11, 2011

i cant test now...

@OneB1t
OneB1t commented Jul 11, 2011

compiled fine :-)
waiting for testers reply
EDIT: not working for me :-(

@jslack
jslack commented Jul 12, 2011

Reverting all revs above, fix.

@OneB1t
OneB1t commented Jul 12, 2011

just revert or i need to add something somewhere ? :D

@jslack
jslack commented Jul 13, 2011

Any dev is checking it ? Its very old and a major bug

@OneB1t
OneB1t commented Jul 16, 2011

bump!!!

@lost-illusion
Contributor
  1. Player_1 leave

  2. Player_2 leave while Player_1 is loading

  3. Player_1 not access and grop not update

  4. Player_1 load and see Player_2

  5. Player_2 load and not see Player_1

    if (!player || !player->GetSession() || player->GetGroup() != this)
        continue;
    

failed and group not update for Player_2

@Loginisalreadytaken

Still doesn't work properly.

Just left a battleground and while not being in a group or raid and so I can't leave them either, the default raid interface is up saying that my character is member 2, 3, 4 & 5 of group 2 - also, group 3 is still intact (all showing as dead).

This part got worse since we had the October 22nd patch. Very often, only the first group of the raid is removed from the screen. Either the groups are messed up on the server or the information isn't sent out to the clients properly.
How about sending full current group info to a client after zoning? It updates properly otherwise.

Version: 3.3.5a (12340)
Core revision: Trinity Core e5c0be0+
Database revision: TDB 335.11.43

@Subv
Contributor
Subv commented Jan 18, 2012

Could somebody retest this? i think it got fixed already

@Aokromes
Member

Try again on head if it's valid yet open a new ticket.

@Aokromes Aokromes closed this Feb 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment