Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[Shadowmourne] Frost Infusion #9487

Closed
L30m4nc3r opened this Issue Mar 22, 2013 · 14 comments

Comments

Projects
None yet
6 participants

TDB .49 + upd
TC: 4e1a4b3
after e49aaab
Quest: http://www.wowhead.com/quest=24757
does not work
http://s003.radikal.ru/i202/1303/5c/cc405c01d91e.jpg
http://s51.radikal.ru/i133/1303/93/c08da25f63d2.jpg
3 stuck aura its okay http://www.wowhead.com/spell=70123
after kills sindragosa buff its ok: http://www.wowhead.com/spell=72290
quest does not complete.

my bad english

@Gacko Gacko was assigned Mar 22, 2013

Member

Gacko commented Mar 22, 2013

Well... solution inc. I found some code here:

class spell_item_unsated_craving : public SpellScriptLoader
{
    public:
        spell_item_unsated_craving() : SpellScriptLoader("spell_item_unsated_craving") { }

        class spell_item_unsated_craving_AuraScript : public AuraScript
        {
            PrepareAuraScript(spell_item_unsated_craving_AuraScript);

            bool CheckProc(ProcEventInfo& procInfo)
            {
                Unit* caster = procInfo.GetActor();
                if (!caster || caster->GetTypeId() != TYPEID_PLAYER)
                    return false;

                Unit* target = procInfo.GetActionTarget();
                if (!target || target->GetTypeId() != TYPEID_UNIT || target->GetCreatureType() == CREATURE_TYPE_CRITTER || target->isSummon())
                    return false;

                return true;
            }

            void Register()
            {
                DoCheckProc += AuraCheckProcFn(spell_item_unsated_craving_AuraScript::CheckProc);
            }
        };

        AuraScript* GetAuraScript() const
        {
            return new spell_item_unsated_craving_AuraScript();
        }
};

And as Sindragosa is not spawned permanently I assume it's a summon. And then the second check will fail.

Contributor

untaught commented Mar 22, 2013

I reported this some time ago but it was said that the quest is working.

Member

Gacko commented Mar 22, 2013

Iirc Joschiwald converted some proc scripts from Unit to seperate spell scripts. Did you file your issue before or after this changes? If after: See above :)

@untaught issue please.
u confirm?

Contributor

untaught commented Mar 22, 2013

Member

Gacko commented Mar 22, 2013

Try this...

don't know why one user in my server completed the quest few days ago while lots of players could not achieve it doing it correclty

i think we have an old bug that if you get ice tombed during Sindragosa's combat and you are doing that quest, you dont get it completed.

Member

Gacko commented Mar 25, 2013

As there is no more negative reaction nor any new issue confirmation, I will close it here.

Please post new confirmations in this issue instead of creating a new one.

@Gacko Gacko closed this Mar 25, 2013

Ganztxd commented Mar 27, 2013

i was trying to complete this quets yesterday, i did as L30m4nc3r said and quets dont complete.
Regards.

Member

Gacko commented Mar 28, 2013

Revision?

Ganztxd commented Mar 29, 2013

Im using trinity master, my last update was on 2013-03-26
Regards.

It works correctly

''i think we have an old bug that if you get ice tombed during Sindragosa's combat and you are doing that quest, you dont get it completed. ''

it was this bug because the char who was doing the quest was infused with the buff of the shadowmourne and he was pointed with the tomb by Sindragosa but the tomb never appeared at him, so the quest completed.

Thanks!

Ganztxd commented Mar 31, 2013

Same ass kurukuku thx gacko and sorry for my bad report.

@raczman raczman pushed a commit to raczman/TrinityCore that referenced this issue Apr 20, 2014

@Gacko Gacko Script/Spell: Apply Shadow's Fate to Sindragosa
Sindgragosa is summoned in instance script and would not pass the modified check otherwise

Related to: #9487
c13abe3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment