Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Core/Spell: #10887

Merged
merged 1 commit into from Jul 8, 2014

Conversation

Projects
None yet
5 participants
Contributor

zorix commented Sep 20, 2013

Triggered spells now will be cast on the primal target instead of on caster

Close #10853
Close #10860

Contributor

Subv commented Sep 21, 2013

This reminds me that we should NULL-check the target variable after calling the AreaObjectTargetSelect/ObjectTargetSelect hooks for AuraScripts and SpellScripts.

@Shauren Shauren was assigned Sep 21, 2013

@zorix zorix Core/Spell:
Triggered spells now will be cast on the primal target instead of on caster

Close #10853
Close #10860
e9b7bb0

@jackpoz jackpoz commented on the diff Jan 27, 2014

src/server/game/Spells/Spell.cpp
@@ -1357,6 +1357,7 @@ void Spell::SelectImplicitCasterDestTargets(SpellEffIndex effIndex, SpellImplici
void Spell::SelectImplicitTargetDestTargets(SpellEffIndex effIndex, SpellImplicitTargetInfo const& targetType)
{
+ ASSERT(m_targets.GetObjectTarget() && "Spell::SelectImplicitTargetDestTargets - no explicit object target available!");

@Shauren Shauren closed this Jun 23, 2014

@Aokromes Aokromes reopened this Jun 23, 2014

@Subv Subv added a commit that referenced this pull request Jul 8, 2014

@Subv Subv Merge pull request #10887 from zorix/PR3
Core/Spell:  Triggered spells now will be cast on the primal target instead of on caster

Closes #10853
Closes #10860
4a4da95

@Subv Subv merged commit 4a4da95 into TrinityCore:master Jul 8, 2014

@zorix zorix deleted the unknown repository branch Oct 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment