Scripts/Krikthir the Gatewatcher: converted to EventMap and small optimalization #11457

Merged
merged 1 commit into from Feb 9, 2014

Projects

None yet

4 participants

@MitchesD
Contributor
  • removed herioc version of spells (already in spelldifficulty_dbc)
@Kittnz
Contributor
Kittnz commented Jan 17, 2014

Love the work your doing MitchesD!

@joschiwald joschiwald commented on an outdated diff Jan 18, 2014
...jolNerub/AzjolNerub/boss_krikthir_the_gatewatcher.cpp
{
- summoned->GetMotionMaster()->MovePoint(0, me->GetPositionX(), me->GetPositionY(), me->GetPositionZ());
+ return GetInstanceAI<boss_krik_thirAI>(creature);
@joschiwald
joschiwald Jan 18, 2014 Member

replace GetInstanceAI with GetAzjolNerubAI

@joschiwald joschiwald commented on an outdated diff Jan 18, 2014
...jolNerub/AzjolNerub/boss_krikthir_the_gatewatcher.cpp
- Talk(SAY_SLAY);
- }
+ private:
+ InstanceScript* instance;
@joschiwald
joschiwald Jan 18, 2014 Member

it's already a member of bossai

@joschiwald joschiwald commented on an outdated diff Jan 18, 2014
...jolNerub/AzjolNerub/boss_krikthir_the_gatewatcher.cpp
- struct npc_skittering_infectorAI : public ScriptedAI
- {
- npc_skittering_infectorAI(Creature* creature) : ScriptedAI(creature) { }
+ void JustDied(Unit* /*killer*/) OVERRIDE
+ {
+ //The spell is not working propperly
+ DoCastVictim(SPELL_ACID_SPLASH, true);
@joschiwald
joschiwald Jan 18, 2014 Member

npc will not have a target here, change it to DoCastAOE() and check conditions for this spell

@joschiwald joschiwald was assigned Jan 18, 2014
@FireEmerald FireEmerald commented on an outdated diff Jan 21, 2014
sql/updates/world/2014_01_18_00_world_conditions.sql
@@ -0,0 +1,3 @@
+DELETE FROM `conditions` WHERE `SourceEntry` = 52446 AND `SourceTypeOrReferenceId` = 13;
+INSERT INTO `conditions` (`SourceTypeOrReferenceId`, `SourceGroup`, `SourceEntry`, `SourceId`, `ElseGroup`, `ConditionTypeOrReference`, `ConditionTarget`, `ConditionValue1`, `ConditionValue2`, `ConditionValue3`, `NegativeCondition`, `ErrorType`, `ErrorTextId`, `Comment`) VALUES
+(13,1,52446,0,0,31,0,3,28684,0,1,0,0,'Spell Acid Splash cannot hit 28684');
@FireEmerald
FireEmerald Jan 21, 2014 Contributor

Why not the name instead of a NPC ID? Or both? It's Krik'thir the Gatewatcher (28684).

@joschiwald joschiwald merged commit 6688370 into TrinityCore:master Feb 9, 2014
@MitchesD MitchesD deleted the unknown repository branch Mar 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment