Fix Death Grip when caster is jumping or falling #11648

Closed
wants to merge 1 commit into
from

Projects

None yet

6 participants

@zabustak
Contributor

Death Grip castable while jumping/falling and it shouldn't do that.

@zabustak zabustak referenced this pull request Feb 25, 2014
Closed

Death Grip #432

@Ascathor
Contributor

If I may bring an input.
I believe you can use it on knockback. However, not on consciously jumping and falling down. The difference is that you could jump and fall cliffs down on your own agenda - while a knockback is by enemy input. As a last resort, the death grip is a nice "last choice" cast for the DK against knockbackers while he can not use it to pull lame moves.

@gigatotem
Contributor

@PortgasDAce The report is correct.

I've just tested it on Retail.

Attempting to cast Death Grip while you're jumping or falling will return a "Cant do that while moving" error.

@joschiwald
Member

move it into spell_dk_death_grip and correct castresult to SPELL_FAILED_MOVING

@zabustak
Contributor
zabustak commented Mar 2, 2014

Done and also fixed for rooted target

@joschiwald
Member

sry about my previous comment, spell_dk_death_grip is not the initial spell of deathgrip, needs new spellscript for 49576
but maybe there is an unknown attribute to handle this

@Vincent-Michael
Member

pls try with conditions in db

@joschiwald
Member

not possible

@zabustak
Contributor
zabustak commented Mar 4, 2014

what script name you want for initial spell ?

@joschiwald
Member

spell_dk_death_grip_initital | spell_dk_death_grip
spell_dk_death_grip | spell_dk_death_grip_effect
spell_dk_death_grip | spell_dk_death_grip_jump

something like that, feel free to find a better name

@Aokromes
Member
Aokromes commented Jun 8, 2014

@zabustak you are alive? :P

@zabustak
Contributor
@zabustak zabustak closed this Jun 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment